Re: [VOTE] merge branches/Temp_BasicSideFloats to trunk

2014-12-01 Thread Luis Bernardo
Thank you to all that voted. Since there are no objections or bugs reported I will proceed with the merge. On 11/25/14, 2:41 PM, Luis Bernardo wrote: I would like to merge the branch branches/Temp_BasicSideFloats to trunk. The branch has a implementation of side floats that uses the same

Re: [VOTE] merge branches/Temp_BasicSideFloats to trunk

2014-11-27 Thread Chris Bowditch
Hi Luis, Great work. +1 from me. Thanks, Chris On 25/11/2014 14:41, Luis Bernardo wrote: I would like to merge the branch branches/Temp_BasicSideFloats to trunk. The branch has a implementation of side floats that uses the same approach used when handling change in IPD across pages.

RE: [VOTE] merge branches/Temp_BasicSideFloats to trunk

2014-11-27 Thread Robert Meyer
: [VOTE] merge branches/Temp_BasicSideFloats to trunk Hi Luis, Great work. +1 from me. Thanks, Chris On 25/11/2014 14:41, Luis Bernardo wrote: I would like to merge the branch branches/Temp_BasicSideFloats to trunk. The branch has a implementation of side floats that uses

Re: [VOTE] merge branches/Temp_BasicSideFloats to trunk

2014-11-26 Thread Pascal Sancho
Hi Luis, great job! +1 2014-11-25 15:41 GMT+01:00 Luis Bernardo lmpmberna...@gmail.com: I would like to merge the branch branches/Temp_BasicSideFloats to trunk. The branch has a implementation of side floats that uses the same approach used when handling change in IPD across pages. These

Re: [VOTE] merge branches/Temp_BasicSideFloats to trunk

2014-11-26 Thread Clay Leeds
Looks like a great addition, Luis! +1 from me! Cheers! Clay -- My religion is simple. My religion is kindness. - HH The Dalai Lama of Tibet On Nov 25, 2014, at 3:05 PM, Luis Bernardo lmpmberna...@gmail.com wrote: Includes layout tests. On 11/25/14, 5:14 PM, Glenn Adams wrote: What

Re: [VOTE] merge branches/Temp_BasicSideFloats to trunk

2014-11-25 Thread Glenn Adams
What are your plans for testing? I haven't looked, but does your branch include new unit tests for this feature? On Tue, Nov 25, 2014 at 7:41 AM, Luis Bernardo lmpmberna...@gmail.com wrote: I would like to merge the branch branches/Temp_BasicSideFloats to trunk. The branch has a

Re: [VOTE] merge branches/Temp_BasicSideFloats to trunk

2014-11-25 Thread Glenn Adams
in that case, +1 from me On Tue, Nov 25, 2014 at 4:05 PM, Luis Bernardo lmpmberna...@gmail.com wrote: Includes layout tests. On 11/25/14, 5:14 PM, Glenn Adams wrote: What are your plans for testing? I haven't looked, but does your branch include new unit tests for this feature? On Tue,