Re: Question on protected Logger member in some classes
You're right. These protected variables are sometimes not ideal. If you change anything to private while you work on the code, that's fine for me. On 03.10.2006 15:02:28 Andrejus Chaliapinas wrote: Hi, While trying to debug some changes I've made wtih layout managers I've noticed that some classes have Logger as protected but not private member? What is the rationale here - just easy later inheritance of logger or anything else? For me it seems that logger purpose is to exactly identify the class, which makes some output and thus shown by name and not see some parent class name in output. What do you think? How about changing that current protected to private? Thank you, Andrejus Jeremias Maerki
RE: Question on protected Logger member in some classes
You're right. These protected variables are sometimes not ideal. If you change anything to private while you work on the code, that's fine for me. Could you apply this patch to trunk? http://issues.apache.org/bugzilla/attachment.cgi?id=18956 Andrejus
Re: Question on protected Logger member in some classes
As soon as I have time and write access to the SVN repo. Here at the Cocoon GetTogether we're having some problems accessing SVN over HTTPS. If anyone else can do that in the meantime, that would be great. There are other patches also waiting to be processed. On 03.10.2006 16:05:48 Andrejus Chaliapinas wrote: You're right. These protected variables are sometimes not ideal. If you change anything to private while you work on the code, that's fine for me. Could you apply this patch to trunk? http://issues.apache.org/bugzilla/attachment.cgi?id=18956 Andrejus Jeremias Maerki
RE: Question on protected Logger member in some classes
If anyone else can do that in the meantime, that would be great. There are other patches also waiting to be processed. Probably you are the only man who could do that. There were no responses for last 4 hours. Hopefully tomorrow. Andrejus
