Re: [VOTE] Merge Temp_PDFLinearization to trunk

2015-02-18 Thread Luis Bernardo


Thanks. Looks very good.

+1

On 2/16/15 12:23 PM, Simon Steiner wrote:


Hi,

I updated the branch to fix issue.

Thanks

*From:*Luis Bernardo [mailto:lmpmberna...@gmail.com]
*Sent:* 15 February 2015 14:46
*To:* fop-dev@xmlgraphics.apache.org
*Subject:* Re: [VOTE] Merge Temp_PDFLinearization to trunk


Good work Simon. It seems to work in general but I got an NPE:

java.lang.NullPointerException
at java.util.LinkedList.addAll(LinkedList.java:406)
at java.util.LinkedList.addAll(LinkedList.java:385)
at 
org.apache.fop.pdf.PDFLinearization.outputPages(PDFLinearization.java:246)
at 
org.apache.fop.render.pdf.PDFContentGenerator.flushPDFDoc(PDFContentGenerator.java:153)
at 
org.apache.fop.render.pdf.PDFPainter.flushPDFDoc(PDFPainter.java:237)

at org.apache.fop.render.pdf.PDFPainter.drawImage(PDFPainter.java:231)
at 
org.apache.fop.render.intermediate.IFRenderer.renderForeignObject(IFRenderer.java:1308)
at 
org.apache.fop.render.AbstractRenderer.renderInlineViewport(AbstractRenderer.java:861)
at 
org.apache.fop.render.AbstractPathOrientedRenderer.renderInlineViewport(AbstractPathOrientedRenderer.java:832)
at 
org.apache.fop.render.intermediate.IFRenderer.renderInlineViewport(IFRenderer.java:862)
at 
org.apache.fop.render.AbstractRenderer.renderInlineArea(AbstractRenderer.java:714)

..

with:

examples/fo/advanced/giro.fo

I suggest we get this working with all fo files in the examples 
directory before we merge this to trunk.


On 2/10/15 11:54 AM, Simon Steiner wrote:

Hi,

Vote to merge PDF Linearization branch to trunk.

Linearization is helpful to allow viewing of a pdf over a slow
connection.

Feature will be disabled by default, can be enabled with

fop version=1.0

  renderers

renderer mime=application/pdf

linearizationtrue/linearization

/renderer

  /renderers

/fop

The vote will last 5 working days, ending next Tuesday.

https://issues.apache.org/jira/browse/FOP-2445


https://svn.apache.org/repos/asf/xmlgraphics/fop/branches/Temp_PDFLinearization

Here is my vote: +1

Thanks





RE: [VOTE] Merge Temp_PDFLinearization to trunk

2015-02-16 Thread Simon Steiner
Hi,

 

I updated the branch to fix issue.

 

Thanks

 

From: Luis Bernardo [mailto:lmpmberna...@gmail.com] 
Sent: 15 February 2015 14:46
To: fop-dev@xmlgraphics.apache.org
Subject: Re: [VOTE] Merge Temp_PDFLinearization to trunk

 


Good work Simon. It seems to work in general but I got an NPE:

java.lang.NullPointerException
at java.util.LinkedList.addAll(LinkedList.java:406)
at java.util.LinkedList.addAll(LinkedList.java:385)
at
org.apache.fop.pdf.PDFLinearization.outputPages(PDFLinearization.java:246)
at
org.apache.fop.render.pdf.PDFContentGenerator.flushPDFDoc(PDFContentGenerato
r.java:153)
at org.apache.fop.render.pdf.PDFPainter.flushPDFDoc(PDFPainter.java:237)
at org.apache.fop.render.pdf.PDFPainter.drawImage(PDFPainter.java:231)
at
org.apache.fop.render.intermediate.IFRenderer.renderForeignObject(IFRenderer
.java:1308)
at
org.apache.fop.render.AbstractRenderer.renderInlineViewport(AbstractRenderer
.java:861)
at
org.apache.fop.render.AbstractPathOrientedRenderer.renderInlineViewport(Abst
ractPathOrientedRenderer.java:832)
at
org.apache.fop.render.intermediate.IFRenderer.renderInlineViewport(IFRendere
r.java:862)
at
org.apache.fop.render.AbstractRenderer.renderInlineArea(AbstractRenderer.jav
a:714)
..

with:

examples/fo/advanced/giro.fo

I suggest we get this working with all fo files in the examples directory
before we merge this to trunk.

On 2/10/15 11:54 AM, Simon Steiner wrote:

Hi,

 

Vote to merge PDF Linearization branch to trunk.

Linearization is helpful to allow viewing of a pdf over a slow connection.

 

Feature will be disabled by default, can be enabled with

 

fop version=1.0

  renderers

renderer mime=application/pdf

  linearizationtrue/linearization

/renderer

  /renderers

/fop

 

The vote will last 5 working days, ending next Tuesday.

 

https://issues.apache.org/jira/browse/FOP-2445

https://svn.apache.org/repos/asf/xmlgraphics/fop/branches/Temp_PDFLinearizat
ion

 

Here is my vote: +1

 

Thanks

 



Re: [VOTE] Merge Temp_PDFLinearization to trunk

2015-02-15 Thread Luis Bernardo


Good work Simon. It seems to work in general but I got an NPE:

java.lang.NullPointerException
at java.util.LinkedList.addAll(LinkedList.java:406)
at java.util.LinkedList.addAll(LinkedList.java:385)
at 
org.apache.fop.pdf.PDFLinearization.outputPages(PDFLinearization.java:246)
at 
org.apache.fop.render.pdf.PDFContentGenerator.flushPDFDoc(PDFContentGenerator.java:153)
at 
org.apache.fop.render.pdf.PDFPainter.flushPDFDoc(PDFPainter.java:237)

at org.apache.fop.render.pdf.PDFPainter.drawImage(PDFPainter.java:231)
at 
org.apache.fop.render.intermediate.IFRenderer.renderForeignObject(IFRenderer.java:1308)
at 
org.apache.fop.render.AbstractRenderer.renderInlineViewport(AbstractRenderer.java:861)
at 
org.apache.fop.render.AbstractPathOrientedRenderer.renderInlineViewport(AbstractPathOrientedRenderer.java:832)
at 
org.apache.fop.render.intermediate.IFRenderer.renderInlineViewport(IFRenderer.java:862)
at 
org.apache.fop.render.AbstractRenderer.renderInlineArea(AbstractRenderer.java:714)

..

with:

examples/fo/advanced/giro.fo

I suggest we get this working with all fo files in the examples 
directory before we merge this to trunk.


On 2/10/15 11:54 AM, Simon Steiner wrote:


Hi,

Vote to merge PDF Linearization branch to trunk.

Linearization is helpful to allow viewing of a pdf over a slow connection.

Feature will be disabled by default, can be enabled with

fop version=1.0

  renderers

renderer mime=application/pdf

linearizationtrue/linearization

/renderer

  /renderers

/fop

The vote will last 5 working days, ending next Tuesday.

https://issues.apache.org/jira/browse/FOP-2445

https://svn.apache.org/repos/asf/xmlgraphics/fop/branches/Temp_PDFLinearization

Here is my vote: +1

Thanks





Re: [VOTE] Merge Temp_PDFLinearization to trunk

2015-02-10 Thread Glenn Adams
Are new junit tests included for this new functionality?

On Tue, Feb 10, 2015 at 3:54 AM, Simon Steiner simonsteiner1...@gmail.com
wrote:

 Hi,



 Vote to merge PDF Linearization branch to trunk.

 Linearization is helpful to allow viewing of a pdf over a slow connection.



 Feature will be disabled by default, can be enabled with



 fop version=1.0

   renderers

 renderer mime=application/pdf

   linearizationtrue/linearization

 /renderer

   /renderers

 /fop



 The vote will last 5 working days, ending next Tuesday.



 https://issues.apache.org/jira/browse/FOP-2445


 https://svn.apache.org/repos/asf/xmlgraphics/fop/branches/Temp_PDFLinearization



 Here is my vote: +1



 Thanks



Re: [VOTE] Merge Temp_PDFLinearization to trunk

2015-02-10 Thread Clay Leeds
D'oh! Thanks!

Cheers!

Clay

--

My religion is simple. My religion is kindness.
- HH The Dalai Lama of Tibet

 On Feb 10, 2015, at 6:04 AM, Chris Bowditch bowditch_ch...@hotmail.com 
 wrote:
 
 Hi Clay,
 
 Only votes affecting all projects must be held on general, e.g. new 
 committers to give the whole PMC the opportunity to vote. Merging a branch in 
 FOP is very FOP specific, so its fine to hold the vote on fop-dev@
 
 Thanks
 
 Chris
 
 On 10/02/2015 13:34, Clay Leeds wrote:
 D'oh! VOTEs must be on general@, so please everyone reply to general@ with 
 your VOTE so it will count...
 
 Here's my +1... Great work Simon!
 
 Web Maestro Clay
 
 On Feb 10, 2015, at 2:54 AM, Simon Steiner simonsteiner1...@gmail.com 
 wrote:
 
 Hi,
  Vote to merge PDF Linearization branch to trunk.
 Linearization is helpful to allow viewing of a pdf over a slow connection.
  Feature will be disabled by default, can be enabled with
  fop version=1.0
   renderers
 renderer mime=application/pdf
   linearizationtrue/linearization
 /renderer
   /renderers
 /fop
  The vote will last 5 working days, ending next Tuesday.
  https://issues.apache.org/jira/browse/FOP-2445 
 https://issues.apache.org/jira/browse/FOP-2445
 https://svn.apache.org/repos/asf/xmlgraphics/fop/branches/Temp_PDFLinearization
  
 https://svn.apache.org/repos/asf/xmlgraphics/fop/branches/Temp_PDFLinearization
  Here is my vote: +1
  Thanks
 


Re: [VOTE] Merge Temp_PDFLinearization to trunk

2015-02-10 Thread Chris Bowditch

+1

Thanks

Chris

On 10/02/2015 10:54, Simon Steiner wrote:


Hi,

Vote to merge PDF Linearization branch to trunk.

Linearization is helpful to allow viewing of a pdf over a slow connection.

Feature will be disabled by default, can be enabled with

fop version=1.0

  renderers

renderer mime=application/pdf

linearizationtrue/linearization

/renderer

  /renderers

/fop

The vote will last 5 working days, ending next Tuesday.

https://issues.apache.org/jira/browse/FOP-2445

https://svn.apache.org/repos/asf/xmlgraphics/fop/branches/Temp_PDFLinearization

Here is my vote: +1

Thanks





Re: [VOTE] Merge Temp_PDFLinearization to trunk

2015-02-10 Thread Clay Leeds
+1 from me... Great work Simon!

 On Feb 10, 2015, at 2:54 AM, Simon Steiner simonsteiner1...@gmail.com wrote:
 
 Hi,
  
 Vote to merge PDF Linearization branch to trunk.
 Linearization is helpful to allow viewing of a pdf over a slow connection.
  
 Feature will be disabled by default, can be enabled with
  
 fop version=1.0
   renderers
 renderer mime=application/pdf
   linearizationtrue/linearization
 /renderer
   /renderers
 /fop
  
 The vote will last 5 working days, ending next Tuesday.
  
 https://issues.apache.org/jira/browse/FOP-2445 
 https://issues.apache.org/jira/browse/FOP-2445
 https://svn.apache.org/repos/asf/xmlgraphics/fop/branches/Temp_PDFLinearization
  
 https://svn.apache.org/repos/asf/xmlgraphics/fop/branches/Temp_PDFLinearization
  
 Here is my vote: +1
  
 Thanks



Re: [VOTE] Merge Temp_PDFLinearization to trunk

2015-02-10 Thread Clay Leeds
D'oh! VOTEs must be on general@, so please everyone reply to general@ with your 
VOTE so it will count...

Here's my +1... Great work Simon!

Web Maestro Clay

 On Feb 10, 2015, at 2:54 AM, Simon Steiner simonsteiner1...@gmail.com wrote:
 
 Hi,
  
 Vote to merge PDF Linearization branch to trunk.
 Linearization is helpful to allow viewing of a pdf over a slow connection.
  
 Feature will be disabled by default, can be enabled with
  
 fop version=1.0
   renderers
 renderer mime=application/pdf
   linearizationtrue/linearization
 /renderer
   /renderers
 /fop
  
 The vote will last 5 working days, ending next Tuesday.
  
 https://issues.apache.org/jira/browse/FOP-2445 
 https://issues.apache.org/jira/browse/FOP-2445
 https://svn.apache.org/repos/asf/xmlgraphics/fop/branches/Temp_PDFLinearization
  
 https://svn.apache.org/repos/asf/xmlgraphics/fop/branches/Temp_PDFLinearization
  
 Here is my vote: +1
  
 Thanks



RE: [VOTE] Merge Temp_PDFLinearization to trunk

2015-02-10 Thread Simon Steiner
Hi,

 

The branch includes PDFLinearizationTestCase.java

 

Thanks

 

From: Glenn Adams [mailto:gl...@skynav.com] 
Sent: 10 February 2015 15:21
To: FOP Developers
Subject: Re: [VOTE] Merge Temp_PDFLinearization to trunk

 

Are new junit tests included for this new functionality?

 

On Tue, Feb 10, 2015 at 3:54 AM, Simon Steiner simonsteiner1...@gmail.com 
mailto:simonsteiner1...@gmail.com  wrote:

Hi,

 

Vote to merge PDF Linearization branch to trunk.

Linearization is helpful to allow viewing of a pdf over a slow connection.

 

Feature will be disabled by default, can be enabled with

 

fop version=1.0

  renderers

renderer mime=application/pdf

  linearizationtrue/linearization

/renderer

  /renderers

/fop

 

The vote will last 5 working days, ending next Tuesday.

 

https://issues.apache.org/jira/browse/FOP-2445

https://svn.apache.org/repos/asf/xmlgraphics/fop/branches/Temp_PDFLinearization

 

Here is my vote: +1

 

Thanks

 



Re: [VOTE] Merge Temp_PDFLinearization to trunk

2015-02-10 Thread Glenn Adams
ok, if you think it adequately tests the new functionality, then +1

On Tue, Feb 10, 2015 at 3:53 PM, Simon Steiner simonsteiner1...@gmail.com
wrote:

 Hi,



 The branch includes PDFLinearizationTestCase.java



 Thanks



 *From:* Glenn Adams [mailto:gl...@skynav.com]
 *Sent:* 10 February 2015 15:21
 *To:* FOP Developers
 *Subject:* Re: [VOTE] Merge Temp_PDFLinearization to trunk



 Are new junit tests included for this new functionality?



 On Tue, Feb 10, 2015 at 3:54 AM, Simon Steiner simonsteiner1...@gmail.com
 wrote:

 Hi,



 Vote to merge PDF Linearization branch to trunk.

 Linearization is helpful to allow viewing of a pdf over a slow connection.



 Feature will be disabled by default, can be enabled with



 fop version=1.0

   renderers

 renderer mime=application/pdf

   linearizationtrue/linearization

 /renderer

   /renderers

 /fop



 The vote will last 5 working days, ending next Tuesday.



 https://issues.apache.org/jira/browse/FOP-2445


 https://svn.apache.org/repos/asf/xmlgraphics/fop/branches/Temp_PDFLinearization



 Here is my vote: +1



 Thanks





Re: [VOTE] Merge Temp_PDFLinearization to trunk

2015-02-10 Thread Chris Bowditch

Hi Clay,

Only votes affecting all projects must be held on general, e.g. new 
committers to give the whole PMC the opportunity to vote. Merging a 
branch in FOP is very FOP specific, so its fine to hold the vote on fop-dev@


Thanks

Chris

On 10/02/2015 13:34, Clay Leeds wrote:

D'oh! VOTEs must be on general@, so please everyone reply to general@ with your 
VOTE so it will count...

Here's my +1... Great work Simon!

Web Maestro Clay


On Feb 10, 2015, at 2:54 AM, Simon Steiner simonsteiner1...@gmail.com wrote:

Hi,
  
Vote to merge PDF Linearization branch to trunk.

Linearization is helpful to allow viewing of a pdf over a slow connection.
  
Feature will be disabled by default, can be enabled with
  
fop version=1.0

   renderers
 renderer mime=application/pdf
   linearizationtrue/linearization
 /renderer
   /renderers
/fop
  
The vote will last 5 working days, ending next Tuesday.
  
https://issues.apache.org/jira/browse/FOP-2445 https://issues.apache.org/jira/browse/FOP-2445

https://svn.apache.org/repos/asf/xmlgraphics/fop/branches/Temp_PDFLinearization 
https://svn.apache.org/repos/asf/xmlgraphics/fop/branches/Temp_PDFLinearization
  
Here is my vote: +1
  
Thanks