Re: FindBugs exclusion policy proposal

2011-03-04 Thread Chris Bowditch
On 03/03/2011 17:30, Glenn Adams wrote: Hi Glenn, On Thu, Mar 3, 2011 at 5:58 AM, Chris Bowditch bowditch_ch...@hotmail.com mailto:bowditch_ch...@hotmail.com wrote: Please send me a short bio and I will add you to the team page. Chris, per your request, an abridged bio follows: Dr.

Re: FindBugs exclusion policy proposal

2011-03-04 Thread Glenn Adams
thanks On Fri, Mar 4, 2011 at 2:27 AM, Chris Bowditch bowditch_ch...@hotmail.comwrote: On 03/03/2011 17:30, Glenn Adams wrote: Hi Glenn, On Thu, Mar 3, 2011 at 5:58 AM, Chris Bowditch bowditch_ch...@hotmail.com mailto:bowditch_ch...@hotmail.com wrote: Please send me a short bio and

Re: FindBugs exclusion policy proposal

2011-03-03 Thread Vincent Hennebert
On 02/03/11 22:44, Glenn Adams wrote: My apologies for mixing the FB discussion and the commitership issue, which are indeed separate. snip/ Now, regarding commitership, I must say that if I were already a committer, I would probably have already fixed all the current FB exclusions or

Re: FindBugs exclusion policy proposal

2011-03-03 Thread Chris Bowditch
On 02/03/2011 22:44, Glenn Adams wrote: Hi Glenn, snip/ Now, regarding commitership, I must say that if I were already a committer, I would probably have already fixed all the current FB exclusions or documented the chaff as acceptable. However, having to go through other committers to fix

Re: FindBugs exclusion policy proposal

2011-03-03 Thread Glenn Adams
Vincent, you can be sure that I don't like pushing any more than you like hearing it. At the same time, I am dissatisfied with the delays in taking action, and I believe it is an impediment to my ability to contribute. And it is becoming an impediment to my willingness to contribute as well. I

Re: FindBugs exclusion policy proposal

2011-03-03 Thread Glenn Adams
On Thu, Mar 3, 2011 at 5:58 AM, Chris Bowditch bowditch_ch...@hotmail.comwrote: Please send me a short bio and I will add you to the team page. Chris, per your request, an abridged bio follows: Dr. Glenn Adams is an independent consultant with 45+ years of professional software design and

Re: FindBugs exclusion policy proposal

2011-03-02 Thread Andreas Delmelle
snip / Just to be clear: my main issue was with maintaining the auto-exclusion policy in the longer term. I do not question the past decisions, nor did I intend to point fingers (even if only implicitly). If I enervated anyone by bringing this up again, my apologies. The more general context

Re: FindBugs exclusion policy proposal

2011-03-02 Thread Glenn Adams
My apologies for mixing the FB discussion and the commitership issue, which are indeed separate. Of course, I have never said FB is a magic wand, etc., and indeed no such tool is. One makes use of these tools as helpers, and not as determiners. Is the trouble of using FB regularly worth it? I

Re: FindBugs exclusion policy proposal

2011-02-28 Thread Benson Margulies
From the sidelines, Apache projects are encouraged by the norms of the Foundation to actively recruit new committers and to recognize community-positive effort with committer status. Apache projects are, at the same time, given a very wide latitude by the Foundation in making decisions. In my

Re: FindBugs exclusion policy proposal

2011-02-27 Thread J.Pietschmann
On 27.02.2011 02:46, Glenn Adams wrote: My expectation (not hope) was that once we eliminated the pre-existing findbugs, that new commits would not add new issues. Otherwise, it is a pointless exercise. My conclusion is that since findbugs does indeed identify some real and potential bugs, that

Re: FindBugs exclusion policy proposal

2011-02-27 Thread Glenn Adams
On Sun, Feb 27, 2011 at 4:18 PM, J.Pietschmann j3322...@yahoo.de wrote: However, saying all of the above, the largest barrier I see to fixing bugs in FOP and improving its quality is the reticence of the clique of FOP committers to accept new committers. Uh oh. As a PMC member I'm

Re: FindBugs exclusion policy proposal

2011-02-26 Thread Jeremias Maerki
No rationale, just an opinion: FindBugs is a great tool for pointing to potential problems. But the results are not black and white. Checkstyle is more black and white but also not completely. Having no FindBug error doesn't mean the code works and having a FindBug error doesn't mean there is a

Re: FindBugs exclusion policy proposal

2011-02-26 Thread Glenn Adams
Establishing a zero-FindBugs policy at build level: absolutely not. So you offer no rationale or reason for such an opinion? Or your only reason for this is that FindBugs is not perfect? Or because you find it too troublesome to type ant findbugs and look at the results? Shocking. G. On

Re: FindBugs exclusion policy proposal

2011-02-26 Thread J.Pietschmann
On 26.02.2011 15:05, Glenn Adams wrote: Establishing a zero-FindBugs policy at build level: absolutely not. So you offer no rationale or reason for such an opinion? Or your only reason for this is that FindBugs is not perfect? Or because you find it too troublesome to type ant findbugs and

Re: FindBugs exclusion policy proposal

2011-02-26 Thread Glenn Adams
On Sat, Feb 26, 2011 at 2:14 PM, J.Pietschmann j3322...@yahoo.de wrote: On 26.02.2011 15:05, Glenn Adams wrote: Establishing a zero-FindBugs policy at build level: absolutely not. So you offer no rationale or reason for such an opinion? Or your only reason for this is that FindBugs is

Re: FindBugs exclusion policy proposal

2011-02-25 Thread Jeremias Maerki
Possibly a vote to establish such a policy falling through. Just a hunch. On 25.02.2011 08:09:11 Glenn Adams wrote: Well then, let's make it a policy. What's preventing that? On Thu, Feb 24, 2011 at 11:07 PM, Simon Pepping spepp...@leverkruid.euwrote: As before, I will generally not fix

Re: FindBugs exclusion policy proposal

2011-02-25 Thread Glenn Adams
Did I miss seeing such a vote? Could you give me an approximate date when it occurred so I can check the archives for background? Even if it failed to obtain consensus in the past, doesn't mean it might not be accepted now. G. On Fri, Feb 25, 2011 at 4:32 AM, Jeremias Maerki

Re: FindBugs exclusion policy proposal

2011-02-25 Thread Jeremias Maerki
It hasn't occurred, yet, but I expect one to happen if we were to install a new policy. I'm just predicting a possible outcome. ;-) On 25.02.2011 16:57:25 Glenn Adams wrote: Did I miss seeing such a vote? Could you give me an approximate date when it occurred so I can check the archives for

Re: FindBugs exclusion policy proposal

2011-02-25 Thread Glenn Adams
ah, in that case, I wonder who would oppose a policy to use checkstyle and findbugs prior to commits in order to maintain a zero warnings state? and if opposed, then a rationale for that position? /g On Friday, February 25, 2011, Jeremias Maerki d...@jeremias-maerki.ch wrote: It hasn't

Re: FindBugs exclusion policy proposal (was: Re: junit tests in nightly builds etc.)

2011-02-24 Thread Glenn Adams
I think the existing exclusions should be left in trunk, and that no new ones should be permitted in (or should be fixed immediately). If you do as you suggest below, then the list of findbugs errors will just continue to grow because nobody will pay attention to them. We are at a known, stable

Re: FindBugs exclusion policy proposal

2011-02-24 Thread Simon Pepping
As before, I will generally not fix findbugs errors or warnings in contributions by other people. I will fix findbugs errors or warnings in code that I write, or code changes that I make. Note that the use of the findbugs code analysis tool is not a policy of the FOP project, and that

Re: FindBugs exclusion policy proposal

2011-02-24 Thread Glenn Adams
Well then, let's make it a policy. What's preventing that? On Thu, Feb 24, 2011 at 11:07 PM, Simon Pepping spepp...@leverkruid.euwrote: As before, I will generally not fix findbugs errors or warnings in contributions by other people. I will fix findbugs errors or warnings in code that I