Re: Remove Useless Comments

2007-07-18 Thread Vincent Hennebert
Hi Andreas, Andreas L Delmelle a écrit : On Jul 14, 2007, at 15:59, Vincent Hennebert wrote: Vincent Andreas L Delmelle a écrit : Tested locally, and is OK here. If you'd like, I can run a sanity diff later tonight, and commit the changes sometime tomorrow. Thanks, Andreas. We should

Re: Remove Useless Comments

2007-07-17 Thread Andreas L Delmelle
On Jul 14, 2007, at 15:59, Vincent Hennebert wrote: Vincent Andreas L Delmelle a écrit : Tested locally, and is OK here. If you'd like, I can run a sanity diff later tonight, and commit the changes sometime tomorrow. Thanks, Andreas. We should perhaps just wait a couple of days, just to

Re: Remove Useless Comments

2007-07-16 Thread Andreas L Delmelle
On Jul 15, 2007, at 14:17, Andreas L Delmelle wrote: On Jul 14, 2007, at 21:22, Andreas L Delmelle wrote: On Jul 14, 2007, at 15:59, Vincent Hennebert wrote: snip / Thanks, Andreas. We should perhaps just wait a couple of days, just to be sure everybody's ok with that? Indeed, let's

Re: Remove Useless Comments

2007-07-16 Thread J.Pietschmann
Andreas L Delmelle wrote: The javadocs build with only one small warning concerning @todo tags somewheres (which I don't take to be a major issue) The @todo is a custom tag, which are available with Java 1.4. I thought I added a definition for this to the javadoc task in build.xml. In

Re: Remove Useless Comments

2007-07-15 Thread Andreas L Delmelle
On Jul 14, 2007, at 21:22, Andreas L Delmelle wrote: On Jul 14, 2007, at 15:59, Vincent Hennebert wrote: snip / Thanks, Andreas. We should perhaps just wait a couple of days, just to be sure everybody's ok with that? Indeed, let's give everyone a chance to react before committing. FWIW:

Re: Remove Useless Comments

2007-07-14 Thread Vincent Hennebert
J.Pietschmann a écrit : Jeremias Maerki wrote: Yes, inheritDoc would be the right way, as long as we're on Java 1.4.2 and later (feature not available in 1.3, severly buggy in 1.4.0/1.4.1. I would have switched a long time ago if we weren't still on 1.3. I think of JavaDoc as a sort of

Re: Remove Useless Comments

2007-07-14 Thread Andreas L Delmelle
On Jul 14, 2007, at 13:27, Vincent Hennebert wrote: J.Pietschmann a écrit : Jeremias Maerki wrote: Yes, inheritDoc would be the right way, as long as we're on Java 1.4.2 and later (feature not available in 1.3, severly buggy in 1.4.0/1.4.1. I would have switched a long time ago if we

Re: Remove Useless Comments

2007-07-14 Thread Vincent Hennebert
Andreas L Delmelle a écrit : On Jul 14, 2007, at 13:27, Vincent Hennebert wrote: J.Pietschmann a écrit : snip/ I think of JavaDoc as a sort of compile time feature. I don't think there's still a reason to generate the JavaDocs with a JDK version older than 1.5. It's the byte code which should

Re: Remove Useless Comments

2007-07-14 Thread Andreas L Delmelle
On Jul 14, 2007, at 15:59, Vincent Hennebert wrote: Andreas L Delmelle a écrit : snip / A script would not even be needed. An editor like jEdit will let you SR every @see with an @inheritDoc for all .java files in the src/java/org/apache/fop directory and subdirectories... Tested locally,

Re: Remove Useless Comments

2007-07-13 Thread Max Berger
Dear Fop-devs, as always, I have no say in this, but what I usually do is to use /** [EMAIL PROTECTED] */ This works really well, if the method inherits from a class / interface which is also present in the same codebase: Checkstyle is happy, and so is JavaDoc. Also, JavaDoc gives a warning if

Re: Remove Useless Comments

2007-07-13 Thread Jeremias Maerki
Yes, inheritDoc would be the right way, as long as we're on Java 1.4.2 and later (feature not available in 1.3, severly buggy in 1.4.0/1.4.1. I would have switched a long time ago if we weren't still on 1.3. On 13.07.2007 15:49:58 Max Berger wrote: Dear Fop-devs, as always, I have no say in

Re: Remove Useless Comments

2007-07-13 Thread J.Pietschmann
Jeremias Maerki wrote: Yes, inheritDoc would be the right way, as long as we're on Java 1.4.2 and later (feature not available in 1.3, severly buggy in 1.4.0/1.4.1. I would have switched a long time ago if we weren't still on 1.3. I think of JavaDoc as a sort of compile time feature. I don't