Re: Reverting changes in AFP Renderer

2008-02-27 Thread Adrian Cumiskey
Reply below.. Jeremias Maerki wrote: I'm not sure I follow you. Do you mean that you'd always maintain the transformation stack in the renderer? That's certainly something that needs to be done in a uniform way. Yes, a base renderer/painter could maintain both the transformation stack and

Re: Reverting changes in AFP Renderer

2008-02-26 Thread Jeremias Maerki
Interesting. I just noticed that the break-out mechanism hasn't been implemented for the AFP renderer and therefore fixed positioned block-containers are not even supported in 0.94. Hmm. I guess I will skip that then. I'm only hacking together the same feature level as in 0.94 anyway. It turns

Re: Reverting changes in AFP Renderer

2008-02-26 Thread Adrian Cumiskey
Hi Jeremias, Yes I noticed this too in the AFP renderer and I am looking at trying to reuse more of AbstractPathOrientedRenderer and bring it more into line with the state/breakout approach of the PDF/PS renderers in the Temp_AFPAffineTransform branch. Also looking to start using stateful

Re: Reverting changes in AFP Renderer

2008-02-26 Thread Adrian Cumiskey
Generally speaking (not just AFP), at the moment the AbstractPathOrientedRenderer and its parents dumbly pass coordinates down to their implementing renderer and rely upon the implementing renderer to workout the transformation using lots of pts2units()/mpts2units() method calls. I think it

Re: Reverting changes in AFP Renderer

2008-02-25 Thread Adrian Cumiskey
Hi Jeremias, I started to do this but if you prefer then be all means go ahead and revert yourself. The approach I took was to take a trunk checkout and then apply svn merge -r603590:603589 . This should give you all the changes between commits (as 603589 works ok, but 603590 is broken) and