Re: cvs commit: xml-fop/src/java/org/apache/fop/area/inline InlineParent.java

2005-03-17 Thread Simon Pepping
On Thu, Mar 17, 2005 at 08:48:03AM +0100, Finn Bock wrote:
> [EMAIL PROTECTED] wrote:
> 
> >gmazza  2005/03/16 15:18:43
> >
> >  Modified:src/java/org/apache/fop/layoutmgr LineLayoutManager.java
> >StaticContentLayoutManager.java
> >AbstractLayoutManager.java
> >PageSequenceLayoutManager.java
> >BlockLayoutManager.java LeafNodeLayoutManager.java
> >LayoutManager.java BlockContainerLayoutManager.java
> >InlineStackingLayoutManager.java
> >BlockStackingLayoutManager.java
> >FlowLayoutManager.java ContentLayoutManager.java
> >TextLayoutManager.java LeaderLayoutManager.java
> >   src/java/org/apache/fop/layoutmgr/table Cell.java
> >Caption.java Body.java TableLayoutManager.java
> >Row.java TableAndCaptionLayoutManager.java
> >   src/java/org/apache/fop/area LineArea.java Area.java
> >   src/java/org/apache/fop/layoutmgr/list
> >ListItemLayoutManager.java Item.java
> >ListBlockLayoutManager.java
> >   src/java/org/apache/fop/area/inline InlineParent.java
> >  Log:
> >  Changed from addChild(Area) to clearer addChildArea(Area).
> 
> Yes, that looks like a good example of the kind of change which Jeremias 
> kindly asked you not to do right at this moment.

I second that. Glen, other team members than you expect that Jeremias
is about to make important improvements to these LMs, and agree with
Jeremias that your working on the same piece of code is going to
bother his work. Renaming, moving things around and refactoring is the
worst thing you can do at such a time. Code repositories are a
powerful tool, but they do not take away the problems that arise when
two people are working on the same piece of code. Please, leave this
area to Jeremias for the weeks to come.

Regards, Simon

-- 
Simon Pepping
home page: http://www.leverkruid.nl



Re: cvs commit: xml-fop/src/java/org/apache/fop/area/inline InlineParent.java

2005-03-16 Thread Finn Bock
[EMAIL PROTECTED] wrote:
gmazza  2005/03/16 15:18:43
  Modified:src/java/org/apache/fop/layoutmgr LineLayoutManager.java
StaticContentLayoutManager.java
AbstractLayoutManager.java
PageSequenceLayoutManager.java
BlockLayoutManager.java LeafNodeLayoutManager.java
LayoutManager.java BlockContainerLayoutManager.java
InlineStackingLayoutManager.java
BlockStackingLayoutManager.java
FlowLayoutManager.java ContentLayoutManager.java
TextLayoutManager.java LeaderLayoutManager.java
   src/java/org/apache/fop/layoutmgr/table Cell.java
Caption.java Body.java TableLayoutManager.java
Row.java TableAndCaptionLayoutManager.java
   src/java/org/apache/fop/area LineArea.java Area.java
   src/java/org/apache/fop/layoutmgr/list
ListItemLayoutManager.java Item.java
ListBlockLayoutManager.java
   src/java/org/apache/fop/area/inline InlineParent.java
  Log:
  Changed from addChild(Area) to clearer addChildArea(Area).
Yes, that looks like a good example of the kind of change which Jeremias 
kindly asked you not to do right at this moment.

sigh.
regards,
finn