Re: cvs commit: xml-fop/src/java/org/apache/fop/render AbstractRenderer.java

2005-03-23 Thread Glen Mazza
--- Jeremias Maerki <[EMAIL PROTECTED]> wrote: > Over all, this sounds ok. There's one point, though: > the one with the > column balancing. Following XP principles I'd skip Yeah, I like XP [1]... ;) > that because I'm > almost sure that we can't implement column balancing > just by calling a >

Re: cvs commit: xml-fop/src/java/org/apache/fop/render AbstractRenderer.java

2005-03-22 Thread Jeremias Maerki
Over all, this sounds ok. There's one point, though: the one with the column balancing. Following XP principles I'd skip that because I'm almost sure that we can't implement column balancing just by calling a balanceColumns() method like your foresee. Don't try to do too many optimizations too soon

Re: cvs commit: xml-fop/src/java/org/apache/fop/render AbstractRenderer.java

2005-03-22 Thread Glen Mazza
--- [EMAIL PROTECTED] wrote: > > -private void createSpan(int numCols) { > +/** > + * Creates a new span reference area. > + * @param bodyRegion The region-body to > create the span for > + * @param spanned true if a spanned region > should be created > + */ >