On 17 Dec 2010, at 11:57, spepp...@apache.org wrote:
Hi Simon Very minor nit. Sorry to be so late with this, but I was just reviewing some of last month's commits and ran into this one: > Author: spepping > Date: Fri Dec 17 10:57:18 2010 > New Revision: 1050342 > > URL: http://svn.apache.org/viewvc?rev=1050342&view=rev > Log: > Auxiliary positions do not have an index value; fixing this in > InlineStackingLM.applyChanges, rewrapping positions; fixed bug 49870 > > Added: > > xmlgraphics/fop/trunk/test/layoutengine/standard-testcases/inline_hyphenation_border.xml > (with props) I believe the testcase actually belongs in '...test/layoutengine/hyphenation-testcases', which will only be run if hyphenation support is present. Putting tests that depend on hyphenation under 'standard-testcases' could lead to 'failures' due to hyphenation being inactive (which could send unsuspecting committers on a wild-goose chase). I must admit I have not checked in detail whether the end-result is actually affected by the presence of hyphenation support. If that is so, my remark can be safely ignored. Regards Andreas
