Re: svn commit: r292280 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/apps/FOUserAgent.java

2005-09-28 Thread Andreas L Delmelle

On Sep 28, 2005, at 22:09, Simon Pepping wrote:

Hi Simon,


On Wed, Sep 28, 2005 at 07:37:31PM -, [EMAIL PROTECTED] wrote:


+public void initUserConfig() throws ConfigurationException {
+log.info(Initializing User Agent Configuration);
+Configuration cfgUserAgent = 
userConfig.getChild(userAgent);


Why do you wrap these configuration elements in a userAgent element?


Well, I didn't modify the fop.xconf file myself. The general UA config 
entries were already there, and I just added the page-settings in 
there...



The fact that we let the user agent object handle the configuration,
does not need to be reflected in the configuration file. I would
prefer to see these configuration elements as direct children of the
top level element, or perhaps some of them wrapped in an element like
pagesettings.


No objection from me.
Anyone with other opinions before I make this alteration?

Cheers,

Andreas



Re: svn commit: r292280 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/apps/FOUserAgent.java

2005-09-28 Thread Jeremias Maerki

On 28.09.2005 22:14:29 Andreas L Delmelle wrote:
snip/
  The fact that we let the user agent object handle the configuration,
  does not need to be reflected in the configuration file. I would
  prefer to see these configuration elements as direct children of the
  top level element, or perhaps some of them wrapped in an element like
  pagesettings.
 
 No objection from me.
 Anyone with other opinions before I make this alteration?

No, Simon's suggestion is fine.

Jeremias Maerki



Re: svn commit: r292280 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/apps/FOUserAgent.java

2005-09-28 Thread Andreas L Delmelle

On Sep 28, 2005, at 22:29, Jeremias Maerki wrote:



On 28.09.2005 22:14:29 Andreas L Delmelle wrote:
snip/

The fact that we let the user agent object handle the configuration,
does not need to be reflected in the configuration file. I would
prefer to see these configuration elements as direct children of the
top level element, or perhaps some of them wrapped in an element like
pagesettings.


No objection from me.
Anyone with other opinions before I make this alteration?


No, Simon's suggestion is fine.


Since you were the original author of the fop.xconf file, that's enough 
for me :-)


IOW: Done!

Cheers,

Andreas