Re: svn commit: r556112 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop: fonts/truetype/TTFFile.java util/IntMap.java

2007-07-18 Thread Vincent Hennebert
Hi, Manuel Mall a écrit : On Wednesday 18 July 2007 02:58, Andreas L Delmelle wrote: snip/ Interestingly Java 1.5 has added the Integer.valueOf(int) method with the following comment: Flyweight pattern. That's what I was looking for before replying to Andreas' commit, and I was surprised to

Re: svn commit: r556112 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop: fonts/truetype/TTFFile.java util/IntMap.java

2007-07-18 Thread Peter B. West
Vincent Hennebert wrote: Hi, Manuel Mall a écrit : On Wednesday 18 July 2007 02:58, Andreas L Delmelle wrote: snip/ Interestingly Java 1.5 has added the Integer.valueOf(int) method with the following comment: Flyweight pattern. That's what I was looking for before replying to Andreas'

Re: svn commit: r556112 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop: fonts/truetype/TTFFile.java util/IntMap.java

2007-07-18 Thread Andreas L Delmelle
On Jul 18, 2007, at 14:28, Peter B. West wrote: Hi Peter alt-design always cached _all_ the Integer instances it needed. Another startling new idea. FWIW, I did not presume my idea to be startling or new. Just was a bit bugged by the number of places in the current trunk where

Re: svn commit: r556112 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop: fonts/truetype/TTFFile.java util/IntMap.java

2007-07-17 Thread Andreas L Delmelle
On Jul 16, 2007, at 22:25, J.Pietschmann wrote: Vincent Hennebert wrote: Addition of a general-purpose int-to-int map ... ... This change makes me a bit uneasy. No doubt that this class is clever and efficient and working, but that's something more to maintain. Jakarta Commons Collections

Re: svn commit: r556112 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop: fonts/truetype/TTFFile.java util/IntMap.java

2007-07-17 Thread Manuel Mall
On Wednesday 18 July 2007 02:58, Andreas L Delmelle wrote: On Jul 16, 2007, at 22:25, J.Pietschmann wrote: Vincent Hennebert wrote: Addition of a general-purpose int-to-int map ... ... As to the efficiency: I did some measurements of the difference in processing speed (for 64K

Re: svn commit: r556112 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop: fonts/truetype/TTFFile.java util/IntMap.java

2007-07-16 Thread Vincent Hennebert
Hi Andreas, Author: adelmelle Date: Fri Jul 13 12:21:03 2007 New Revision: 556112 URL: http://svn.apache.org/viewvc?view=revrev=556112 Log: Addition of a general-purpose int-to-int map to replace Integer-to-Integer HashMaps + first usage in TTFFile Added:

Re: svn commit: r556112 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop: fonts/truetype/TTFFile.java util/IntMap.java

2007-07-16 Thread Andreas L Delmelle
On Jul 16, 2007, at 16:38, Vincent Hennebert wrote: Hi This change makes me a bit uneasy. No doubt that this class is clever and efficient and working, but that's something more to maintain. By quickly looking at it I couldn't figure out exactly how it is working, and this is the kind of code

Re: svn commit: r556112 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop: fonts/truetype/TTFFile.java util/IntMap.java

2007-07-16 Thread J.Pietschmann
Vincent Hennebert wrote: Addition of a general-purpose int-to-int map ... ... This change makes me a bit uneasy. No doubt that this class is clever and efficient and working, but that's something more to maintain. Jakarta Commons Collections has all kind of clever implementation. Don't they