Re: svn commit: r805561 [1/2] - in /xmlgraphics/fop/trunk: ./ src/java/org/apache/fop/hyphenation/ src/java/org/apache/fop/tools/anttasks/
Hi Simon, Simon Pepping wrote: On Wed, Aug 19, 2009 at 08:44:03AM +0200, Jeremias Maerki wrote: Uhm, Simon, this change uses tons of Java 1.5 features. The build fails now on Java 1.4. OK if we revert until you've had a chance to revisit? I am surprised. My eclipse project is set to 1.4 compatibility for comiler compliance level, generated .class files compatibility, source compatibility. Which part is not compatible with 1.4? Although the source code is 1.4-compatible, calls are made to methods that were only added in the Java 1.5 release. So a 1.4 JRE won’t find them. Revert it if that is needed to keep trunk compilable. I will not immediately have time to revisit this. Simon Vincent
Re: svn commit: r805561 [1/2] - in /xmlgraphics/fop/trunk: ./ src/java/org/apache/fop/hyphenation/ src/java/org/apache/fop/tools/anttasks/
Uhm, Simon, this change uses tons of Java 1.5 features. The build fails now on Java 1.4. OK if we revert until you've had a chance to revisit? On 18.08.2009 22:05:01 spepping wrote: Author: spepping Date: Tue Aug 18 20:05:01 2009 New Revision: 805561 URL: http://svn.apache.org/viewvc?rev=805561view=rev Log: Prepare for new hyphenation pattern files, which do not have their own classes and instead use the default classes in FOP. Modified the build process to a forked java task, in order to be able to set a larger stack size for the compilation of the large number of classes. Added an ant task to generate a new default classes file, to be used with an update of the Unicode Character Database. Added: xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/SerializeHyphPattern.java (with props) xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/UnicodeClasses.java (with props) xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/classes.xml (with props) Removed: xmlgraphics/fop/trunk/src/java/org/apache/fop/tools/anttasks/SerializeHyphPattern.java Modified: xmlgraphics/fop/trunk/build.properties xmlgraphics/fop/trunk/build.xml xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/PatternParser.java Jeremias Maerki
Re: svn commit: r805561 [1/2] - in /xmlgraphics/fop/trunk: ./ src/java/org/apache/fop/hyphenation/ src/java/org/apache/fop/tools/anttasks/
Hi all, Maybe its time we moved to 1.5 like the rest of the world. Max, Vincent and Andreas, myself and others were all in favour of the switch in June 2008 (see http://www.nabble.com/Switching-to-Java-1.5-td17673100.html). Sun's end of life transition period for 1.4 ended on October 30th, 2008. I personally think we can now safely retroweave to 1.4. Adrian. Jeremias Maerki wrote: Uhm, Simon, this change uses tons of Java 1.5 features. The build fails now on Java 1.4. OK if we revert until you've had a chance to revisit? On 18.08.2009 22:05:01 spepping wrote: Author: spepping Date: Tue Aug 18 20:05:01 2009 New Revision: 805561 URL: http://svn.apache.org/viewvc?rev=805561view=rev Log: Prepare for new hyphenation pattern files, which do not have their own classes and instead use the default classes in FOP. Modified the build process to a forked java task, in order to be able to set a larger stack size for the compilation of the large number of classes. Added an ant task to generate a new default classes file, to be used with an update of the Unicode Character Database. Added: xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/SerializeHyphPattern.java (with props) xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/UnicodeClasses.java (with props) xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/classes.xml (with props) Removed: xmlgraphics/fop/trunk/src/java/org/apache/fop/tools/anttasks/SerializeHyphPattern.java Modified: xmlgraphics/fop/trunk/build.properties xmlgraphics/fop/trunk/build.xml xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/PatternParser.java Jeremias Maerki
Re: svn commit: r805561 [1/2] - in /xmlgraphics/fop/trunk: ./ src/java/org/apache/fop/hyphenation/ src/java/org/apache/fop/tools/anttasks/
Adrian Cumiskey wrote: Hi all, Maybe its time we moved to 1.5 like the rest of the world. Max, Vincent and Andreas, myself and others were all in favour of the switch in June 2008 (see http://www.nabble.com/Switching-to-Java-1.5-td17673100.html). Sun's end of life transition period for 1.4 ended on October 30th, 2008. I personally think we can now safely retroweave to 1.4. +1 Although we don’t even need to discuss that in the context of Simon’s change, IMO. Like the comment says in the build.xml file, the task doesn’t need to be run at every build. So 1.4 compatibility still is available. OTOH, the new UnicodeClasses class has quite a few checkstyle warnings that it would be good if they were fixed. Also, I have concerns about putting the generated classes.xml file inside the src/java directory. I’d rather not mix generated files with manually edited ones. What about a new hyphenation directory in src/codegen? Thanks, Vincent Adrian. Jeremias Maerki wrote: Uhm, Simon, this change uses tons of Java 1.5 features. The build fails now on Java 1.4. OK if we revert until you've had a chance to revisit? On 18.08.2009 22:05:01 spepping wrote: Author: spepping Date: Tue Aug 18 20:05:01 2009 New Revision: 805561 URL: http://svn.apache.org/viewvc?rev=805561view=rev Log: Prepare for new hyphenation pattern files, which do not have their own classes and instead use the default classes in FOP. Modified the build process to a forked java task, in order to be able to set a larger stack size for the compilation of the large number of classes. Added an ant task to generate a new default classes file, to be used with an update of the Unicode Character Database. Added: xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/SerializeHyphPattern.java (with props) xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/UnicodeClasses.java (with props) xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/classes.xml (with props) Removed: xmlgraphics/fop/trunk/src/java/org/apache/fop/tools/anttasks/SerializeHyphPattern.java Modified: xmlgraphics/fop/trunk/build.properties xmlgraphics/fop/trunk/build.xml xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/PatternParser.java Jeremias Maerki
Re: svn commit: r805561 [1/2] - in /xmlgraphics/fop/trunk: ./ src/java/org/apache/fop/hyphenation/ src/java/org/apache/fop/tools/anttasks/
On Wed, Aug 19, 2009 at 08:44:03AM +0200, Jeremias Maerki wrote: Uhm, Simon, this change uses tons of Java 1.5 features. The build fails now on Java 1.4. OK if we revert until you've had a chance to revisit? I am surprised. My eclipse project is set to 1.4 compatibility for comiler compliance level, generated .class files compatibility, source compatibility. Which part is not compatible with 1.4? Revert it if that is needed to keep trunk compilable. I will not immediately have time to revisit this. Simon On 18.08.2009 22:05:01 spepping wrote: Author: spepping Date: Tue Aug 18 20:05:01 2009 New Revision: 805561 URL: http://svn.apache.org/viewvc?rev=805561view=rev Log: Prepare for new hyphenation pattern files, which do not have their own classes and instead use the default classes in FOP. Modified the build process to a forked java task, in order to be able to set a larger stack size for the compilation of the large number of classes. Added an ant task to generate a new default classes file, to be used with an update of the Unicode Character Database. Added: xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/SerializeHyphPattern.java (with props) xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/UnicodeClasses.java (with props) xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/classes.xml (with props) Removed: xmlgraphics/fop/trunk/src/java/org/apache/fop/tools/anttasks/SerializeHyphPattern.java Modified: xmlgraphics/fop/trunk/build.properties xmlgraphics/fop/trunk/build.xml xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/PatternParser.java -- Simon Pepping home page: http://www.leverkruid.eu
Re: svn commit: r805561 [1/2] - in /xmlgraphics/fop/trunk: ./ src/java/org/apache/fop/hyphenation/ src/java/org/apache/fop/tools/anttasks/
On Wed, Aug 19, 2009 at 06:28:25PM +0100, Vincent Hennebert wrote: OTOH, the new UnicodeClasses class has quite a few checkstyle warnings that it would be good if they were fixed. I will try to run that. Also, I have concerns about putting the generated classes.xml file inside the src/java directory. I???d rather not mix generated files with manually edited ones. What about a new hyphenation directory in src/codegen? What about src/codegen/unicode/data, which already has LineBreakPairTable.txt. Simon -- Simon Pepping home page: http://www.leverkruid.eu
