Re: [foreman-dev] Link to redmine issues using prprocessor

2017-04-10 Thread Ewoud Kohl van Wijngaarden
+1 to amending the original text and see how that feels in practice. On Mon, Apr 10, 2017 at 10:38:11AM -0400, Andrew Kofink wrote: > I have made the change to amend the body of the pull request with the links > to the issues, which shouldn't send a new notification/email. This will be > a

Re: [foreman-dev] Link to redmine issues using prprocessor

2017-04-10 Thread Greg Sutcliffe
Will do :) -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Link to redmine issues using prprocessor

2017-04-10 Thread Andrew Kofink
Greg, If you would like to start a discussion for inclusion of MIQ bot, please start a new thread. :) On Mon, Apr 10, 2017 at 7:23 AM, Greg Sutcliffe wrote: > While we're talking about modifying PrProcessor, some of the automatic > and requested task options in the

Re: [foreman-dev] Link to redmine issues using prprocessor

2017-04-10 Thread Andrew Kofink
I have made the change to amend the body of the pull request with the links to the issues, which shouldn't send a new notification/email. This will be a per-repo configuration. If you'd like for a repository to be included in the change, please let me know via email, or comment on the pull request

Re: [foreman-dev] Link to redmine issues using prprocessor

2017-04-10 Thread Greg Sutcliffe
While we're talking about modifying PrProcessor, some of the automatic and requested task options in the MIQ bot are pretty cool - maybe we should steal^W copy those in? :P. I can definitely see uses for add/remove labels, at least. https://github.com/ManageIQ/miq_bot?#automatic-tasks Greg --

Re: [foreman-dev] Link to redmine issues using prprocessor

2017-04-10 Thread Marek Hulán
On pátek 7. dubna 2017 14:35:41 CEST John Mitsch wrote: > The greasmonkey script works great! Really helpful, thanks for sharing. For > those who are wondering (like I was), it requires the greasemonkey browser > plugin: > > https://addons.mozilla.org/en-US/firefox/addon/greasemonkey/ or > >

Re: [foreman-dev] Link to redmine issues using prprocessor

2017-04-07 Thread John Mitsch
The greasmonkey script works great! Really helpful, thanks for sharing. For those who are wondering (like I was), it requires the greasemonkey browser plugin: https://addons.mozilla.org/en-US/firefox/addon/greasemonkey/ or ttps://

Re: [foreman-dev] Link to redmine issues using prprocessor

2017-04-06 Thread Walden Raines
I do it manually although I probably should just write a commit hook to do it. I put it in the message itself because I think it's useful to have there in case anyone is browsing the git log or in case we ever move away from github. Walden On Thu, Apr 6, 2017 at 5:33 PM, Andrew Kofink

Re: [foreman-dev] Link to redmine issues using prprocessor

2017-04-06 Thread John Mitsch
+1 from me :) John Mitsch Red Hat Engineering (860)-967-7285 irc: jomitsch On Thu, Apr 6, 2017 at 3:05 PM, Andrew Kofink wrote: > I find myself copying/pasting issue numbers from GitHub PRs to a redmine > url way too much every day. It takes a bit of time, and it's annoying

[foreman-dev] Link to redmine issues using prprocessor

2017-04-06 Thread Andrew Kofink
I find myself copying/pasting issue numbers from GitHub PRs to a redmine url way too much every day. It takes a bit of time, and it's annoying as well as easy to fix. I've submitted this PR to comment on a newly submitted PR with links to the associated issues in redmine: