Re: Creating a plugin-for-tests (was [foreman-dev] Plugin test failures)

2016-11-08 Thread Stephen Benjamin
- Original Message - > From: "Dominic Cleal" <domi...@cleal.org> > To: foreman-dev@googlegroups.com > Sent: Tuesday, November 8, 2016 5:42:04 AM > Subject: Re: Creating a plugin-for-tests (was [foreman-dev] Plugin test > failures) > > On 0

Re: Creating a plugin-for-tests (was [foreman-dev] Plugin test failures)

2016-11-08 Thread Dominic Cleal
On 07/11/16 15:39, Stephen Benjamin wrote: > The wiki says that public methods will be deprecated and given a chance > to adjust our code in a reasonable time where possible: > > "Foreman will always strive to make no incompatible changes in a minor > release, but be prepared > to make

Re: Creating a plugin-for-tests (was [foreman-dev] Plugin test failures)

2016-11-07 Thread Stephen Benjamin
- Original Message - > From: ssht...@redhat.com > To: "foreman-dev" <foreman-dev@googlegroups.com> > Sent: Sunday, November 6, 2016 3:34:40 AM > Subject: Re: Re: Creating a plugin-for-tests (was [foreman-dev] Plugin test > failures) > > +1 for Da

Re: Re: Creating a plugin-for-tests (was [foreman-dev] Plugin test failures)

2016-11-04 Thread Daniel Lobato Garcia
On 11/03, Greg Sutcliffe wrote: > > > > You should file a bug against Foreman immediately if you see that a > > plugin interface has been broken, so we can ensure the change isn't > > released and a fix can be written. > > > > Fair enough - in this case it's an interface that wasn't tested and a

Re: [foreman-dev] Plugin test failures

2016-10-04 Thread Daniel Lobato
Remove your test db, then try RAILS_ENV=test ruby -I'test' test/unit/foreman/access_permissions_test.rb and you'll see it happening. I think it's just because tests are loaded earlier than permissions from plugins now. On Tue, Oct 4, 2016 at 12:39 PM, Ivan Necas wrote: > So

Re: [foreman-dev] Plugin test failures

2016-10-04 Thread Ivan Necas
So far, I can tell this PR https://github.com/theforeman/foreman/pull/3843 introduced the behaviour as it's green on http://ci.theforeman.org/job/test_plugin_matrix/2059/database=mysql,ruby=2.3,slave=fast/ and red on following commit

Re: [foreman-dev] Plugin test failures

2016-10-03 Thread Ivan Necas
The only think I can tell so far is that I can't reproduce this locally and I have no idea on what might be different from my vs. jenkins environment that causes this to happen. -- Ivan On Mon, Oct 3, 2016 at 10:28 PM, Stephen Benjamin wrote: > Tasks, salt and a bunch of

[foreman-dev] Plugin test failures

2016-10-03 Thread Stephen Benjamin
Tasks, salt and a bunch of plugins are failing tests, has anyone has a chance to look into it? e.g.: http://ci.theforeman.org/job/test_plugin_matrix/2015/#showFailuresLink This most recent failure has me thinking again about the difficulties of being a plugin maintainer for Foreman. Would