Re: [foreman-dev] Re: [POC] Automatic inspection of user-created provisioning templates

2017-10-02 Thread sshtein
Finally I have finished first stage of engine development - now there is a sinatra app that could be added to any rack app (although not tested) and can run as a standalone executable (for now using webrick). Git repo is located here: https://github.com/ShimShtein/detective Key files: -

Re: [foreman-dev] Re: [POC] Automatic inspection of user-created provisioning templates

2017-09-14 Thread Shimon Shtein
Ewoud: About rack endpoint: It should be created for use case 2, where the check is running in "online"-ish mode. I prefer creating it as a microservice for scalability reasons, so I wouldn't want to tie it too tightly with foreman-templates. Besides that, tying it into foreman-templates will

Re: [foreman-dev] Re: [POC] Automatic inspection of user-created provisioning templates

2017-09-14 Thread Ewoud Kohl van Wijngaarden
On Wed, Sep 13, 2017 at 12:05:49PM -0700, ssht...@redhat.com wrote: First attempt to create a design. It's an open discussion, everyone who wants to chime in, please do. The engine: will be deployed as a separate gem. My name suggestion the-detective

Re: [foreman-dev] Re: [POC] Automatic inspection of user-created provisioning templates

2017-09-14 Thread Shimon Shtein
First, I don't think that this service has any secret information that should be kept under authorization/authentication. Even if we assume that some level of auth is indeed needed, the easiest way to implement it would be through Rack middleware. If the service is added to an application with

Re: [foreman-dev] Re: [POC] Automatic inspection of user-created provisioning templates

2017-09-14 Thread Ivan Necas
How would be the authentication/authorization work with this approach? - - Ivan On Wed, Sep 13, 2017 at 9:05 PM, wrote: > > First attempt to create a design. It's an open discussion, everyone who > wants to chime in, please do. > > The engine: will be deployed as a separate

[foreman-dev] Re: [POC] Automatic inspection of user-created provisioning templates

2017-09-13 Thread sshtein
First attempt to create a design. It's an open discussion, everyone who wants to chime in, please do. The engine: will be deployed as a separate gem. My name suggestion the-detective (Sinatra plays a cop). It will wrap the invocation

[foreman-dev] Re: [POC] Automatic inspection of user-created provisioning templates

2017-08-30 Thread sshtein
After a great talk on community demo , here is a follow up with the points that were raised during the discussion: Use cases: 1. Run all cops as part of community templates CI against the whole repository 2. Run all cops against a single