On 06/20, gstei...@redhat.com wrote: > I've started working on replacing flot with patternfly and c3.js. This > change depends on the Webpack PR being merged. > > The implementation includes EcmaScript 2015 and React.js. > > I would be happy to receive comments on my work in the linked PR > <https://github.com/theforeman/foreman/pull/3603>
Awesome! I'll do my best to review it and hopefully learn some flux in the meantime. I was wondering if you've taken a look at https://gerrit.ovirt.org/ovirt-engine-dashboard ? It's another project that uses Patternfly and has a few components already implemented. They're open to moving that kind of stuff to a shared repo, if you'd be willing to collaborate they're on IRC and mailing lists @ https://www.ovirt.org/community/ > > On Monday, May 4, 2015 at 12:13:47 PM UTC+3, Tomer Brisker wrote: > > > > Hello, > > I ran into a bug [1] today that originated from flot.js, the library we > > use for drawing all graphs in foreman. > > I was planning to submit a PR to get it fixed in the library and noticed > > the last commit was over a year ago. > > A bit of further investigation led to a thread on their mailing list [2] > > and an open issue [3] which seem to indicate that the project is indeed > > dead. > > > > While this still works for us right now with minor workarounds, we should > > start looking into finding a replacement library for charts that is > > actively maintained. > > This would require quite a few changes, so I think it won't make it in by > > 1.9, hopefully 1.10 will be a good target release for replacing it. > > If anyone has any comments or suggestions for a replacement (or wants to > > take over maintaining flot.js) feel free to reply. > > > > [1] http://projects.theforeman.org/issues/7533 > > [2] https://groups.google.com/forum/#!topic/flot-graphs/XLNK6eWRUlU > > [3] https://github.com/flot/flot/issues/1430 > > -- > > Have a nice day, > > Tomer Brisker > > > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. -- Daniel Lobato Garcia @dLobatog blog.daniellobato.me daniellobato.me GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30 Keybase: https://keybase.io/elobato -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: PGP signature
