Re: [foreman-dev] Hash rocket syntax

2016-08-24 Thread David Davis
I was thinking about responding to the items in your email but I feel like I’ve put enough time into this discussion already. Just some general thoughts. I think you’re mischaracterizing my argument. I am not arguing that we enable all cops. In fact, in the dynflow case I tried to open a PR with

Re: [foreman-dev] Hash rocket syntax

2016-08-24 Thread David Davis
On Wed, Aug 24, 2016 at 4:49 AM, Marek Hulán wrote: > Few more comments below > > > What do you mean by "Foreman dev"? > > You, me, everyone who contributed to Foreman. > So then your statement about not one foreman dev being a rubocop contributor is incorrect, right? > >

Re: [foreman-dev] Hash rocket syntax

2016-08-24 Thread Ivan Necas
On Wed, Aug 24, 2016 at 10:49 AM, Marek Hulán wrote: > Few more comments below > >> What do you mean by "Foreman dev"? > > You, me, everyone who contributed to Foreman. > >> I’ve contributed to both foreman and >> rubocop several times. Having worked on rubocop with all its

Re: [foreman-dev] Hash rocket syntax

2016-08-24 Thread Marek Hulán
Few more comments below > What do you mean by "Foreman dev"? You, me, everyone who contributed to Foreman. > I’ve contributed to both foreman and > rubocop several times. Having worked on rubocop with all its cops enabled > hasn’t been a deterrent to me even though I don’t necessarily agree

Re: [foreman-dev] Hash rocket syntax

2016-08-23 Thread David Davis
What do you mean by "Foreman dev"? I’ve contributed to both foreman and rubocop several times. Having worked on rubocop with all its cops enabled hasn’t been a deterrent to me even though I don’t necessarily agree with all cops. I’m not disagreeing with you. But I still have nightmares about the

Re: [foreman-dev] Hash rocket syntax

2016-08-23 Thread Marek Hulán
On Tuesday 23 of August 2016 07:47:31 David Davis wrote: > The plugins may not have as many contributors as foreman core but rubocop > has more contributors (279 vs 200 for foreman) and they have pretty much > all cops enabled. It’s only been around for 3 years (vs 7 years for > foreman) so it

Re: [foreman-dev] Hash rocket syntax

2016-08-23 Thread David Davis
The plugins may not have as many contributors as foreman core but rubocop has more contributors (279 vs 200 for foreman) and they have pretty much all cops enabled. It’s only been around for 3 years (vs 7 years for foreman) so it doesn’t seem to be a deterrent to community contributions. I’d

Re: Re: [foreman-dev] Hash rocket syntax

2016-08-19 Thread Daniel Lobato Garcia
On 08/19, Lukas Zapletal wrote: > > As discussed on IRC yesterday there should be consistency and there is an > > option to autofix with rubocop if the style is changed to change existing > > code with less effort. > > TL;DR - Let's keep Rubocop away from rockethash thing. > > What the consistency