Re: [foreman-dev] Nominating additional maintainers in foreman-core

+1 +1 beer time! LZ On Wed, Dec 6, 2017 at 1:40 PM, Tomer Brisker wrote: > Hello, > As many of you may have noticed, foreman-core open PR count has been in the > area of 100-110 for most of the last few months. There are only a few people > with merge access that actively

[foreman-dev] RFC Auto Refresh on ForemanTasks#Tasks Page

Hello, We have the option of toggling auto-refresh on individual tasks, but I often find myself at the foreman_tasks#tasks page intermittently clicking the search button to monitor the state of automated tasks (in my case, usually bats content/proxy tests). I'm proposing a button or an option

Re: [foreman-dev] Nominating additional maintainers in foreman-core

+2 -- Ivan On Wed, 6 Dec 2017 at 16:51, Lukas Zapletal wrote: > +1 +1 beer time! > > LZ > > On Wed, Dec 6, 2017 at 1:40 PM, Tomer Brisker wrote: > > Hello, > > As many of you may have noticed, foreman-core open PR count has been in > the > > area of

Re: [foreman-dev] RFC Auto Refresh on ForemanTasks#Tasks Page

On Dec 6, 2017 12:19 PM, "Ivan Necas" wrote: The only concern, as the users are used to the auto-refresh, once we turn that off, they can start thinking the thing got stuck. In that case let's keep updating the talk progress without replacing the entire tab? -- Ivan On

Re: [foreman-dev] RFC Auto Refresh on ForemanTasks#Tasks Page

On Wed, Dec 6, 2017 at 9:10 PM, Walden Raines wrote: > > Oh yeah, especially notifications. Why can't they just update when the > page updates? > > I think it would be good to move the notifications to a websocket approach > instead of polling. I know, I know, PRs welcome :)

Re: [foreman-dev] RFC Auto Refresh on ForemanTasks#Tasks Page

> Oh yeah, especially notifications. Why can't they just update when the page updates? I think it would be good to move the notifications to a websocket approach instead of polling. I know, I know, PRs welcome :) On Wed, Dec 6, 2017 at 1:23 PM, Ohad Levy wrote: > > > On

Re: [foreman-dev] RFC: File audit for template rendering

You are right that in general, this is an anti-pattern, but the data we will be sending is write only logging data. It's essentially a log sink, but for arbitrary data (blobs, files, name it you want). In clustered setup, you simply keep the logs on nodes along with other logging data. On the

Re: [foreman-dev] Is it time to remove turbolinks?

The idea behind turbolinks is good in general - it works great when you have a standard Rails application with its view stack (ERB). When I saw this talked, I liked it very much: https://www.youtube.com/watch?v=SWEts0rlezA Unfortunately, we are not good fit. This works for a clean app which ERB

Re: [foreman-dev] RFC Auto Refresh on ForemanTasks#Tasks Page

> I think the refresh should still be off by default. As part of this I would love to see *all* auto reloads default to off. The dashboard, for example, constantly reloading by default is annoying to me. Cheers, Walden On Wed, Dec 6, 2017 at 11:16 AM, Andrew Kofink wrote:

Re: [foreman-dev] Is it time to remove turbolinks?

On Wed, Dec 6, 2017 at 5:10 PM, Walden Raines wrote: > I am seeing more and more issues [1][2] around turbolinks and I'm > wondering if it's time to remove it from foreman. I have seen it > recommended that one shouldn't use the back button in foreman; I thought > that

Re: [foreman-dev] RFC Auto Refresh on ForemanTasks#Tasks Page

The only concern, as the users are used to the auto-refresh, once we turn that off, they can start thinking the thing got stuck. -- Ivan On Wed, 6 Dec 2017 at 17:50, Ohad Levy wrote: > On Wed, Dec 6, 2017 at 6:48 PM, Andrew Kofink wrote: > >> As part of

Re: [foreman-dev] RFC Auto Refresh on ForemanTasks#Tasks Page

> > As part of this I would love to see *all* auto reloads default to off Oh yeah, especially notifications. Why can't they just update when the page updates? On Wed, Dec 6, 2017 at 11:27 AM, Walden Raines wrote: > > I think the refresh should still be off by default. > >

Re: [foreman-dev] RFC Auto Refresh on ForemanTasks#Tasks Page

On Wed, Dec 6, 2017 at 6:48 PM, Andrew Kofink wrote: > As part of this I would love to see *all* auto reloads default to off >> > +1 - PR are welcomes ;) > Oh yeah, especially notifications. Why can't they just update when the > page updates? > > On Wed, Dec 6, 2017 at

Re: [foreman-dev] Nominating additional maintainers in foreman-core

+1 to both -- Adam On Wed, Dec 6, 2017 at 1:40 PM, Tomer Brisker wrote: > Hello, > ​As many of you may have noticed, foreman-core open PR​ count has been in > the area of 100-110 for most of the last few months. There are only a few > people with merge access that actively

Re: [foreman-dev] Nominating additional maintainers in foreman-core

+1 to both On Wed, Dec 6, 2017 at 1:53 PM, Eric D Helms wrote: > +1 to both! > > On Wed, Dec 6, 2017 at 7:51 AM, Adam Ruzicka wrote: > >> +1 to both >> >> -- Adam >> >> >> On Wed, Dec 6, 2017 at 1:40 PM, Tomer Brisker >> wrote:

[foreman-dev] Nominating additional maintainers in foreman-core

Hello, ​As many of you may have noticed, foreman-core open PR​ count has been in the area of 100-110 for most of the last few months. There are only a few people with merge access that actively review PRs, so that the time it takes for changes to be accepted can take long. I would like to propose

Re: [foreman-dev] Nominating additional maintainers in foreman-core

On Wed, Dec 06, 2017 at 02:40:36PM +0200, Tomer Brisker wrote: Shimon Shtein - has 75 merged commits [1] and has taken part in the reviews of 64 merged commits[2]. +1 Michael Moll - has 71 merged commits [3] and has taken part in the reviews of 130 merged commits[4]. He is also already a

Re: [foreman-dev] Nominating additional maintainers in foreman-core

+1 to both! On Wed, Dec 6, 2017 at 7:51 AM, Adam Ruzicka wrote: > +1 to both > > -- Adam > > > On Wed, Dec 6, 2017 at 1:40 PM, Tomer Brisker wrote: > >> Hello, >> ​As many of you may have noticed, foreman-core open PR​ count has been in >> the area of

[foreman-dev] Be sure to import your product content data for Katello 3.6

Hi all, A change landed in Katello yesterday which introduced a new pattern of importing product content information from Candlepin into the Katello DB. This is in support of some new feature work and means

Re: [foreman-dev] Nominating additional maintainers in foreman-core

+1 +1 -- Marek On December 6, 2017 3:14:28 PM Ohad Levy wrote: On Dec 6, 2017 7:41 AM, "Tomer Brisker" wrote: Hello, ?As many of you may have noticed, foreman-core open PR? count has been in the area of 100-110 for most of the last few months.

[foreman-dev] Is it time to remove turbolinks?

I am seeing more and more issues [1][2] around turbolinks and I'm wondering if it's time to remove it from foreman. I have seen it recommended that one shouldn't use the back button in foreman; I thought that request was reserved for poorly written php sites that resubmit forms when the back

Re: [foreman-dev] Nominating additional maintainers in foreman-core

On Dec 6, 2017 7:41 AM, "Tomer Brisker" wrote: Hello, ​As many of you may have noticed, foreman-core open PR​ count has been in the area of 100-110 for most of the last few months. There are only a few people with merge access that actively review PRs, so that the time it

Re: [foreman-dev] Nominating additional maintainers in foreman-core

+1 to both! On Wed, Dec 6, 2017 at 9:14 AM, Ohad Levy wrote: > > > On Dec 6, 2017 7:41 AM, "Tomer Brisker" wrote: > > Hello, > ​As many of you may have noticed, foreman-core open PR​ count has been in > the area of 100-110 for most of the last few