On 25/04/17 12:45, Marek Hulán wrote: > On úterý 25. dubna 2017 9:19:40 CEST Dominic Cleal wrote: >> On 24/04/17 12:59, Marek Hulán wrote: >>> based on our handbook [1]. I'd like to nominate Daniel for commit access >>> to >>> >>> the following repositories: >>> - foreman-infra >>> - foreman-installer >>> - foreman-packaging ( to branch and cherry-pick to the release branch ) >>> >>> Daniel contributes to the project for a long time, also in this area >>> [2][3][4] and always has only the best intentions. He worked on 1.15 RC1 >>> and I think there's no reason why he shouldn't have access to places >>> which are needed to update during the release process. >> These repos all have active maintainers and so making a pull request (as >> Daniel's done on two of them) is a better way to make changes. I don't >> think commit access is necessary to submit updates to these repos and >> shouldn't be encouraged here for Foreman releases. > I'm happy to hear that there are active maintainers. I'm not sure whether you > suggest that it is the reason why commit access should not be granted? I > think > the more active committers the better. Doing this through PR is fine and as > you say, it can find issues. But if other devs send PRs, I think it makes > sense if Daniel can merge them. Commit access is also required to create > branches and tags which I don't think needs any form of reviewing. > > I'm sorry if it seemed like I'm encouraging pushing commits directly without > PR during release process. That was not subject of this nomination.
OK, sorry, that's what I thought you were suggesting. In that case, I don't think Daniel's had much involvement with the foreman-infra or foreman-installer projects to warrant commit access. He's opened a lot of PRs against foreman-packaging, but I'd want to see fewer common errors in recent PRs before seconding him for commit access. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
