Re: [foreman-dev] Setting[:remote_addr] in ip_from_request_env in unattended_controller.rb.

2016-07-18 Thread Dominic Cleal
On 17/07/16 18:33, adrian wrote: > Nevermind, I can't push, so here's the diff: If you push your branch to your GitHub fork, you can open up a pull request from the web UI against the original repo. See https://help.github.com/articles/using-pull-requests/ for details. -- Dominic Cleal

Re: [foreman-dev] Setting[:remote_addr] in ip_from_request_env in unattended_controller.rb.

2016-07-17 Thread adrian
I cloned the repo, modified the doc section, and committed. First time doing this on github, so if I've done something backwards, or broken any code etiquette, I stand to be corrected. ;) On Sunday, July 17, 2016 at 11:38:23 AM UTC-4, Greg Sutcliffe wrote: > > On 17 July 2016 at 16:22, adiran

[foreman-dev] Setting[:remote_addr] in ip_from_request_env in unattended_controller.rb.

2016-07-16 Thread adiran
I've been working through troubleshooting template requests via a smart-proxy without a token present. The request is from the client IP, which gets masked by the proxy on forward, but when I reviewed the code I noticed that the proxy inserts an X-Forwarded-For header, which foreman's