Hi Tobias,
The patch looks fine to me. OK for 10- and 11-branches. I am not convinced
that a delay is needed for the backport.
Thanks
Paul
On Thu, 11 Mar 2021 at 18:19, Tobias Burnus wrote:
> This fixes an ICE with OpenMP 'omp decare simd' but is a generic bug.
>
> Namely TREE_TYPE(fndecl)
*PING* of my 11.03.21 18:15 CET patch.
The issue is that the TREE_TYPE of the fndecl does not match its arglist.
In some cases, the middle end looks at the function type – and then it
goes wrong.
The issue only occurs for -fcoarray=lib as other hidden arguments are
properly handled.
Early ping – and minor post script:
+ hidden_typelist = TREE_CHAIN (hidden_typelist);
This change is to avoid running into the ICE:
gcc_assert (hidden_typelist == NULL_TREE
|| TREE_VALUE (hidden_typelist) == void_type_node);
The purpose of this assert is to check that
This fixes an ICE with OpenMP 'omp decare simd' but is a generic bug.
Namely TREE_TYPE(fndecl) has a mismatch to the arglist chain,
missing some hidden arguments with -fcoarray=lib.
OK for mainline and GCC 10?
Tobias
-
Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201,
