Re: [fossil-dev] UTF8 in commit message content using -M

2014-11-12 Thread Scott Robison
On Wed, Nov 12, 2014 at 7:55 AM, Stephan Beal wrote: > On Wed, Nov 12, 2014 at 3:38 PM, Jan Nijtmans > wrote: > >> 2014-11-11 19:32 GMT+01:00 Scott Robison: >> > I think checking for a well >> > formed UTF-8 buffer and switching between it and "raw code page style >> > encoding" isn't a bad opti

Re: [fossil-dev] UTF8 in commit message content using -M

2014-11-12 Thread Stephan Beal
On Wed, Nov 12, 2014 at 3:38 PM, Jan Nijtmans wrote: > 2014-11-11 19:32 GMT+01:00 Scott Robison: > > I think checking for a well > > formed UTF-8 buffer and switching between it and "raw code page style > > encoding" isn't a bad option. > > Not a bad idea at all! When this code was written, the f

Re: [fossil-dev] UTF8 in commit message content using -M

2014-11-12 Thread Jan Nijtmans
2014-11-11 19:32 GMT+01:00 Scott Robison: > I think checking for a well > formed UTF-8 buffer and switching between it and "raw code page style > encoding" isn't a bad option. Not a bad idea at all! When this code was written, the function invalid_utf8() didn't exist yet, but now it does ;-)

Re: [fossil-dev] UTF8 in commit message content using -M

2014-11-11 Thread Scott Robison
On Tue, Nov 11, 2014 at 9:00 AM, Stephan Beal wrote: > On Tue, Nov 11, 2014 at 1:12 PM, Jan Nijtmans > wrote: > >> The convention on Windows is to assume CP1252, unless the file >> starts with the UTF-8 BOM. That's exactly what fossil is doing here: >>

Re: [fossil-dev] UTF8 in commit message content using -M

2014-11-11 Thread Stephan Beal
On Tue, Nov 11, 2014 at 1:12 PM, Jan Nijtmans wrote: > The convention on Windows is to assume CP1252, unless the file > starts with the UTF-8 BOM. That's exactly what fossil is doing here: > > So, make sure that the file sta

Re: [fossil-dev] UTF8 in commit message content using -M

2014-11-11 Thread Jan Nijtmans
2014-11-11 12:50 GMT+01:00 Stephan Beal : > Hi, all, > > this just came across the moderation requests... > > http://fossil-scm.org/index.html/tktview/5a0a33f31a7a7915bf8e78d0b1395c9879dfc6c5 > > Management summary: encoding is not honored with the -M FILENAME option to > commit (which reads the co

Re: [fossil-dev] UTF8 in commit message content using -M

2014-11-11 Thread Richard Hipp
On Tue, Nov 11, 2014 at 6:50 AM, Stephan Beal wrote: > Hi, all, > > this just came across the moderation requests... > > > http://fossil-scm.org/index.html/tktview/5a0a33f31a7a7915bf8e78d0b1395c9879dfc6c5 > > Management summary: encoding is not honored with the -M FILENAME option to > commit (whi