Re: [fossil-dev] "merge-renames" branch review

2016-05-12 Thread Richard Hipp
On 5/12/16, Joel Bruick wrote: > Richard, please give the "merge-renames" branch another look when you > get a chance. I made a few small changes, and I also added code and > tests for merging in changes to execute permissions, which were > previously just being ignored. > > Unless you have any ot

Re: [fossil-dev] "merge-renames" branch review

2016-05-12 Thread Joel Bruick
Richard, please give the "merge-renames" branch another look when you get a chance. I made a few small changes, and I also added code and tests for merging in changes to execute permissions, which were previously just being ignored. Unless you have any other issues I need to fix, I'm happy wit

Re: [fossil-dev] Style

2016-05-12 Thread Richard Hipp
On 5/12/16, Andy Goth wrote: > How about variable naming? I see a kind of Hungarian notation is widely > but not universally used. I tried to match it where I could figure what > made sense. > Trying to match existing code is the best approach. I agree that it would be good to document variab

Re: [fossil-dev] Style

2016-05-12 Thread Andy Goth
On 5/12/2016 9:47 AM, Richard Hipp wrote: > On 5/12/16, Andy Goth wrote: >> I'm looking for fiddly bits like placement of spaces adjacent to >> parentheses, braces, and operators; also how to indent overlong logical >> source lines continued across multiple physical source lines. > > We don't hav

Re: [fossil-dev] Style

2016-05-12 Thread Richard Hipp
On 5/12/16, Andy Goth wrote: > > I'm looking for fiddly bits like placement of spaces adjacent to > parentheses, braces, and operators; also how to indent overlong logical > source lines continued across multiple physical source lines. > We don't have any documentation on the fiddly details. Try

Re: [fossil-dev] Style

2016-05-12 Thread Andy Goth
On 5/12/2016 9:02 AM, Richard Hipp wrote: > On 5/12/16, Andy Goth wrote: >> Is there a documented preferred style for Fossil coding? > > https://www.fossil-scm.org/fossil/doc/trunk/www/style.wiki > > The above could perhaps be augmented. Thanks. That's pretty much all stuff I do anyway though

Re: [fossil-dev] Style

2016-05-12 Thread Richard Hipp
On 5/12/16, Andy Goth wrote: > Is there a documented preferred style for Fossil coding? https://www.fossil-scm.org/fossil/doc/trunk/www/style.wiki The above could perhaps be augmented. -- D. Richard Hipp d...@sqlite.org ___ fossil-dev mailing list fo

[fossil-dev] Style

2016-05-12 Thread Andy Goth
Is there a documented preferred style for Fossil coding? I try to match the style already present in the source files, but it's not internally consistent. So I try to go with a majority rule, though I can't be sure I'm going toward or away from whatever preferred style there may or may not be, pl