Re: [fossil-dev] [PATCH] Fix a problem with bidirectional git import/export

2016-09-21 Thread Nickolas Lloyd
Ross Berteig writes: > Grinding my pet axe, extending the test framework to cover your patch > with test cases that fail without it and pass with it would be welcome. > The test framework is written in Tcl, and lives next to the sources in > test/*.test. I suspect there aren't any tests at all y

Re: [fossil-dev] [PATCH] Fix a problem with bidirectional git import/export

2016-09-19 Thread Ross Berteig
On 9/19/2016 12:31 PM, Nickolas Lloyd wrote: I signed and submitted a contributor agreement in May when I submitted a patch for consideration. Richard actually gave me checkin priveleges at that point to push the change myself, but I didn't want to assume that constituted permission for fut

Re: [fossil-dev] [PATCH] Fix a problem with bidirectional git import/export

2016-09-19 Thread Nickolas Lloyd
Joe Mistachkin wrote: > Signing the contributor agreement would probably be quite helpful: > > https://www.fossil-scm.org/fossil/doc/trunk/www/contribute.wiki > > In terms of code review, I'm not sure which people know enough about Git > to review your changes (which look good to me, FWIW).

Re: [fossil-dev] [PATCH] Fix a problem with bidirectional git import/export

2016-09-19 Thread Nickolas Lloyd
Hi, Is there anyone that's familiar with Fossil's import and export system that would be able/willing to review this? Other than code reviews are there any steps I should take to increase the likelihood of the patch being accepted? Thanks! -Nick Nickolas Lloyd writes: > Hi, > > Following is

[fossil-dev] [PATCH] Fix a problem with bidirectional git import/export

2016-09-12 Thread Nickolas Lloyd
Hi, Following is a patch against fossil commit [4d1f2d302b] that fixes an issue that can appear when performing multiple imports/exports with a git repository. The problem arises when fossil tries to export a blob to git with a mark which has been previously used by git when importing a commit to