Re: [fossil-dev] Limiting heap and stack space in Fossil

On Jun 24, 2017, at 8:09 AM, Richard Hipp wrote: > > This should be implemented on trunk. Please try it out and let me > know how it works. Yep, that’s got it, thanks! Incidentally, I ran the test from the Stack Overflow post on a nearly-untouched CentOS 7 VM over the

Re: [fossil-dev] Limiting heap and stack space in Fossil

On Jun 23, 2017, at 12:16 PM, Warren Young wrote: > > I’ve posted that test program to Stack Overflow… This Internet thing is pretty great. Just 3 minutes after posting, someone has already come up with a better answer, which may be the best solution: call

Re: [fossil-dev] Limiting heap and stack space in Fossil

On Jun 23, 2017, at 10:09 AM, Richard Hipp wrote: > > Maybe Fossil needs to disable the stack and heap size limits prior to > calling exec() or fork() and then reenable the limits afterwards? Maybe. The current design is a bit like moralizing: Fossil has selected a limit it

Re: [fossil-dev] Limiting heap and stack space in Fossil

Maybe Fossil needs to disable the stack and heap size limits prior to calling exec() or fork() and then reenable the limits afterwards? On 6/23/17, Warren Young wrote: > On Jun 22, 2017, at 8:37 AM, Warren Young wrote: >> >> On Jun 22, 2017, at 6:23 AM,

Re: [fossil-dev] Limiting heap and stack space in Fossil

On Jun 22, 2017, at 8:37 AM, Warren Young wrote: > > On Jun 22, 2017, at 6:23 AM, Warren Young wrote: >> >>> Can you provide a test case? I’ve got a much better test case now as well as a potential solution. It turns out that the problem has nothing

Re: [fossil-dev] Limiting heap and stack space in Fossil

On Jun 22, 2017, at 6:23 AM, Warren Young wrote: > >> Can you provide a test case? > > I can’t share the repo, but I’ve dropped an abort() in front of the line I > referenced in the prior email, so sometime today I should have a backtrace > for you. Well, here it is, but

Re: [fossil-dev] Limiting heap and stack space in Fossil

On Jun 21, 2017, at 5:05 AM, Richard Hipp wrote: > > On 6/20/17, Warren Young wrote: >> >> Since updating and installing it, I’m getting occasional aborts in >> relatively simple tasks like fossil diff and fossil checkin. > > Are these reproducible? By

Re: [fossil-dev] Limiting heap and stack space in Fossil

On Tue, Jun 20, 2017 at 4:48 PM, Richard Hipp wrote: > Review and criticism of this change is welcomed. > Is an artificial stack limit really necessary? i can't personally conceive of any attacks which could cause fossil to recurse unduly (but i'm also someone uncreative when

Re: [fossil-dev] Limiting heap and stack space in Fossil

On Jun 20, 2017, at 8:48 AM, Richard Hipp wrote: > > Review and criticism of this change is welcomed. Since updating and installing it, I’m getting occasional aborts in relatively simple tasks like fossil diff and fossil checkin. fossil diff with uncommitted changes doesn’t