Re: [fossil-dev] Possible Markdown memleak

2017-10-27 Thread Richard Hipp
On 10/27/17, Richard Hipp wrote: > > (2) Memory leaks do not usually matter in Fossil, since each command > runs to completion and the process dies, leaving the OS to clean up > any memory. Only memory leaks inside of a loop make a difference. Another way to think of this: The memory will be ga

Re: [fossil-dev] Possible Markdown memleak

2017-10-27 Thread Richard Hipp
On 10/27/17, Johan Kuuse wrote: > Hi, > > I think the two blobs used for markdown input and output (rendered > HTML) aren't free()'d properly. I'm sure your are correct about the leaks, though two points: (1) The proper way to fix them is to call blob_reset() on the Blob object, not by trying to

[fossil-dev] Possible Markdown memleak

2017-10-27 Thread Johan Kuuse
Hi, I think the two blobs used for markdown input and output (rendered HTML) aren't free()'d properly. This patch only applies to test_markdown_render(), but the same behaviour may occur at other places where markdown_to_html() is called. BR, Johan Index: src/wiki.c ===