Re: [fossil-dev] Testing fossil 2.1

2017-03-15 Thread Ross Berteig
Today's progress: * As of checkin [3537c75cc3] many tests run clean without errors: amend.test, clean.test, cmdline.test, comment.test, contains-selector.test, delta1.test, diff.test, file1.test, glob.test, merge1.test, merge2.test, merge3.test, merge4.test, merge6.test, merge_exe.test, merg

Re: [fossil-dev] Testing fossil 2.1

2017-03-15 Thread Ross Berteig
More progress... On 3/14/2017 4:36 PM, Ross Berteig wrote: TODO * Fix all the rest of amend.test where it is all tangled up in itself related to the UUID. Fixed by capturing at most 40 chars of uuid from command output, which is all that was present in many cases, and by matching only

Re: [fossil-dev] Testing fossil 2.1

2017-03-14 Thread Richard Hipp
On 3/14/17, Ross Berteig wrote: > * Noticed Jan's narrowing of my kludge to just MinGW for Win32 builds. > I still think the right answer is to either not use strtok_r() at all, > or find a proper parking place for the implementation for MinGW on Win32. I'll take the action to get rid of strtok

Re: [fossil-dev] Testing fossil 2.1

2017-03-14 Thread Ross Berteig
Today's progress. * Added test case for the Markdown bug related to quoted delimiters that was fixed this morning, in th1.test next to the other tests of Markdown. * Added same_uuid function to tester.tcl to make comparing hash values easier when extracted from commands that output differe

Re: [fossil-dev] Testing fossil 2.1

2017-03-13 Thread Ross Berteig
On 3/13/2017 5:17 PM, Richard Hipp wrote: I think the best solution here would be to change the RE to be "([0-9a-f]{40,64})". Does that fix the problem? That improves things, and moves to a new problem. A number of commands (sensibly) trim their output to a 40-character prefix of the UUID. S

Re: [fossil-dev] Testing fossil 2.1

2017-03-13 Thread Warren Young
On Mar 13, 2017, at 6:13 PM, Richard Hipp wrote: > > On 3/13/17, Ross Berteig wrote: >> I seem to have the test suite bee in my bonnet this week. > > I, for one, am hoping that bee hangs around :-) Can we get him a hat of office or something? :) ___

Re: [fossil-dev] Testing fossil 2.1

2017-03-13 Thread Richard Hipp
On 3/13/17, Ross Berteig wrote: > > proc uuid_from_commit {res var} { >upvar $var UUID >regexp {^New_Version: ([0-9a-f]{40})$} $res m UUID > } > > That regexp is clearly seeking a UUID exactly 40 characters long. I think the best solution here would be to change the RE to be "([0-9a-f]{40

Re: [fossil-dev] Testing fossil 2.1

2017-03-13 Thread Richard Hipp
On 3/13/17, Ross Berteig wrote: > I seem to have the test suite bee in my bonnet this week. I, for one, am hoping that bee hangs around :-) It's ok to do your test debugging on trunk, if you want to go ahead and merge your branch. -- D. Richard Hipp [email protected]

[fossil-dev] Testing fossil 2.1

2017-03-13 Thread Ross Berteig
I seem to have the test suite bee in my bonnet this week. I'd like the suite to execute cleanly for fossil 2.1, which it no longer doesfor reasons related to SHA3. The most obvious case is that there are numerous spots in the test suite where command output is parsed to recover some hash value