Re: [fossil-users] Wiki naming limitations
On Oct 26, 2012, Carlo Miron ca...@miron.it wrote: On Fri, Oct 26, 2012 at 4:11 PM, K k...@lightpowered.org wrote: On Oct 26, 2012, Carlo Miron ca...@miron.it wrote: On Fri, Oct 26, 2012 at 1:28 AM, K k...@lightpowered.org wrote: On Oct 24, 2012, Ron Aaron r...@ronware.org wrote: Wouldn't it be better to make this a parameter the user can adjust rather than permitting any length? While this is a more complex solution, I would support it. Perhaps in the Admin area, some option to control the minimum wiki name length, defaulting to 3. Input from others? To me, it seems completely YAGNI. I'm not familiar with that acronym. Would you please clarify? Sorry. http://en.wikipedia.org/wiki/You_ain't_gonna_need_it So should we then just integrate the diff into the official branch which reduces the length requirement of wikis from 3 characters to 1? ^K © -- R K-M-S L ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Wiki naming limitations
It seems like, at least for now, you ought to patch your own copy--I'm not seeing any strong general response that that's a good or needed change to make, so you could be waiting a while if you're waiting on the main devs for this. On 10/28/2012 09:57 AM, K wrote: On Oct 26, 2012, Carlo Miron ca...@miron.it wrote: On Fri, Oct 26, 2012 at 4:11 PM, K k...@lightpowered.org wrote: On Oct 26, 2012, Carlo Miron ca...@miron.it wrote: On Fri, Oct 26, 2012 at 1:28 AM, K k...@lightpowered.org wrote: On Oct 24, 2012, Ron Aaron r...@ronware.org wrote: Wouldn't it be better to make this a parameter the user can adjust rather than permitting any length? While this is a more complex solution, I would support it. Perhaps in the Admin area, some option to control the minimum wiki name length, defaulting to 3. Input from others? To me, it seems completely YAGNI. I'm not familiar with that acronym. Would you please clarify? Sorry. http://en.wikipedia.org/wiki/You_ain't_gonna_need_it So should we then just integrate the diff into the official branch which reduces the length requirement of wikis from 3 characters to 1? ^K © -- R K-M-S L ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Wiki naming limitations
On Oct 28, 2012, Steve Havelka yo...@q7.com wrote: It seems like, at least for now, you ought to patch your own copy--I'm not seeing any strong general response that that's a good or needed change to make, so you could be waiting a while if you're waiting on the main devs for this. I'm happy to submit a change to the official branch, I'm just new to this project and don't know the process for that yet. I asked in another email, but it wasn't addressed. Literally my first day using Fossil I ran into a problem, the wiki naming limitation. This doesn't seem too obscure to not warrant a tweak to the code. ^K On 10/28/2012 09:57 AM, K wrote: On Oct 26, 2012, Carlo Miron ca...@miron.it wrote: On Fri, Oct 26, 2012 at 4:11 PM, K k...@lightpowered.org wrote: On Oct 26, 2012, Carlo Miron ca...@miron.it wrote: On Fri, Oct 26, 2012 at 1:28 AM, K k...@lightpowered.org wrote: On Oct 24, 2012, Ron Aaron r...@ronware.org wrote: Wouldn't it be better to make this a parameter the user can adjust rather than permitting any length? While this is a more complex solution, I would support it. Perhaps in the Admin area, some option to control the minimum wiki name length, defaulting to 3. Input from others? To me, it seems completely YAGNI. I'm not familiar with that acronym. Would you please clarify? Sorry. http://en.wikipedia.org/wiki/You_ain't_gonna_need_it So should we then just integrate the diff into the official branch which reduces the length requirement of wikis from 3 characters to 1? ^K © -- R K-M-S L ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Wiki naming limitations
On 29 October 2012 02:44, K k...@lightpowered.org wrote: Literally my first day using Fossil I ran into a problem, the wiki naming limitation. This doesn't seem too obscure to not warrant a tweak to the code. The obscure part isn't the naming limitation, it's the desire to have page names under 3 characters in length. Fossil's been around for quite a while now and *nobody* has noticed this limitation before because, apparently, the overwhelming majority of users use 3 or more characters. I'm not sure what the ramifications are—if any—to use of 2 or 1 characters for wiki names, but I'm pretty sure that the devs are going to look closely at these potential problems before modifying anything. And, likely, that look will be a pretty low priority. -- Perhaps people don't believe this, but throughout all of the discussions of entering China our focus has really been what's best for the Chinese people. It's not been about our revenue or profit or whatnot. --Sergey Brin, demonstrating the emptiness of the don't be evil mantra. ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Wiki naming limitations
On Oct 28, 2012, Michael Richter ttmrich...@gmail.com wrote: On 29 October 2012 02:44, K k...@lightpowered.org wrote: Literally my first day using Fossil I ran into a problem, the wiki naming limitation. This doesn't seem too obscure to not warrant a tweak to the code. The obscure part isn't the naming limitation, it's the desire to have page names under 3 characters in length. Fossil's been around for quite a while now and nobody has noticed this limitation before because, apparently, the overwhelming majority of users use 3 or more characters. :) Ok, I'll maintain a personal branch. Thanks all. (Especially James Turner for offering up the bug fix!) ^K I'm not sure what the ramifications are—if any—to use of 2 or 1 characters for wiki names, but I'm pretty sure that the devs are going to look closely at these potential problems before modifying anything. And, likely, that look will be a pretty low priority. -- Perhaps people don't believe this, but throughout all of the discussions of entering China our focus has really been what's best for the Chinese people. It's not been about our revenue or profit or whatnot. --Sergey Brin, demonstrating the emptiness of the don't be evil mantra. ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Wiki naming limitations
On Fri, Oct 26, 2012 at 1:28 AM, K k...@lightpowered.org wrote: On Oct 24, 2012, Ron Aaron r...@ronware.org wrote: Wouldn't it be better to make this a parameter the user can adjust rather than permitting any length? While this is a more complex solution, I would support it. Perhaps in the Admin area, some option to control the minimum wiki name length, defaulting to 3. Input from others? To me, it seems completely YAGNI. © -- R K-M-S L ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Wiki naming limitations
On Oct 26, 2012, Carlo Miron ca...@miron.it wrote: On Fri, Oct 26, 2012 at 1:28 AM, K k...@lightpowered.org wrote: On Oct 24, 2012, Ron Aaron r...@ronware.org wrote: Wouldn't it be better to make this a parameter the user can adjust rather than permitting any length? While this is a more complex solution, I would support it. Perhaps in the Admin area, some option to control the minimum wiki name length, defaulting to 3. Input from others? To me, it seems completely YAGNI. I'm not familiar with that acronym. Would you please clarify? ^K © -- R K-M-S L ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Wiki naming limitations
On Fri, Oct 26, 2012 at 4:11 PM, K k...@lightpowered.org wrote: On Oct 26, 2012, Carlo Miron ca...@miron.it wrote: On Fri, Oct 26, 2012 at 1:28 AM, K k...@lightpowered.org wrote: On Oct 24, 2012, Ron Aaron r...@ronware.org wrote: Wouldn't it be better to make this a parameter the user can adjust rather than permitting any length? While this is a more complex solution, I would support it. Perhaps in the Admin area, some option to control the minimum wiki name length, defaulting to 3. Input from others? To me, it seems completely YAGNI. I'm not familiar with that acronym. Would you please clarify? Sorry. http://en.wikipedia.org/wiki/You_ain't_gonna_need_it © -- R K-M-S L ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Wiki naming limitations
On Oct 24, 2012, Ron Aaron r...@ronware.org wrote: Wouldn't it be better to make this a parameter the user can adjust rather than permitting any length? While this is a more complex solution, I would support it. Perhaps in the Admin area, some option to control the minimum wiki name length, defaulting to 3. Input from others? ^K ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Wiki naming limitations
2012/10/24 K k...@lightpowered.org: The diff provided works. How can we get this into the official source code? James, thank you. File a ticket. Currently that's only possible for registered users. I just copied your first mail to a ticket, see: https://www.fossil-scm.org/index.html/tktview?name=897c39d284 Then commit it to a branch, such as ticket-897c39d284. (done so) This allows a fossil developer to evaluate it and run any additional tests, to see if it breaks anything else unexpectedly. I don't see anything wrong with it, but I still am not that familiar with Fossil yet that I can really judge that. The more people try it and report their success (or not), the more likely that it will go in eventually. Regards, Jan Nijtmans ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Wiki naming limitations
Wouldn't it be better to make this a parameter the user can adjust rather than permitting any length? ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
[fossil-users] Wiki naming limitations
Is someone able to explain to me why there is a 3-character minimum to wiki names? This seems to me like a strange arbitrary constraint to impose. The minimum-3-chararacter rule is subjective. When I wrote Fossil (6 years ago) it never occurred to me that anybody would want a wiki page name of less than 3 characters. The patch to relax that rule should be trivial. I just tried fossil 1.24 and wiki pages still must be 3 characters or greater. I would appreciate receiving instruction on how to go about getting this changed to a lower number of characters. I personally would suggest a minimum of 1 character as I find anything greater to be arbitrary. Please advise. Kind regards, ^K ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Wiki naming limitations
On Tue, Oct 23, 2012 at 11:36:34PM +, K wrote:
Is someone able to explain to me why there is a 3-character minimum to wiki
names? This seems to me like a strange arbitrary constraint to impose.
The minimum-3-chararacter rule is subjective. When I wrote Fossil (6 years
ago) it never occurred to me that anybody would want a wiki page name of
less than 3 characters.
The patch to relax that rule should be trivial.
I just tried fossil 1.24 and wiki pages still must be 3 characters or
greater. I would appreciate receiving instruction on how to go about getting
this changed to a lower number of characters. I personally would suggest a
minimum of 1 character as I find anything greater to be arbitrary.
Please advise.
Kind regards,
^K
K,
The attached diff should decrease the limit to 1 character.
--
James Turner
ja...@calminferno.net
Index: src/wiki.c
==
--- src/wiki.c
+++ src/wiki.c
@@ -27,11 +27,11 @@
** Return true if the input string is a well-formed wiki page name.
**
** Well-formed wiki page names do not begin or end with whitespace,
** and do not contain tabs or other control characters and do not
** contain more than a single space character in a row. Well-formed
-** names must be between 3 and 100 chracters in length, inclusive.
+** names must be between 1 and 100 chracters in length, inclusive.
*/
int wiki_name_is_wellformed(const unsigned char *z){
int i;
if( z[0]=0x20 ){
return 0;
@@ -39,11 +39,11 @@
for(i=1; z[i]; i++){
if( z[i]0x20 ) return 0;
if( z[i]==0x20 z[i-1]==0x20 ) return 0;
}
if( z[i-1]==' ' ) return 0;
- if( i3 || i100 ) return 0;
+ if( i1 || i100 ) return 0;
return 1;
}
/*
** Output rules for well-formed wiki pages
@@ -52,11 +52,11 @@
@ ul
@ li Must not begin or end with a space./li
@ li Must not contain any control characters, including tab or
@ newline./li
@ li Must not have two or more spaces in a row internally./li
- @ li Must be between 3 and 100 characters in length./li
+ @ li Must be between 1 and 100 characters in length./li
@ /ul
}
/*
** Check a wiki name. If it is not well-formed, then issue an error
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Wiki naming limitations
On 10/23/2012 4:36 PM, K wrote: Is someone able to explain to me why there is a 3-character minimum to wiki names? ... I just tried fossil 1.24 and wiki pages still must be 3 characters or greater. I would appreciate receiving instruction on how to go about getting this changed to a lower number of characters. I personallywould suggest a minimum of 1 characteras I find anything greater to be arbitrary. I have not tested this, but it looks plausible. This restriction comes from the function wiki_name_is_wellformed() in src/wiki.c. It is the first function in the file. Find the only occurrence of the digit 3 at the next to last line of the file and change it to 1 (or any reasonable value you choose). -- Ross Berteig r...@cheshireeng.com Cheshire Engineering Corp. http://www.CheshireEng.com/ +1 626 303 1602 +1 626 351 1590 FAX ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Wiki naming limitations
The diff provided works. How can we get this into the official source code? James, thank you. ^K On Oct 23, 2012, James Turner ja...@calminferno.net wrote: On Tue, Oct 23, 2012 at 11:36:34PM +, K wrote: Is someone able to explain to me why there is a 3-character minimum to wiki names? This seems to me like a strange arbitrary constraint to impose. The minimum-3-chararacter rule is subjective. When I wrote Fossil (6 years ago) it never occurred to me that anybody would want a wiki page name of less than 3 characters. The patch to relax that rule should be trivial. I just tried fossil 1.24 and wiki pages still must be 3 characters or greater. I would appreciate receiving instruction on how to go about getting this changed to a lower number of characters. I personally would suggest a minimum of 1 character as I find anything greater to be arbitrary. Please advise. Kind regards, ^K K, The attached diff should decrease the limit to 1 character. -- James Turner ja...@calminferno.net ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
