Re: [fossil-users] Segmentation fault of mkversion

[Richard Hipp]

On 8/5/17, jiazhouyan...@sina.com  wrote:
> Hi,
> I'm new to fossil and I find that the component mkversion would crash if
> input wrong files, e.g., "$./mkversion wrong_file_1 wrong_file_2
> wrong_file_3” will trigger a segfault.
> I think it would be better if mkversion could exit gracefully with proper
> log messages. Attached please find the patch against version fossil-2.1.
> Hopefully, it can solve this problem.
> Best,Zhouyang

https://www.fossil-scm.org/fossil/info/8b9ce19e38d5b7da

Aside: Why is this important?  mkversion is a one-off utility program
used during the build process, and shouldn't ever be called with
incorrect arguments, as no human ever calls it, only the Makefile.
The job done by mkversion was originally done by a sequence of awk
commands 
(https://www.fossil-scm.org/fossil/artifact/7bf5ce2b3fbc241b?ln=262-264)
but as awk is not commonly available on windows systems, we wrote a
quick-and-dirty C program to do the job instead.
-- 
D. Richard Hipp
d...@sqlite.org
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

[fossil-users] Segmentation fault of mkversion

[jiazhouyang09]

Hi,
I'm new to fossil and I find that the component mkversion would crash if input 
wrong files, e.g., "$./mkversion wrong_file_1 wrong_file_2 wrong_file_3” will 
trigger a segfault.
I think it would be better if mkversion could exit gracefully with proper log 
messages. Attached please find the patch against version fossil-2.1. Hopefully, 
it can solve this problem.
Best,Zhouyang

fossil-2.1.patch
Description: Binary data
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users