[fpc-devel] Warning: Constructor should be public

2009-04-06 Thread Léo Willian Kölln
Simply question. Why? In Delphi i don´t need this, and on ObjPascal i don´t see why this is necessary... This warning happens even when i use the Delphi compatibility mode! Léo Willian Kölln ___ fpc-devel maillist - fpc-devel@lists.freepascal.org

Re: [fpc-devel] Warning: Constructor should be public

2009-04-06 Thread Graeme Geldenhuys
Simply question. Why? What did you do, try and lower the visibility of the constructor? If so, that is also not allowed in Delphi as far as I know. Regards, - Graeme - ___ fpGUI - a cross-platform Free Pascal GUI toolkit

Re: [fpc-devel] Warning: Constructor should be public

2009-04-06 Thread Léo Willian Kölln
No. See my singleton example: TLoggerGeral = class private {$IFDEF WINDOWS} class var FInstance : TLoggerGeral; {$ELSE} {$STATIC on} FInstance : TLoggerGeral; static; {$ENDIF} constructor Create; protected pCritSection: TCriticalSection; pLogarDatas :

Re: [fpc-devel] Warning: Constructor should be public

2009-04-06 Thread Flávio Etrusco
Actually, your constructor has the same signature as 'TObject.Create', so it should show a 'lower visibility' warning in Delphi, doesn't it? But, indeed, FPC shows the warning (should be public) for all constructors, even if you're not hiding from the parent class, and I always found this a

Re: [fpc-devel] Warning: Constructor should be public

2009-04-06 Thread Graeme Geldenhuys
On Mon, Apr 6, 2009 at 10:37 PM, Léo Willian Kölln leoko...@gmail.com wrote: No. See my singleton example: How did I guess it was going to be about implementing a Singleton. This issue has been raised a thousand times in FPC and Delphi circles. :) TLoggerGeral = class Which means you are

Re: [fpc-devel] Warning: Constructor should be public

2009-04-06 Thread Graeme Geldenhuys
2009/4/6 Flávio Etrusco flavio.etru...@gmail.com: Actually, your constructor has the same signature as 'TObject.Create', so it should show a 'lower visibility' warning in Delphi, doesn't it? Correct, Delphi should also give this warning. But, indeed, FPC shows the warning (should be public)