Re: [fpc-devel] Base64 decoding stream in the FCL

2007-02-22 Thread Bram Kuijvenhoven
Dean Zobec wrote: Attached is a patched base64 unit and a unit with FPCUnit tests. I zipped it to save space; I think my previous attempt has been rejected because the message was too big. A very nice and simple way of making testcases with different input parameters! Thank you. Testing seems

Re: [fpc-devel] Base64 decoding stream in the FCL

2007-02-21 Thread Dean Zobec
Bram Kuijvenhoven pravi: > Hi, > > Attached is a patched base64 unit and a unit with FPCUnit tests. I > zipped it to save space; I think my previous attempt has been rejected > because the message was too big. > > Changes: > - Added support for a MIME and a Strict mode for TBase64DecodingStream >

Re: [fpc-devel] Base64 decoding stream in the FCL

2007-02-19 Thread Florian Klaempfl
Bram Kuijvenhoven schrieb: Hi, Attached is a patched base64 unit and a unit with FPCUnit tests. I zipped it to save space; I think my previous attempt has been rejected because the message was too big. You can always create a bug report being a feature request and attach the patch. Then it

Re: [fpc-devel] Base64 decoding stream in the FCL

2007-02-16 Thread Bram Kuijvenhoven
Hi! I've implemented Strict and MIME mode for TBase64DecodingStream as promised. I also created some FPCUnit tests. The following motivates the meaning of TBase64DecodingStream.Size and TBase64DecodingStream.Position; please comment on whether this is the desired behavior of a 'filtering' stre

Re: [fpc-devel] Base64 decoding stream in the FCL

2007-02-12 Thread Bram Kuijvenhoven
Dean Zobec wrote: If you test it, please try adding tests in fpcunit format. What would be a good starting point to learn about how to use fpcunit? (I haven't used it before) The sources and examples :-) In particular the fcl/fpcunit/exampletests/moneytest.pp testing the money.pp example clas

Re: [fpc-devel] Base64 decoding stream in the FCL

2007-02-12 Thread Dean Zobec
>>> If you test it, please try adding tests in fpcunit format. >> What would be a good starting point to learn about how to use fpcunit? (I >> haven't used it before) > > The sources and examples :-) In particular the fcl/fpcunit/exampletests/moneytest.pp testing the money.pp example classes is

Re: [fpc-devel] Base64 decoding stream in the FCL

2007-02-12 Thread Michael Van Canneyt
On Mon, 12 Feb 2007, Bram Kuijvenhoven wrote: > Hi Michael, > Thanks for your reply! > > I have done a little more research; details are below. > > Michael Van Canneyt wrote: > > On Mon, 12 Feb 2007, Bram Kuijvenhoven wrote: > > > The Base64 decoding stream in the Base64 unit in the FCL appea

Re: [fpc-devel] Base64 decoding stream in the FCL

2007-02-12 Thread Bram Kuijvenhoven
Hi Michael, Thanks for your reply! I have done a little more research; details are below. Michael Van Canneyt wrote: On Mon, 12 Feb 2007, Bram Kuijvenhoven wrote: The Base64 decoding stream in the Base64 unit in the FCL appears to be broken. In particular - it does not handle whitespace (or

Re: [fpc-devel] Base64 decoding stream in the FCL

2007-02-12 Thread Michael Van Canneyt
On Mon, 12 Feb 2007, Bram Kuijvenhoven wrote: > Hi list! > > The Base64 decoding stream in the Base64 unit in the FCL appears to be broken. > In particular > - it does not handle whitespace (or other characters not from the bas64 > alphabet), and It was not designed to do this. > - Read does

[fpc-devel] Base64 decoding stream in the FCL

2007-02-12 Thread Bram Kuijvenhoven
Hi list! The Base64 decoding stream in the Base64 unit in the FCL appears to be broken. In particular - it does not handle whitespace (or other characters not from the bas64 alphabet), and - Read does not return the correct number of bytes read when at the end of the stream, and - the meaning