Re: [fpc-devel] JWA 64-bit struct packing

2020-05-16 Thread Henry Vermaak via fpc-devel
On Thu, 14 May 2020 at 22:48, Marco van de Voort wrote: > Those are probably the exceptions then. But jwa* is delphi compat, so > can't use $PUSH/$POP, so changing defaults is less useful, since it will > be undone at the first exception What's even worse is that SetEntriesInAcl() was still crash

Re: [fpc-devel] JWA 64-bit struct packing

2020-05-14 Thread Marco van de Voort
Op 2020-05-14 om 17:03 schreef Henry Vermaak via fpc-devel: The original headers only did 32-bit. Over the years some 64-bit corrections have been added. This process is ongoing, so please make sure you use the newest version. Grepping for align|packrecords give exactly the same results in trun

Re: [fpc-devel] JWA 64-bit struct packing

2020-05-14 Thread Henry Vermaak via fpc-devel
On Thu, 14 May 2020 at 16:03, Henry Vermaak wrote: > So why is rtl/win*/* full of packrecords c? These pages say that the > Windows API expect 8: > > https://docs.microsoft.com/en-us/windows/win32/winprog/using-the-windows-headers#controlling-structure-packing > https://docs.microsoft.com/en-gb/

Re: [fpc-devel] JWA 64-bit struct packing

2020-05-14 Thread Henry Vermaak via fpc-devel
On Thu, 14 May 2020 at 15:22, Marco van de Voort wrote: > The original headers only did 32-bit. Over the years some 64-bit > corrections have been added. This process is ongoing, so please make > sure you use the newest version. Grepping for align|packrecords give exactly the same results in trun

Re: [fpc-devel] JWA 64-bit struct packing

2020-05-14 Thread Marco van de Voort
Op 2020-05-14 om 15:53 schreef Henry Vermaak via fpc-devel: I'm having some crashes and errors from 64-bit Windows builds that use the JWA units. I've tracked it down to record alignment (the 32-bit version works fine, so it's the first place I looked). I notice that there's no {$packrecords c

[fpc-devel] JWA 64-bit struct packing

2020-05-14 Thread Henry Vermaak via fpc-devel
I'm having some crashes and errors from 64-bit Windows builds that use the JWA units. I've tracked it down to record alignment (the 32-bit version works fine, so it's the first place I looked). I notice that there's no {$packrecords c} anywhere (or alternatively {$align 8} for 64-bit). Am I miss