Re: [fpc-devel] Patch to remove useless bookmark store in TDataset.DoInsertAppend

2005-07-25 Thread Joost van der Sluis
On Sat, 2005-07-23 at 18:14 -0300, Luiz Américo wrote: As already commented in the code, the bookmarking done inside TDataset.DoInsertAppend is useless, not to say buggy. It makes 2 records to have the same bookmark data but this is not noticed because the bookmarkdata is set to the correct

Re: [fpc-devel] Patch to remove useless bookmark store in TDataset.DoInsertAppend

2005-07-25 Thread Alexandrov Alexandru
On 7/24/05, Luiz Américo [EMAIL PROTECTED] wrote: As already commented in the code, the bookmarking done inside TDataset.DoInsertAppend is useless, not to say buggy. It makes 2 records to have the same bookmark data but this is not noticed because the bookmarkdata is set to the correct value

[fpc-devel] Win32 sockets patch

2005-07-25 Thread Ales Katona
There is an ugly type bug in win32 sockets.pp. This patch fixes it. ssize_t = cuint16 -- this caused a bug with fprecv/fprecvfrom and fpsend/fpsendto calls because winsock.recv[from]/winsock.send[to] calls return a longint while fprecv used an unsigned int as return value. This caused the