Re: [fpc-devel] A note on Mantis issue 13173
Sergei Gorelkin schrieb: Hello, Looking at the changes to rtl/win/tthread.inc made in r12761, I see that 'thread helper window' is pretty well unused, as CM_EXECPROC message is never posted to it (grepping rtl sources for CM_EXECPROC shows that). So maybe ThreadWndProc function and window creation/destruction code in AddThread and RemoveThread procedures should be removed? Better add this to the bug report itself. ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] A note on Mantis issue 13173
Sergei Gorelkin wrote: Looking at the changes to rtl/win/tthread.inc made in r12761, I see that 'thread helper window' is pretty well unused, as CM_EXECPROC message is never posted to it (grepping rtl sources for CM_EXECPROC shows that). TThread.Synchronize is supposed to use it. Micha ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] A note on Mantis issue 13173
Florian Klaempfl wrote: Sergei Gorelkin schrieb: Hello, Looking at the changes to rtl/win/tthread.inc made in r12761, I see that 'thread helper window' is pretty well unused, as CM_EXECPROC message is never posted to it (grepping rtl sources for CM_EXECPROC shows that). So maybe ThreadWndProc function and window creation/destruction code in AddThread and RemoveThread procedures should be removed? Better add this to the bug report itself. Unfortunately, it isn't possible to add anything to the bug report once it is resolved. That's why I wrote here. Sergei ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] A note on Mantis issue 13173
Micha Nelissen wrote: Sergei Gorelkin wrote: Looking at the changes to rtl/win/tthread.inc made in r12761, I see that 'thread helper window' is pretty well unused, as CM_EXECPROC message is never posted to it (grepping rtl sources for CM_EXECPROC shows that). TThread.Synchronize is supposed to use it. It probably was so a while ago, but the current implementation uses a platform-independent mechanism (TThread.Synchronize is entirely in rtl/objpas/classes/classes.inc). Regards, Sergei ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] A note on Mantis issue 13173
Sergei Gorelkin wrote: TThread.Synchronize is supposed to use it. It probably was so a while ago, but the current implementation uses a platform-independent mechanism (TThread.Synchronize is entirely in rtl/objpas/classes/classes.inc). Oops, didn't I write that? Good catch. Micha ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
