Re: [fpc-devel] fpc compiler wrong encoding in console output on Windows

2023-08-31 Thread Tomas Hajny via fpc-devel
On 2023-08-31 18:19, Ondrej Pokorny via fpc-devel wrote: On 31.08.2023 17:54, Tomas Hajny via fpc-devel wrote: . . 2) Always use the ansistring version when parsing the comments. Obviously, this increases compilation time for directives parsing somewhat - we could possibly measure the

Re: [fpc-devel] fpc compiler wrong encoding in console output on Windows

2023-08-31 Thread Ondrej Pokorny via fpc-devel
On 31.08.2023 17:54, Tomas Hajny via fpc-devel wrote: On 2023-08-31 17:08, Ondrej Pokorny via fpc-devel wrote: :) We are not at the finish yet. Positive outcome will be when it gets fixed in the compiler source. Yes, I know. I checked your patch briefly now and I don't like the fact that it

Re: [fpc-devel] fpc compiler wrong encoding in console output on Windows

2023-08-31 Thread Tomas Hajny via fpc-devel
On 2023-08-31 17:08, Ondrej Pokorny via fpc-devel wrote: . . :) We are not at the finish yet. Positive outcome will be when it gets fixed in the compiler source. Yes, I know. I checked your patch briefly now and I don't like the fact that it basically duplicates the code of the two original

Re: [fpc-devel] fpc compiler wrong encoding in console output on Windows

2023-08-31 Thread Ondrej Pokorny via fpc-devel
Am 31.08.2023 um 9:59 schrieb Tomas Hajny via fpc-devel: On 2023-08-30 23:38, Ondrej Pokorny via fpc-devel wrote: Am 30.08.2023 um 20:21 schrieb Ondrej Pokorny via fpc-devel: Having seen the outputs, I think that the compiler just ignores the source file encoding for {$MESSAGE} and {$NOTE}. It

Re: [fpc-devel] fpc compiler wrong encoding in console output on Windows

2023-08-31 Thread Tomas Hajny via fpc-devel
On 2023-08-30 23:38, Ondrej Pokorny via fpc-devel wrote: Am 30.08.2023 um 20:21 schrieb Ondrej Pokorny via fpc-devel: . . Having seen the outputs, I think that the compiler just ignores the source file encoding for {$MESSAGE} and {$NOTE}. It reads them always as ANSI and then converts them