Re: [fpc-devel] Two issues with variant type definitions

2010-11-11 Thread Florian Klaempfl
Am 11.11.2010 15:19, schrieb Sergei Gorelkin:
 Hello,
 
 Two questions I wanted to ask:
 
 1) There are two variant type defintions (varxxx constants): one in
 compiler/symdef.pas, another one in rtl/inc/varianth.inc. Worse, they
 are out of sync. Is it really necessary to have a separate set of these
 definitions in compiler?

Previously we always decided to keep two separate files, see e.g.
fpcinnr.inc and innr.inc, so I'd prefer just to update the compiler one.

 
 2) In FPC, varunicodestr=22 (in symdef.pas), while Delphi defines
 varUString=$102. Although meaning of these types are a bit different in
 FPC and Delphi, probably we should change varunicodestr in range  256,
 because values below 256 are used for types that are known to COM.
 Are there objections/opinions on doing so?

No.
___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-devel


Re: [fpc-devel] Two issues with variant type definitions

2010-11-11 Thread Sergei Gorelkin

Florian Klaempfl пишет:

Am 11.11.2010 15:19, schrieb Sergei Gorelkin:

Hello,

Two questions I wanted to ask:

1) There are two variant type defintions (varxxx constants): one in
compiler/symdef.pas, another one in rtl/inc/varianth.inc. Worse, they
are out of sync. Is it really necessary to have a separate set of these
definitions in compiler?


Previously we always decided to keep two separate files, see e.g.
fpcinnr.inc and innr.inc, so I'd prefer just to update the compiler one.


Ok, I'll then add comments reminding to update another copy in sync.

Sergei
___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-devel