[Framework-Team] Re: Can I merge plone.memoize and plone.app.layout?

2006-12-04 Thread Florian Schulze
On Sun, 03 Dec 2006 14:01:50 +0100, Martin Aspeli  
[EMAIL PROTECTED] wrote:



Hi guys,

Following discussions with Whit, Alec and Rocky on the channel last  
night, and from the lists before, I've created and checked in two  
packages:


  - plone.memoize: contains Whit's memojito memoization decorators (in  
plone.memoize.instance), and a variant of it that memoizes values in the  
request for views (plone.memoize.view).


  - plone.app.layout: contains a view viewlet manager definitions  
(plone.app.layout.viewlets) and a set of views that contain several of  
the values from global_defines, but cleaned up  
(plone.app.layout.globals). These are memoized using the view  
memoization in plone.memoize.



[snip]


Is this OK?

Martin





Hi!

I did no benchmarks yet, but it feels quite a bit faster now. Did anyone  
do some before after comparisons?


Regards,
Florian Schulze


___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team


[Framework-Team] Re: Can I merge plone.memoize and plone.app.layout?

2006-12-04 Thread Hanno Schlichting
Hi.

Hanno Schlichting wrote:
 
 Plone 2.5 branch - 5 requests/sec
 Plone 3.0 some days ago - 3.5 requests/sec
 Plone 3.0 right now - 4.0 requests/sec
 
 Plone 3.0 without old-style portlets - 6.0 requests/sec

And as another reference:

Plone 2.1 branch - 5.7 requests/sec

Hanno

P.S. I used ab -n 100 http://127.0.0.1/plonesite; to get all those numbers.


___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team


Re: [Framework-Team] Re: Can I merge plone.memoize and plone.app.layout?

2006-12-04 Thread Martin Aspeli

Hanno Schlichting wrote:

Florian Schulze wrote:

Hi!

I did no benchmarks yet, but it feels quite a bit faster now. Did anyone
do some before after comparisons?


Yep, I did some very basic benchmarks (ab, ZopeProfiler, PTProfiler).
For the front-page for an anonymous user the rough numbers were:

Plone 2.5 trunk - 5 requests/sec
Plone 3.0 some days ago - 3.5 requests/sec
Plone 3.0 right now - 4.0 requests/sec

Plone 3.0 without old-style portlets - 6.0 requests/sec


Yay!


And as a reference:

Zope 2.10 front-page - 180 requests/sec ;)

So right now one easy way of getting some more performance is to turn
the remaining old-style portlets into new-style ones.


This will happen, it's mostly just manual work. The only hard one 
remaining is the calendar one, plus I want to make some new portlets 
altogether, like a Document renderer and a Smart Folder renderer.


The only annoying one left of the old ones is the Calendar portlet.

Also, as I said, some of the portlet lookup is sub-optimal now and will 
benefit from cacheing.



The plone.app.globals approach should allow us to optimize the
performance in some more places, so I think we are starting to see the
blessings of using Zope3 on the performance side as well ;)


Yay :)

Martin

___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team


Re: [Framework-Team] Re: Can I merge plone.memoize and plone.app.layout?

2006-12-04 Thread Hanno Schlichting
Martin Aspeli wrote:
 Hanno Schlichting wrote:

 So right now one easy way of getting some more performance is to turn
 the remaining old-style portlets into new-style ones.
 
 This will happen, it's mostly just manual work. The only hard one
 remaining is the calendar one, plus I want to make some new portlets
 altogether, like a Document renderer and a Smart Folder renderer.
 
 The only annoying one left of the old ones is the Calendar portlet.

I started to work on that one this morning on my train ride, as I
already have a quite intimate relationship to that code ;)

Hanno

___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team


Re: [Framework-Team] Re: Can I merge plone.memoize and plone.app.layout?

2006-12-04 Thread Martin Aspeli

Hanno Schlichting wrote:

Martin Aspeli wrote:

Hanno Schlichting wrote:

So right now one easy way of getting some more performance is to turn
the remaining old-style portlets into new-style ones.

This will happen, it's mostly just manual work. The only hard one
remaining is the calendar one, plus I want to make some new portlets
altogether, like a Document renderer and a Smart Folder renderer.

The only annoying one left of the old ones is the Calendar portlet.


I started to work on that one this morning on my train ride, as I
already have a quite intimate relationship to that code ;)


Ah, you're my hero :)

Btw, Hanno, the CMFPlone.browser.controlpanel stuff is awesome. Didn't 
see that go in. :)


Perhaps we should move it to plone.app.controlpanel, though? I'm a bit 
worried about CMFPlone.browser becoming as big as CMFPlone/skins :)


Martin

___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team


[Framework-Team] Re: Re: Can I merge plone.memoize and plone.app.layout?

2006-12-04 Thread Alexander Limi
On Mon, 04 Dec 2006 10:47:37 -0800, Martin Aspeli  
[EMAIL PROTECTED] wrote:


Perhaps we should move it to plone.app.controlpanel, though? I'm a bit  
worried about CMFPlone.browser becoming as big as CMFPlone/skins


+1. The control panel stuff deserves its own space, and will hopefully be  
expanded a lot in the near future (the goal is that site admins should  
never have to visit the ZMI unless they want to do very esoteric things).


--
_

 Alexander Limi · Chief Architect · Plone Solutions · Norway

 Consulting · Training · Development · http://www.plonesolutions.com
_

  Plone Co-Founder · http://plone.org · Connecting Content
  Plone Foundation · http://plone.org/foundation · Protecting Plone



___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team