Re: [Framework-Team] Re: Re: PLIP 212 ready for review

2008-02-15 Thread Tom Lazar
On Feb 14, 2008, at 1:57 PM, Florian Schulze wrote: On Wed, 13 Feb 2008 20:20:40 +0100, Tom Lazar [EMAIL PROTECTED] wrote: On 12.02.2008, at 23:41, Florian Schulze wrote: instead i got the following error in jquery.js (via firebug) a is not a function [Break on this error]

Re: [Framework-Team] PLIP 213 ready for review

2008-02-15 Thread Tom Lazar
On Jan 19, 2008, at 6:48 PM, Florian Schulze wrote: Hi! The buildout is at https://svn.plone.org/svn/plone/review/plip213-syndication-preps Notes are in the buildout. I guess this is the smallest PLIP of all :) yay, a nice small plip. it certainly works nicely during my clicktests.

Re: [Framework-Team] PLIP 213 ready for review

2008-02-15 Thread Wichert Akkerman
Previously Tom Lazar wrote: however, i have one problem, which is more svn-kungfoo related than to this plip. given the branch you've cut of CMFPlone https://dev.plone.org/plone/browser/CMFPlone/branches/plip213-syndication-preps how can i single out the changeset that you have done? i'd

Re: [Framework-Team] PLIP 213 ready for review

2008-02-15 Thread Tom Lazar
On 15.02.2008, at 11:34, Wichert Akkerman wrote: Previously Tom Lazar wrote: however, i have one problem, which is more svn-kungfoo related than to this plip. given the branch you've cut of CMFPlone https://dev.plone.org/plone/browser/CMFPlone/branches/plip213-syndication-preps how can i

[Framework-Team] Re: Re: Re: PLIP 212 ready for review

2008-02-15 Thread Florian Schulze
On Fri, 15 Feb 2008 11:10:42 +0100, Tom Lazar [EMAIL PROTECTED] wrote: Unhandled error during command execution: ReferenceError: initializeMenus is not defined++resource++kukit... (line 144) initializeMenus is not defined (no name)(Object node=ul#contentActionMenus parms=Object)++resource+

Re: [Framework-Team] Re: Re: PLIP 212 ready for review

2008-02-15 Thread Tom Lazar
i'm happy to report that all remaining issues have been fixed by florian today. the reason that my findings were not immediately reproducible, turned out to be because they were triggered by KSS interactions, i.e. only if you previously had, for instance, performed a copy operation andthen

Re: [Framework-Team] PLIP 213 ready for review

2008-02-15 Thread Tom Lazar
after looking at the diffs -- :-) -- i'd hereby like to cast my approval of this plip, as well. On 19.01.2008, at 18:48, Florian Schulze wrote: Hi! The buildout is at https://svn.plone.org/svn/plone/review/plip213-syndication-preps Notes are in the buildout. I guess this is the smallest

Re: [Framework-Team] Re: Re: PLIP 212 ready for review

2008-02-15 Thread Tom Lazar
On 15.02.2008, at 11:56, Wichert Akkerman wrote: Previously Tom Lazar wrote: On Feb 14, 2008, at 1:57 PM, Florian Schulze wrote: I can't reproduce any of these issues. I tried my exisiting buildout and I made a fresh co of the buildout and ran buildout with the option to get the newest

[Framework-Team] Re: buildout error for plip215

2008-02-15 Thread Maurits van Rees
Tom Lazar, on 2008-02-15: hi ree, thanks for the quick reply! it turns out, that my ~/.buildout/default.cfg was the culprit, where i had activated the new ppix index on advice from reinout[1]: index = http://download.zope.org/ppix after removing that the buildout works fine, sorry for

[Framework-Team] My conclusion regarding 201 (USW)

2008-02-15 Thread Danny Bloemendaal
Today Florian made some changes to überselectionwidget to use the same pattern as Mac OS Finder's column view and it rocks and I really think that this is the way how it should work. Add search, good mouse/ keyboard navigation, object details etc to it and you have a very powerful and easy

Re: [Framework-Team] PLIP 224: CSRF protection framework

2008-02-15 Thread Andreas Zeidler
On Jan 31, 2008, at 10:15 PM, Andreas Zeidler wrote: in contrary to my statement regarding the other reviews, i.e. that two review ought to do (considering how late we are already), in this case it should be: the more, the merrier. hence, i'd offer to do a review as well and i'd suggest

Re: [Framework-Team] Re: Updated PLIP review deadline

2008-02-15 Thread Andreas Zeidler
On Feb 14, 2008, at 12:05 PM, Martin Aspeli wrote: I still don't think this makes any sense. hi martin, since you've sent that mail to: me and i'm also the spokesperson of the framework team, i'll try to respond to a few bits. i don't really want to repeat everything i've said before,

[Framework-Team] Re: [Plone-developers] scope of reviews was: Re: Updated PLIP review deadline

2008-02-15 Thread Alexander Limi
On Fri, 15 Feb 2008 15:57:54 -0800, Andreas Zeidler [EMAIL PROTECTED] wrote: that stuff can amount to some serious time, i can tell you. indeed, mine took me something between two and four or maybe even five hours each. That would be a great things to have written down and communicated to