[PLIP-Advisories] Re: [Plone] #9309: Better search for East Asian (multi-byte) languages.
#9309: Better search for East Asian (multi-byte) languages. -+-- Reporter: terapyon |Owner: terapyon Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: search splitter CJK | -+-- Comment(by terapyon): (In [30565]) merging PLIP9309 refs #9309 -- Ticket URL: http://dev.plone.org/plone/ticket/9309#comment:52 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9309: Better search for East Asian (multi-byte) languages.
#9309: Better search for East Asian (multi-byte) languages. -+-- Reporter: terapyon |Owner: terapyon Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: search splitter CJK | -+-- Comment(by tyam): (In [30502]) Changed cfg since Zope code merged to 2.12. refs #9309 -- Ticket URL: http://dev.plone.org/plone/ticket/9309#comment:49 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9309: Better search for East Asian (multi-byte) languages.
#9309: Better search for East Asian (multi-byte) languages. -+-- Reporter: terapyon |Owner: terapyon Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: search splitter CJK | -+-- Comment(by esteele): (In [30540]) Use the Zope 2.12 branch. PLIP #9309 will need it. This auto- checkout can be removed once we have a 2.12.1 available. Refs #9309. -- Ticket URL: http://dev.plone.org/plone/ticket/9309#comment:51 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9309: Better search for East Asian (multi-byte) languages.
#9309: Better search for East Asian (multi-byte) languages. -+-- Reporter: terapyon |Owner: terapyon Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: search splitter CJK | -+-- Comment(by esteele): This PLIP has been accepted for merging into Plone 4.0 The final vote was: Alec Mitchell +1 David Glick +1 Erik Rose - Laurence Rowe +1 Matthew Wilkes +1 Ross Patterson +1 Please merge your branches into the Plone 4.0 head by end-of-day Friday Oct 16. If you need assistance with merging, please contact me. We'll be assigning a documentation ticket to this PLIP shortly. Please assist the docs team in documenting the changes and new features that this PLIP introduces. -- Ticket URL: http://dev.plone.org/plone/ticket/9309#comment:47 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9309: Better search for East Asian (multi-byte) languages.
#9309: Better search for East Asian (multi-byte) languages. -+-- Reporter: terapyon |Owner: terapyon Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: search splitter CJK | -+-- Comment(by rossp): Seems like the issues have been addressed. FWT vote: +1 for merge -- Ticket URL: http://dev.plone.org/plone/ticket/9309#comment:46 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9309: Better search for East Asian (multi-byte) languages.
#9309: Better search for East Asian (multi-byte) languages. -+-- Reporter: terapyon |Owner: terapyon Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: search splitter CJK | -+-- Comment(by matthewwilkes): (In [30234]) Merge review for Unicode Splitter plip, refs #9309. FWT Vote is now +1 -- Ticket URL: http://dev.plone.org/plone/ticket/9309#comment:44 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9309: Better search for East Asian (multi-byte) languages.
#9309: Better search for East Asian (multi-byte) languages. -+-- Reporter: terapyon |Owner: terapyon Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: search splitter CJK | -+-- Comment(by vincentfretin): I removed src/Plone, did buildout again and I don't have errors anymore, only the 3 existing failures (two in testUnicodeSplitter.py, and 1 in mails.txt) -- Ticket URL: http://dev.plone.org/plone/ticket/9309#comment:39 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9309: Better search for East Asian (multi-byte) languages.
#9309: Better search for East Asian (multi-byte) languages. -+-- Reporter: terapyon |Owner: terapyon Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: search splitter CJK | -+-- Comment(by vincentfretin): (In [30172]) I don't have errors anymore, strange. (refs #9309) -- Ticket URL: http://dev.plone.org/plone/ticket/9309#comment:40 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9309: Better search for East Asian (multi-byte) languages.
#9309: Better search for East Asian (multi-byte) languages. -+-- Reporter: terapyon |Owner: terapyon Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: search splitter CJK | -+-- Comment(by terapyon): Replying to [comment:39 vincentfretin]: I removed src/Plone, did buildout again and I don't have errors anymore, only the 3 existing failures (two in testUnicodeSplitter.py, and 1 in mails.txt) Please let me know detail of errors. -- Ticket URL: http://dev.plone.org/plone/ticket/9309#comment:41 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9309: Better search for East Asian (multi-byte) languages.
#9309: Better search for East Asian (multi-byte) languages.
-+--
Reporter: terapyon |Owner: terapyon
Type: PLIP | Status: assigned
Priority: minor|Milestone: 4.0
Component: Unknown | Resolution:
Keywords: search splitter CJK |
-+--
Comment(by vincentfretin):
The 3 failures exist in the Plone/branches/4.0 too.
{{{
Failure in test testProcessLatin1
(Products.CMFPlone.tests.testUnicodeSplitter.TestSplitter)
Traceback (most recent call last):
File /usr/lib/python2.6/unittest.py, line 279, in run
testMethod()
File /home/vincentfretin/svn/plone-
coredev/branches/4.0/src/Plone/Products/CMFPlone/tests/testUnicodeSplitter.py,
line 90, in testProcessLatin1
self.assertEqual(self.process(input), output)
File /usr/lib/python2.6/unittest.py, line 350, in failUnlessEqual
(msg or '%r != %r' % (first, second))
AssertionError: ['ffin', 'foo'] != ['\xc4ffin', 'foo']
...
Failure in test testNormalizeLatin1
(Products.CMFPlone.tests.testUnicodeSplitter.TestCaseNormalizer)
Traceback (most recent call last):
File /usr/lib/python2.6/unittest.py, line 279, in run
testMethod()
File /home/vincentfretin/svn/plone-
coredev/branches/4.0/src/Plone/Products/CMFPlone/tests/testUnicodeSplitter.py,
line 123, in testNormalizeLatin1
self.assertEqual(self.process(input), output)
File /usr/lib/python2.6/unittest.py, line 350, in failUnlessEqual
(msg or '%r != %r' % (first, second))
AssertionError: ['\xc4ffin'] != ['\xe4ffin']
.
Failure in test /home/vincentfretin/svn/plone-
coredev/branches/4.0/src/Plone/Products/CMFPlone/tests/mails.txt
Failed doctest test for mails.txt
File /home/vincentfretin/svn/plone-
coredev/branches/4.0/src/Plone/Products/CMFPlone/tests/mails.txt, line 0
--
File /home/vincentfretin/svn/plone-
coredev/branches/4.0/src/Plone/Products/CMFPlone/tests/mails.txt, line
57, in mails.txt
Failed example:
b64decode(msg.message.get_payload())
Expected:
'...You are receiving this mail because T\xc3\xa4st
user\nt...@plone.test...is sending feedback about the site administered by
you at...The message sent was:...Another t\xc3\xa4st message...
Got:
'b\x8b\x9a\xad\xea\xdeq\xe8\xaf\x8ax-\x86+j)[y\xc6\xae\xb1\xe4'
Ran 1067 tests with 3 failures and 0 errors in 4 minutes 15.573 seconds.
Running zope.testing.testrunner.layer.UnitTests tests:
Tear down Products.PloneTestCase.layer.PloneSite in 0.545 seconds.
Tear down Products.PloneTestCase.layer.ZCML in 0.027 seconds.
Tear down Testing.ZopeTestCase.layer.ZopeLite in 0.000 seconds.
Set up zope.testing.testrunner.layer.UnitTests in 0.000 seconds.
Running:
..
Ran 34 tests with 0 failures and 0 errors in 0.050 seconds.
Tearing down left over layers:
Tear down zope.testing.testrunner.layer.UnitTests in 0.000 seconds.
Tests with failures:
testProcessLatin1
(Products.CMFPlone.tests.testUnicodeSplitter.TestSplitter)
testNormalizeLatin1
(Products.CMFPlone.tests.testUnicodeSplitter.TestCaseNormalizer)
/home/vincentfretin/svn/plone-
coredev/branches/4.0/src/Plone/Products/CMFPlone/tests/mails.txt
Total: 1239 tests, 3 failures, 0 errors in 4 minutes 36.844 seconds.
}}}
--
Ticket URL: http://dev.plone.org/plone/ticket/9309#comment:42
Plone http://plone.org
Plone Content Management System
___
PLIP-Advisories mailing list
plip-advisor...@lists.plone.org
http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9309: Better search for East Asian (multi-byte) languages.
#9309: Better search for East Asian (multi-byte) languages. -+-- Reporter: terapyon |Owner: terapyon Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: search splitter CJK | -+-- Comment(by terapyon): Replying to [comment:42 vincentfretin]: The 3 failures exist in the Plone/branches/4.0 too. Thank you for sending me error logs. I felt that test code tries to test very rare case scenario. And it always fail in a certain language circumstances. In my program, I use SiteEncoding to convert text to UNICODE. So, that test code makes problem, because Latin-1 exists in str and it only runs on locale.setlocale enable condition. -- Ticket URL: http://dev.plone.org/plone/ticket/9309#comment:43 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9309: Better search for East Asian (multi-byte) languages.
#9309: Better search for East Asian (multi-byte) languages. -+-- Reporter: terapyon |Owner: terapyon Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: search splitter CJK | -+-- Comment(by davisagli): Vincent's latest review says there are 8 failures when running the CMFPlone tests. I'm only seeing 3, and one of them is due to the mail host changes in Zope 2.12.0. The other two failures are in tests introduced by this PLIP, and while they should certainly be fixed, that's less worrisome than if this PLIP's changes were causing failures in existing tests. -- Ticket URL: http://dev.plone.org/plone/ticket/9309#comment:37 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9309: Better search for East Asian (multi-byte) languages.
#9309: Better search for East Asian (multi-byte) languages. -+-- Reporter: terapyon |Owner: terapyon Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: search splitter CJK | -+-- Comment(by davisagli): Never mind that last message; my buildout wasn't entirely up to date. Now it is, and I'm only seeing the mailhost-related test failure. -- Ticket URL: http://dev.plone.org/plone/ticket/9309#comment:38 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9309: Better search for East Asian (multi-byte) languages.
#9309: Better search for East Asian (multi-byte) languages. -+-- Reporter: terapyon |Owner: terapyon Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: search splitter CJK | -+-- Comment(by esteele): Your PLIP has passed the Framework team's initial review. Feel free to discuss any suggested changes either here in the PLIP ticket or on the mailing lists. Final deadline for this PLIP is set for September 30. -- Ticket URL: http://dev.plone.org/plone/ticket/9309#comment:20 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9309: Better search for East Asian (multi-byte) languages.
#9309: Better search for East Asian (multi-byte) languages. -+-- Reporter: terapyon |Owner: terapyon Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: search splitter CJK | -+-- Comment(by terapyon): Thank you for reviewing my code. 1) Don't use monkey patch. OK, I will create new branche on both Zope and Plone. 2) Broken livesearch. I think that problem is not cause by our code. In Plone 3.3.0, it was already broken. Then in Plone 3.3.1 it became functional. There must be some other code doing that. 3) UnicodeDecodeError and not using re.LOCALE I will modify my code to use re.LOCALE. But I have no idea, when and how to use it? 4) Performance As I see, performance of code comes after functional of code, isn't it? 5) Functions nameing and not docstrings. I will rename functions and write docstrings. 6) Using fuctions and args. I will modiry it. 7) Test coverage. OK, I will write additional tests after I have made regained change. 8) Don't use functions. I will check it. 9) Last. I and my development team should have finished revising old code by end of SEP. And I'm going to join on 21th Plone Tune-Up day from Japan. -- Ticket URL: http://dev.plone.org/plone/ticket/9309#comment:21 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9309: Better search for East Asian (multi-byte) languages.
#9309: Better search for East Asian (multi-byte) languages. -+-- Reporter: terapyon |Owner: terapyon Type: PLIP | Status: new Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: search splitter CJK | -+-- Comment(by tyam): (In [29594]) sitecustomize.py is NOT required anymore. refs #9309 -- Ticket URL: http://dev.plone.org/plone/ticket/9309#comment:16 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9309: Better search for East Asian (multi-byte) languages.
#9309: Better search for East Asian (multi-byte) languages. -+-- Reporter: terapyon |Owner: terapyon Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: search splitter CJK | -+-- Changes (by terapyon): * status: new = assigned -- Ticket URL: http://dev.plone.org/plone/ticket/9309#comment:17 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9309: Better search for East Asian (multi-byte) languages.
#9309: Better search for East Asian (multi-byte) languages. -+-- Reporter: terapyon |Owner: terapyon Type: PLIP | Status: new Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: search splitter CJK | -+-- Comment(by tyam): (In [29231]) Important sitecustomize.py info added. refs #9309 -- Ticket URL: http://dev.plone.org/plone/ticket/9309#comment:15 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9309: Better search for East Asian (multi-byte) languages.
#9309: Better search for East Asian (multi-byte) languages. -+-- Reporter: terapyon |Owner: terapyon Type: PLIP | Status: new Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: search splitter CJK | -+-- Comment(by tyam): (In [28851]) plip9309 cfg and txt added refs #9309 -- Ticket URL: http://dev.plone.org/plone/ticket/9309#comment:14 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9309: Better search for East Asian (multi-byte) languages.
#9309: Better search for East Asian (multi-byte) languages. -+-- Reporter: terapyon |Owner: terapyon Type: PLIP | Status: new Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: search splitter CJK | -+-- Comment(by terapyon): My coding as almost finish. [94068] in svn/collective. https://dev.plone.org/collective/browser/Products.UnicodeSplitterPatch/branches/PLIP9309 -- Ticket URL: http://dev.plone.org/plone/ticket/9309#comment:13 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9309: Better search for East Asian (multi-byte) languages.
#9309: Better search for East Asian (multi-byte) languages. -+-- Reporter: terapyon |Owner: terapyon Type: PLIP | Status: new Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: search splitter CJK | -+-- Changes (by esteele): * owner: = terapyon -- Ticket URL: http://dev.plone.org/plone/ticket/9309#comment:12 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9309: Better search for East Asian (multi-byte) languages.
#9309: Better search for East Asian (multi-byte) languages. -+-- Reporter: terapyon |Owner: Type: PLIP | Status: new Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: search splitter CJK | -+-- Comment(by esteele): Approved by FWT vote. -- Ticket URL: https://dev.plone.org/plone/ticket/9309#comment:11 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9309: Better search for East Asian (multi-byte) languages.
#9309: Better search for East Asian (multi-byte) languages. -+-- Reporter: terapyon |Owner: Type: PLIP | Status: new Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: search splitter CJK | -+-- Comment(by calvinhp): FWT Vote: +1 with the updated PLIP to include more detail -- Ticket URL: https://dev.plone.org/old/plone/ticket/9309#comment:10 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
