Re: [Framework-Team] Re: pyflakes? (was: Re: Translation effort for Plone 3.1)
On Feb 1, 2008, at 3:29 PM, Florian Schulze wrote: On Fri, 01 Feb 2008 14:34:01 +0100, Andreas Zeidler <[EMAIL PROTECTED]> wrote: so, how about this? deprecating imports in interface packages, which are not used in plone core, is okay as well as removing unused import from any other package? that's talking 4.0, of course... hmm, or maybe this could be a 3.2 PLIP, too, so we can deprecate things earlier. i mean, this policy shouldn't break anything provided all tests are passing. thoughts? I would deprecate ones which may be used in other packages for one major release and two major releases for the ones which affect persistent objects, because otherwise it's a pain to migrate. +1, but like i said in my previous post, i don't even think it'll be necessary to deprecate many or any for that matter of those. at least, it wasn't my original idea to take it too that point. i'd rather start and clean some things up once in a while than insisting to do everything at once (including those tricky parts) and potentially settle down again afterwards. to me this is more like an ongoing effort, and i guess i wanted to know what others think about it and what would be good and maybe not so good points in time to do it. having that said, i'd also be very much in favour of having something like "spring cleanups" or a sprint dedicated to simplifying and cleaning up code, or perhaps even a release. and of course, i'd very much like to hear your thoughts on that... :) andi -- zeidler it consulting - http://zitc.de/ - [EMAIL PROTECTED] friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.0.5 released! -- http://plone.org/products/plone PGP.sig Description: This is a digitally signed message part ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
[Framework-Team] Re: pyflakes? (was: Re: Translation effort for Plone 3.1)
On Fri, 01 Feb 2008 14:34:01 +0100, Andreas Zeidler <[EMAIL PROTECTED]> wrote: On Feb 1, 2008, at 2:24 PM, Wichert Akkerman wrote: Previously Tom Lazar wrote: given the aforementioned possibility of 3rd party breakage i think it's plain that 'pyflakes sanity' is a no-go for 3.1 but perhaps for 4.0? since that will necessitate 3rd party rewrites/adaptions anyway, might as well throw in pyflakes sanity, as well. You may need to properly deprecate things before removing them. hmm, unused imports? that might be a bit too much, no? i mean, i'd go ahead and remove any import statements i'm not using anymore in my packages, and that should be okay. imho, the only trouble are interface packages, otherwise people shouldn't import package a from package b anyway, but import it from a directly. so, how about this? deprecating imports in interface packages, which are not used in plone core, is okay as well as removing unused import from any other package? that's talking 4.0, of course... hmm, or maybe this could be a 3.2 PLIP, too, so we can deprecate things earlier. i mean, this policy shouldn't break anything provided all tests are passing. thoughts? I would deprecate ones which may be used in other packages for one major release and two major releases for the ones which affect persistent objects, because otherwise it's a pain to migrate. Regards, Florian Schulze ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
