Re: [Framework-Team] Re: wicked - lxml dependency?

2007-02-13 Thread whit

Rocky wrote:

Hanno Schlichting wrote:
  

Is lxml a real dependency for the functionality we use in Plone or is it
optional or only required to run the tests?



If lxml is not required (but can be used) by wicked then the tests
should reflect the same thing imho.  The tests should conditionally
test lxml only if available.

If the tests fail because lxml doesn't exist, then wicked itself
shouldn't work when deployed either without lxml.

- Rocky


___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team

  
they error, not fail(which is different). lxml is a tool for testing in 
this case.  the tests are old style unit tests and someday they will get 
rewritten in more modern forms.


the use lxml is primarily to make test output understandable by 
stripping out the whitespace created by TAL while testing the rendering 
of links (20 some tests, essentially AT/plone integration tests.  This 
suite is run twice, one to test basic setup, a second time to test the 
specialize plone registrations).  The dependency is on libxslt2-py or 
lxml.  wicked in no way uses lxml in it's actua function.


we could turn these tests off for systems without libxslt or lxml and 
emit a warning. if someone has a whitespace normalizing routine that is 
standard library friendly that would work too.


-w

--

-- d. whit morriss --
- senior engineer, opencore -
- http://www.openplans.org  -
- m: 415-710-8975   -

"If you don't know where you are,   
you don't know anything at all" 


Dr. Edgar Spencer, Ph.D., 1995

begin:vcard
fn:D. Whitfield  Morriss
n:Morriss;D. Whitfield 
org:The Open Planning Project;OpenPlans
adr:;;1309 Ashwood Ave;Nashville;TN;37212;USA
email;internet:[EMAIL PROTECTED]
title:Lead Developer 
tel;home:615 292-9142
tel;cell:415 710-8975
x-mozilla-html:FALSE
version:2.1
end:vcard

___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team


[Framework-Team] Re: wicked - lxml dependency?

2007-02-13 Thread Rocky
Hanno Schlichting wrote:
> Is lxml a real dependency for the functionality we use in Plone or is it
> optional or only required to run the tests?

If lxml is not required (but can be used) by wicked then the tests
should reflect the same thing imho.  The tests should conditionally
test lxml only if available.

If the tests fail because lxml doesn't exist, then wicked itself
shouldn't work when deployed either without lxml.

- Rocky


___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team


Re: [Framework-Team] Re: wicked - lxml dependency?

2007-02-13 Thread Sidnei da Silva

On 2/13/07, Hanno Schlichting <[EMAIL PROTECTED]> wrote:

Ah ok, great. I got lxml running on Windows (as there's a pre-built
binary release) and all tests did indeed pass.


Glad to see that my binaries are helping someone. :)

--
Sidnei da Silva
Enfold Systemshttp://enfoldsystems.com
Fax +1 832 201 8856 Office +1 713 942 2377 Ext 214

___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team


[Framework-Team] Re: wicked - lxml dependency?

2007-02-13 Thread Hanno Schlichting
whit wrote:
> Hanno Schlichting wrote:
>> Is lxml a real dependency for the functionality we use in Plone or is it
>> optional or only required to run the tests?
>>   
> it's used in the tests (to strip whitespace). iirc, any working version
> of libxml2 should work(both for the test and lxml, though lxml needs to
> be rather current).  lxml or libxml is not needed for any of wicked's
> functionality.

Ah ok, great. I got lxml running on Windows (as there's a pre-built
binary release) and all tests did indeed pass.

Thx for the clarification,
Hanno


___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team