Re: [Framework-Team] z3c.form PLIP?

2010-08-09 Thread Laurence Rowe
On 9 August 2010 01:52, Martin Aspeli optilude+li...@gmail.com wrote:
 Hi,

 On 8 August 2010 20:33, Hanno Schlichting ha...@hannosch.eu wrote:
 Hi.

 My controlpanel PLIP 10359 (http://dev.plone.org/plone/ticket/10359)
 depends on someone else doing the base work of getting z3c.form into
 4.1.

 There's a PLIP at http://dev.plone.org/plone/ticket/9473 for this, but
 currently nobody stepped forward to actually own it for 4.1.

 Are there any volunteers? Otherwise I'll have to withdraw my own PLIP.
 I'm not familiar enough with z3c.form and its Plone integration layers
 to own this base part.

 I can own this, although I'm not quite sure what a PLIP should look
 like? The actual work is in rewriting the control panel forms. The
 only thing the PLIP would say is ship with p.a.z3cform + dependencies
 as a dependency of PLIP 10359.

We already have: Include z3c.form - https://dev.plone.org/plone/ticket/9473

And also: Include plone.app.registry - https://dev.plone.org/plone/ticket/9472

I've assigned them over to you.

Laurence
___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team


Re: [Framework-Team] z3c.form PLIP?

2010-08-09 Thread Hanno Schlichting
On Mon, Aug 9, 2010 at 12:45 PM, Laurence Rowe l...@lrowe.co.uk wrote:
 On 9 August 2010 01:52, Martin Aspeli optilude+li...@gmail.com wrote:
 I can own this, although I'm not quite sure what a PLIP should look
 like? The actual work is in rewriting the control panel forms. The
 only thing the PLIP would say is ship with p.a.z3cform + dependencies
 as a dependency of PLIP 10359.

 We already have: Include z3c.form - https://dev.plone.org/plone/ticket/9473

Thanks, I was referring to that one and the points it lists.

I think the code for this one is basically done. But it needs a code
review, needs a review from the UI team on usability of the widgets
and the generated markup. There's also translation and documentation
to be updated. Someone knowing the code needs to act as a contact
person for these things.

I would also love to see someone bring some stability into the
plone.z3cform and plone.app.z3cform packages and release proper 1.0
releases. All the last minor have been backwards incompatible with
changes in the form wrapping approach (plone.app.discussion has been
one victim of this, always having to pin versions to one exact
combination at a time). We cannot do that any longer when these things
are part of Plone.

Hanno
___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team


Re: [Framework-Team] z3c.form PLIP?

2010-08-09 Thread Martin Aspeli
On 9 August 2010 21:31, Hanno Schlichting ha...@hannosch.eu wrote:
 On Mon, Aug 9, 2010 at 12:45 PM, Laurence Rowe l...@lrowe.co.uk wrote:
 On 9 August 2010 01:52, Martin Aspeli optilude+li...@gmail.com wrote:
 I can own this, although I'm not quite sure what a PLIP should look
 like? The actual work is in rewriting the control panel forms. The
 only thing the PLIP would say is ship with p.a.z3cform + dependencies
 as a dependency of PLIP 10359.

 We already have: Include z3c.form - https://dev.plone.org/plone/ticket/9473

 Thanks, I was referring to that one and the points it lists.

 I think the code for this one is basically done. But it needs a code
 review, needs a review from the UI team on usability of the widgets
 and the generated markup. There's also translation and documentation
 to be updated. Someone knowing the code needs to act as a contact
 person for these things.

I can help with the plone.z3cform and plone.app.z3cform aspects at
least. If specific work needs to go into widgets and markup, I'll need
support with that. I'd be really surprised if the basic widgets were
any worse than formlib, though. :)

 I would also love to see someone bring some stability into the
 plone.z3cform and plone.app.z3cform packages and release proper 1.0
 releases. All the last minor have been backwards incompatible with
 changes in the form wrapping approach (plone.app.discussion has been
 one victim of this, always having to pin versions to one exact
 combination at a time). We cannot do that any longer when these things
 are part of Plone.

That's a shame - and basically a bug. It was meant to be fully
backwards compatible. The change was somewhat painful, but necessary
to bring some sanity to the way we do templates and template
overrides, and making the forms more like regular views and easier to
work with. I think the form wrapping thing was always a mistake, but
then hindsight is a wonderful thing. :)

Martin
___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team


Re: [Framework-Team] z3c.form PLIP?

2010-08-08 Thread Martin Aspeli
Hi,

On 8 August 2010 20:33, Hanno Schlichting ha...@hannosch.eu wrote:
 Hi.

 My controlpanel PLIP 10359 (http://dev.plone.org/plone/ticket/10359)
 depends on someone else doing the base work of getting z3c.form into
 4.1.

 There's a PLIP at http://dev.plone.org/plone/ticket/9473 for this, but
 currently nobody stepped forward to actually own it for 4.1.

 Are there any volunteers? Otherwise I'll have to withdraw my own PLIP.
 I'm not familiar enough with z3c.form and its Plone integration layers
 to own this base part.

I can own this, although I'm not quite sure what a PLIP should look
like? The actual work is in rewriting the control panel forms. The
only thing the PLIP would say is ship with p.a.z3cform + dependencies
as a dependency of PLIP 10359.

Martin
___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team