Re: [PLIP-Advisories] [Plone development workspace] #10959: API for password validation policy

[Change notifications for Plone PLIPs on Trac.]

#10959: API for password validation policy
---+---
  Reporter:  djay  |  Owner:
  Type:  PLIP  | Status:  confirmed
  Priority:  minor |  Milestone:  4.3
 Component:  Backend (Python)  |Version:  4.1
Resolution:|   Keywords:
---+---

Comment (by djay):

 it would be useful to get some feedback from the FWT if they want me to
 proceed with this PLIP or not. If they do, then I'll need a mentor who can
 give me advise on how to make it acceptable to the FWT.

-- 
Ticket URL: 
Plone development workspace 
Plone Enterprise Content Management System
___
PLIP-Advisories mailing list
plip-advisor...@lists.plone.org
https://lists.plone.org/mailman/listinfo/plone-plip-advisories

Re: [PLIP-Advisories] [Plone development workspace] #10959: API for password validation policy

[Change notifications for Plone PLIPs on Trac.]

#10959: API for password validation policy
---+---
  Reporter:  djay  |  Owner:
  Type:  PLIP  | Status:  confirmed
  Priority:  minor |  Milestone:  4.3
 Component:  Backend (Python)  |Version:  4.1
Resolution:|   Keywords:
---+---

Comment (by mitchell):

 Sounds good to me. I haven't made much progress since the proposal, so
 happy to defer to Dylan.

-- 
Ticket URL: 
Plone development workspace 
Plone Enterprise Content Management System
___
PLIP-Advisories mailing list
plip-advisor...@lists.plone.org
https://lists.plone.org/mailman/listinfo/plone-plip-advisories

Re: [PLIP-Advisories] [Plone development workspace] #10959: API for password validation policy

[Change notifications for Plone PLIPs on Trac.]

#10959: API for password validation policy
---+---
  Reporter:  djay  |  Owner:
  Type:  PLIP  | Status:  confirmed
  Priority:  minor |  Milestone:  4.3
 Component:  Backend (Python)  |Version:  4.1
Resolution:|   Keywords:
---+---

Comment (by djay):

 This PLIP is fully functional just a little more work to make the tests
 pass.

 No API is needed for custom password generation as generated passwords are
 no longer given out to users.

 The sticking point is that I keep getting different advise on how to
 implement this API. It's currently implemented as a PAS User Property
 validation plugin which seemed the most logical as it didn't require any
 new API's to be created. PAS is simple to understand and already
 extensively used in Plone. The current implementation returns both the
 description of what kind of password is needed and specific validation
 errors from the same function call.

 It's really up to the FWT to decide what kind of API they will accept. I'm
 happy for mitchell to reimplement this to provide a different style API if
 that's the preferred solution.

-- 
Ticket URL: 
Plone development workspace 
Plone Enterprise Content Management System
___
PLIP-Advisories mailing list
plip-advisor...@lists.plone.org
https://lists.plone.org/mailman/listinfo/plone-plip-advisories

Re: [PLIP-Advisories] [Plone development workspace] #10959: API for password validation policy

[Change notifications for Plone PLIPs on Trac.]

#10959: API for password validation policy
---+---
  Reporter:  djay  |  Owner:
  Type:  PLIP  | Status:  confirmed
  Priority:  minor |  Milestone:  4.3
 Component:  Backend (Python)  |Version:  4.1
Resolution:|   Keywords:
---+---
Changes (by eleddy):

 * status:  reopened => confirmed
 * cc: mitchell (added)
 * version:   => 4.1
 * component:  Unknown => Backend (Python)


Comment:

 Okay guys - there is some overlap happening here. We have two plips that
 are basically the same, one that was partially implemented and one that is
 proposed. Any chance you (djay and mitchell) can get together, put
 together 1 plip and we can go from there???

 Refs #10959, #12521

-- 
Ticket URL: 
Plone development workspace 
Plone Enterprise Content Management System
___
PLIP-Advisories mailing list
plip-advisor...@lists.plone.org
https://lists.plone.org/mailman/listinfo/plone-plip-advisories

Re: [PLIP-Advisories] [Plone development workspace] #10959: API for password validation policy

[Change notifications for Plone PLIPs on Trac.]

#10959: API for password validation policy
-+---
 Reporter:  djay |   Owner:
 Type:  PLIP |  Status:  reopened
 Priority:  minor|   Milestone:  4.3
Component:  Unknown  |  Resolution:
 Keywords:   |
-+---

Comment (by djay):

 I'm happy for someone to take over the implementation too.

-- 
Ticket URL: 
Plone development workspace 
Plone Enterprise Content Management System
___
PLIP-Advisories mailing list
plip-advisor...@lists.plone.org
https://lists.plone.org/mailman/listinfo/plone-plip-advisories

Re: [PLIP-Advisories] [Plone development workspace] #10959: API for password validation policy

[Change notifications for Plone PLIPs on Trac.]

#10959: API for password validation policy
-+---
 Reporter:  djay |   Owner:
 Type:  PLIP |  Status:  reopened
 Priority:  minor|   Milestone:  4.3
Component:  Unknown  |  Resolution:
 Keywords:   |
-+---

Comment (by rossp):

 I'm unable to be an
 
[https://github.com/plone/plone.app.users/commit/c2cac165d05776ae3c25386595e13c388a7483e2#commitcomment-916859
 effective champion] for this PLIP.  I think it's a great idea, though.
 Anyone want to take over?

-- 
Ticket URL: 
Plone development workspace 
Plone Enterprise Content Management System
___
PLIP-Advisories mailing list
plip-advisor...@lists.plone.org
https://lists.plone.org/mailman/listinfo/plone-plip-advisories

Re: [PLIP-Advisories] [Plone development workspace] #10959: API for password validation policy

[Change notifications for Plone PLIPs on Trac.]

#10959: API for password validation policy
-+---
 Reporter:  djay |   Owner:
 Type:  PLIP |  Status:  reopened
 Priority:  minor|   Milestone:  4.3
Component:  Unknown  |  Resolution:
 Keywords:   |
-+---

Comment (by rossp):

 Oops, forgot to mention, I'm -1 for merge but if I recall, there still
 time to address the issues for 4.3.

-- 
Ticket URL: 
Plone development workspace 
Plone Enterprise Content Management System
___
PLIP-Advisories mailing list
plip-advisor...@lists.plone.org
https://lists.plone.org/mailman/listinfo/plone-plip-advisories

Re: [PLIP-Advisories] [Plone development workspace] #10959: API for password validation policy

[Change notifications for Plone PLIPs on Trac.]

#10959: API for password validation policy
-+---
 Reporter:  djay |   Owner:
 Type:  PLIP |  Status:  reopened
 Priority:  minor|   Milestone:  4.3
Component:  Unknown  |  Resolution:
 Keywords:   |
-+---

Comment (by rossp):

 I've
 
[[https://github.com/plone/buildout.coredev/commit/45a739f7dbffc2ac77e3a64b78f7f9fb2cbc04b0|updated
 my review]] and reviewed the code in a
 [[https://github.com/plone/plone.app.users/pull/2|pull request]] I started
 for the purpose of reviewing the implementation.

 Summary, I'm still -1 for merge.

-- 
Ticket URL: 
Plone development workspace 
Plone Enterprise Content Management System
___
PLIP-Advisories mailing list
plip-advisor...@lists.plone.org
https://lists.plone.org/mailman/listinfo/plone-plip-advisories

Re: [PLIP-Advisories] [Plone development workspace] #10959: API for password validation policy

[Change notifications for Plone PLIPs on Trac.]

#10959: API for password validation policy
-+---
 Reporter:  djay |   Owner:
 Type:  PLIP |  Status:  reopened
 Priority:  minor|   Milestone:  4.3
Component:  Unknown  |  Resolution:
 Keywords:   |
-+---

Comment (by djay):

 I've pushed an update plip cfg with a working set of initial tests.

-- 
Ticket URL: 
Plone development workspace 
Plone Enterprise Content Management System
___
PLIP-Advisories mailing list
plip-advisor...@lists.plone.org
https://lists.plone.org/mailman/listinfo/plone-plip-advisories

Re: [PLIP-Advisories] [Plone development workspace] #10959: API for password validation policy

[Change notifications for Plone PLIPs on Trac.]

#10959: API for password validation policy
-+---
 Reporter:  djay |   Owner:
 Type:  PLIP |  Status:  reopened
 Priority:  minor|   Milestone:  4.3
Component:  Unknown  |  Resolution:
 Keywords:   |
-+---

Comment (by djay):

 Hi,

 I wanted to get some feedback that I'm heading in right direction before I
 finish this work

 
https://github.com/plone/Products.PlonePAS/commit/5966fa4ec68b73dd036d6ebbaf1c8ff99e3bc316

 
https://github.com/plone/Products.CMFPlone/commit/de366e67f43e1a4e314eb57ed30a4b9aa2ec84d6

 TODO: Make tests pass. Move changes to
 Products/PlonePAS/plugins/property.py into it's own defaultplonepassword
 policy object so it's clear it's optional. Upgrade steps etc.

-- 
Ticket URL: 
Plone development workspace 
Plone Enterprise Content Management System
___
PLIP-Advisories mailing list
plip-advisor...@lists.plone.org
https://lists.plone.org/mailman/listinfo/plone-plip-advisories

Re: [PLIP-Advisories] [Plone development workspace] #10959: API for password validation policy

[Change notifications for Plone PLIPs on Trac.]

#10959: API for password validation policy
-+---
 Reporter:  djay |   Owner:
 Type:  PLIP |  Status:  reopened
 Priority:  minor|   Milestone:  4.3
Component:  Unknown  |  Resolution:
 Keywords:   |
-+---

Comment (by esteele):

 Replying to [comment:39 djay]:
 > Yes. I intend to meet the implementation date. However I'd like to avoid
 the situation last time whereby I fully implemented a solution where the
 design was latter rejected. Is there a standard process for reviewing
 during implementation? I DM  ggozad to see if he would review as I went
 but I'm not sure if thats correct or not.

 Part of the way the FWT is trying to do things now is to make it more of a
 continuous review process. Ask questions, either here or on the Framework
 Team mailing list and they'll give feedback. If not, ping me and I'll make
 sure someone takes a look at it.

 ggozad is taking a break from the FWT for a bit, so I'm unsure whether
 he's able to respond to any particular questions right now. Ross, are you
 the new FWT champion for this PLIP?

-- 
Ticket URL: 
Plone development workspace 
Plone Enterprise Content Management System
___
PLIP-Advisories mailing list
plip-advisor...@lists.plone.org
https://lists.plone.org/mailman/listinfo/plone-plip-advisories

Re: [PLIP-Advisories] [Plone development workspace] #10959: API for password validation policy

[Change notifications for Plone PLIPs on Trac.]

#10959: API for password validation policy
-+---
 Reporter:  djay |   Owner:
 Type:  PLIP |  Status:  reopened
 Priority:  minor|   Milestone:  4.3
Component:  Unknown  |  Resolution:
 Keywords:   |
-+---

Comment (by djay):

 Yes. I intend to meet the implementation date. However I'd like to avoid
 the situation last time whereby I fully implemented a solution where the
 design was latter rejected. Is there a standard process for reviewing
 during implementation? I DM  ggozad to see if he would review as I went
 but I'm not sure if thats correct or not.

-- 
Ticket URL: 
Plone development workspace 
Plone Enterprise Content Management System
___
PLIP-Advisories mailing list
plip-advisor...@lists.plone.org
https://lists.plone.org/mailman/listinfo/plone-plip-advisories

Re: [PLIP-Advisories] [Plone development workspace] #10959: API for password validation policy

[Change notifications for Plone PLIPs on Trac.]

#10959: API for password validation policy
-+---
 Reporter:  djay |   Owner:
 Type:  PLIP |  Status:  reopened
 Priority:  minor|   Milestone:  4.3
Component:  Unknown  |  Resolution:
 Keywords:   |
-+---

Comment (by rossp):

 @djay Did you see this response to your PLIP?  Can you comment on the
 ticket as to whether you'll be able to finish the implementation for
 review for Plone 4.3?  Implementations have to be finished by the first
 week of January.

-- 
Ticket URL: 
Plone development workspace 
Plone Enterprise Content Management System
___
PLIP-Advisories mailing list
plip-advisor...@lists.plone.org
https://lists.plone.org/mailman/listinfo/plone-plip-advisories

Re: [PLIP-Advisories] [Plone development workspace] #10959: API for password validation policy

[Change notifications for Plone PLIPs on Trac.]

#10959: API for password validation policy
-+---
 Reporter:  djay |   Owner:
 Type:  PLIP |  Status:  reopened
 Priority:  minor|   Milestone:  4.3
Component:  Unknown  |  Resolution:
 Keywords:   |
-+---

Comment (by ggozad):

 Hey!
 I think you are in the right direction. As long as the points addressed in
 the reviews are answered and acted upon I am fine with it. When you are
 ready and have something for review let us know.

-- 
Ticket URL: 
Plone development workspace 
Plone Enterprise Content Management System
___
PLIP-Advisories mailing list
plip-advisor...@lists.plone.org
https://lists.plone.org/mailman/listinfo/plone-plip-advisories

Re: [PLIP-Advisories] [Plone development workspace] #10959: API for password validation policy

[Change notifications for Plone PLIPs on Trac.]

#10959: API for password validation policy
-+---
 Reporter:  djay |   Owner:
 Type:  PLIP |  Status:  reopened
 Priority:  minor|   Milestone:  4.3
Component:  Unknown  |  Resolution:
 Keywords:   |
-+---

Comment (by rossp):

 @djay I think I missed that meeting so ggozad will have to clarify.

-- 
Ticket URL: 
Plone development workspace 
Plone Enterprise Content Management System
___
PLIP-Advisories mailing list
plip-advisor...@lists.plone.org
https://lists.plone.org/mailman/listinfo/plone-plip-advisories

Re: [PLIP-Advisories] [Plone development workspace] #10959: API for password validation policy

[Change notifications for Plone PLIPs on Trac.]

#10959: API for password validation policy
-+---
 Reporter:  djay |   Owner:
 Type:  PLIP |  Status:  reopened
 Priority:  minor|   Milestone:  4.3
Component:  Unknown  |  Resolution:
 Keywords:   |
-+---

Comment (by djay):

 Hi,

 I don't fully understand previous comments "We would like to see this done
 at the PAS level "

 Just want to confirm that what I'm going to code is going to suitable this
 time.
 1. Move the 5char password policy to its own password validation plugin in
 Products.PlonePAS
 2. remove all the code I added for a password generator plugin
 3. Make all auto generated passwords extremely long since its been
 determined that at no time does a new user see the autogenerated password.
 As long as the password is unguessable we should be fine.

 Is this ok?

-- 
Ticket URL: 
Plone development workspace 
Plone Enterprise Content Management System
___
PLIP-Advisories mailing list
plip-advisor...@lists.plone.org
https://lists.plone.org/mailman/listinfo/plone-plip-advisories