RE: Cosmetic Patch for gtkmusicbrowser.cpp

[Isaac Richards]

On 16-Sep-2000 Chris Kuklewicz wrote:
 It looks like a gtk+ bug, but when the pane is turned via the view
 menu in the method

It is a gtk bug -- I've left this unfixed to see when/if they'd get around to
fixing it..  Ah well, I'll apply your patch =)

Isaac
___
[EMAIL PROTECTED]
http://www.freeamp.org/mailman/listinfo/freeamp-dev

Cosmetic Patch for gtkmusicbrowser.cpp

[Chris Kuklewicz]

It looks like a gtk+ bug, but when the pane is turned via the view
menu in the method

void GTKMusicBrowser::ExpandCollapseEvent(void)

and the vertical scroll bar was visible, then the vertical scroll bar
is still drawn, but it now overlaps the left side of the playlist.
Like I said, this looks a gtk+ bug.

Turning off the scroll bar is an easy workaround, and is done in this
small patch.



Index: gtkmusicbrowser.cpp
===
RCS file: /src/repository/freeamp/ui/musicbrowser/unix/src/gtkmusicbrowser.cpp,v
retrieving revision 1.111
diff -u -r1.111 gtkmusicbrowser.cpp
--- gtkmusicbrowser.cpp 2000/09/11 06:39:38 1.111
+++ gtkmusicbrowser.cpp 2000/09/15 21:56:45
@@ -766,6 +766,8 @@
 gtk_paned_set_position(GTK_PANED(masterBox), lastPanedPosition);
 gtk_paned_set_handle_size(GTK_PANED(masterBox), lastPanedHandle);
 }
+gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(musicBrowserWindow),
+   GTK_POLICY_AUTOMATIC, GTK_POLICY_AUTOMATIC);
 title += string(" - My Music: ");
 GtkWidget *w = gtk_item_factory_get_widget(menuFactory,
"/View/View Playlist Only");
@@ -778,6 +780,8 @@
 lastPanedHandle = ((GtkPaned *)masterBox)-handle_size;
 gtk_paned_set_position(GTK_PANED(masterBox), 0);
 gtk_paned_set_handle_size(GTK_PANED(masterBox), 0);
+gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(musicBrowserWindow),
+   GTK_POLICY_NEVER,GTK_POLICY_NEVER);
 title += string(" - Playlist Editor: ");
 GtkWidget *w = gtk_item_factory_get_widget(menuFactory,
"/View/View Playlist Only");

 PGP signature