[Bug 193671] [acpiconf] Extra whitespace at the end of the State: line
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193671 Jung-uk Kim changed: What|Removed |Added Assignee|freebsd-acpi@FreeBSD.org|j...@freebsd.org Status|In Progress |Closed Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-acpi@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-acpi To unsubscribe, send any mail to "freebsd-acpi-unsubscr...@freebsd.org"
[Bug 193671] [acpiconf] Extra whitespace at the end of the State: line
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193671 --- Comment #5 from Jung-uk Kim --- (In reply to John Baldwin from comment #4) No, it is not necessary because practically there is only one invalid value, i.e., ACPI_BATT_STAT_DISCHARG | ACPI_BATT_STAT_CHARGING. :-) -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-acpi@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-acpi To unsubscribe, send any mail to "freebsd-acpi-unsubscr...@freebsd.org"
[Bug 193671] [acpiconf] Extra whitespace at the end of the State: line
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193671 --- Comment #4 from John Baldwin --- Comment on attachment 155290 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=155290 A patch to test Hah, I actually started with something like this myself but worried it was too verbose. I'm fine with this approach though. The only thing I would suggest is outputting the raw hex value for invalid values. You could do that by using printf() instead of the state variable. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-acpi@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-acpi To unsubscribe, send any mail to "freebsd-acpi-unsubscr...@freebsd.org"
[Bug 193671] [acpiconf] Extra whitespace at the end of the State: line
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193671 --- Comment #3 from Jung-uk Kim --- (In reply to John Baldwin from comment #1) I am okay with your patch. However, I'd like to clearly note that other states are invalid. Please let me know what you think. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-acpi@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-acpi To unsubscribe, send any mail to "freebsd-acpi-unsubscr...@freebsd.org"
[Bug 193671] [acpiconf] Extra whitespace at the end of the State: line
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193671 Jung-uk Kim changed: What|Removed |Added CC||j...@freebsd.org --- Comment #2 from Jung-uk Kim --- Created attachment 155290 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=155290&action=edit A patch to test -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-acpi@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-acpi To unsubscribe, send any mail to "freebsd-acpi-unsubscr...@freebsd.org"
[Bug 193671] [acpiconf] Extra whitespace at the end of the State: line
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193671 John Baldwin changed: What|Removed |Added CC||j...@freebsd.org Status|New |In Progress --- Comment #1 from John Baldwin --- Please see https://reviews.freebsd.org/D2243 -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-acpi@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-acpi To unsubscribe, send any mail to "freebsd-acpi-unsubscr...@freebsd.org"
[Bug 193671] [acpiconf] Extra whitespace at the end of the State: line
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193671 Mark Linimon changed: What|Removed |Added Assignee|freebsd-b...@freebsd.org|freebsd-acpi@FreeBSD.org -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-acpi@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-acpi To unsubscribe, send any mail to "freebsd-acpi-unsubscr...@freebsd.org"
