[Bug 227191] Cannot check battery status after upgrading to 12-CURRENT from r330529 to r331748 (ACPI problems)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227191

Mateusz Piotrowski <0...@freebsd.org> changed:

   What|Removed |Added

 Status|New |Open

--- Comment #15 from Mateusz Piotrowski <0...@freebsd.org> ---
Do you think we get it committed before 12.0-RELEASE?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-acpi@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-acpi
To unsubscribe, send any mail to "freebsd-acpi-unsubscr...@freebsd.org"

[Bug 227191] Cannot check battery status after upgrading to 12-CURRENT from r330529 to r331748 (ACPI problems)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227191

--- Comment #14 from Conrad Meyer  ---
*** Bug 230428 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-acpi@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-acpi
To unsubscribe, send any mail to "freebsd-acpi-unsubscr...@freebsd.org"

[Bug 227191] Cannot check battery status after upgrading to 12-CURRENT from r330529 to r331748 (ACPI problems)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227191

--- Comment #13 from Andriy Gapon  ---
(In reply to Ali Abdallah from comment #10)

Based on Conrad's investigation in comment #4, why not just return TRUE for any
failure of acpi_GetInteger(h, "_STA", ) ?
I think that would be completely backward compatible with the previous
behaviour of AcpiGetObjectInfo.
But this is just a minor suggestion.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-acpi@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-acpi
To unsubscribe, send any mail to "freebsd-acpi-unsubscr...@freebsd.org"

[Bug 227191] Cannot check battery status after upgrading to 12-CURRENT from r330529 to r331748 (ACPI problems)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227191

--- Comment #12 from Conrad Meyer  ---
(In reply to Ali Abdallah from comment #10)
Patch looks good to me.  I have an X230 but don't know that I can promise to
test any time soon.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-acpi@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-acpi
To unsubscribe, send any mail to "freebsd-acpi-unsubscr...@freebsd.org"

[Bug 227191] Cannot check battery status after upgrading to 12-CURRENT from r330529 to r331748 (ACPI problems)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227191

Mateusz Piotrowski <0...@freebsd.org> changed:

   What|Removed |Added

   Severity|Affects Only Me |Affects Many People
   Keywords|needs-patch |patch

--- Comment #11 from Mateusz Piotrowski <0...@freebsd.org> ---
(In reply to Ali Abdallah from comment #10)

Thank you for the patch.

Unfortunately, I am unable to this it out soon as the machine stopped booting
due to hardware issues a few weeks ago.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-acpi@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-acpi
To unsubscribe, send any mail to "freebsd-acpi-unsubscr...@freebsd.org"

[Bug 227191] Cannot check battery status after upgrading to 12-CURRENT from r330529 to r331748 (ACPI problems)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227191

Ali Abdallah  changed:

   What|Removed |Added

 CC||ali...@gmail.com

--- Comment #10 from Ali Abdallah  ---
Created attachment 196523
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=196523=edit
Fix battery detection code

I worked out a patch to fix the problem. It fixes the issue for me on my
corebooted Thinkpad x230. 

On non *BAT0_STA method, acpi_GetInteger returns AE_NOT_EXIST on the new acpica
code, since _STA core was removed. 

Give it a try.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-acpi@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-acpi
To unsubscribe, send any mail to "freebsd-acpi-unsubscr...@freebsd.org"

[Bug 227191] Cannot check battery status after upgrading to 12-CURRENT from r330529 to r331748 (ACPI problems)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227191

Mateusz Piotrowski <0...@freebsd.org> changed:

   What|Removed |Added

 Blocks||230428


Referenced Bugs:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230428
[Bug 230428] No battery detected on Thinkpad x230 with coreboot bios
-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-acpi@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-acpi
To unsubscribe, send any mail to "freebsd-acpi-unsubscr...@freebsd.org"

[Bug 227191] Cannot check battery status after upgrading to 12-CURRENT from r330529 to r331748 (ACPI problems)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227191

--- Comment #9 from Mateusz Piotrowski <0...@freebsd.org> ---
(In reply to Mateusz Piotrowski from comment #8)

Can I provide any logs/recompile the system with debugging on to help debug
this issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-acpi@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-acpi
To unsubscribe, send any mail to "freebsd-acpi-unsubscr...@freebsd.org"

[Bug 227191] Cannot check battery status after upgrading to 12-CURRENT from r330529 to r331748 (ACPI problems)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227191

--- Comment #8 from Mateusz Piotrowski <0...@freebsd.org> ---
Same on 12.0-CURRENT r44.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-acpi@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-acpi
To unsubscribe, send any mail to "freebsd-acpi-unsubscr...@freebsd.org"

[Bug 227191] Cannot check battery status after upgrading to 12-CURRENT from r330529 to r331748 (ACPI problems)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227191

Mateusz Piotrowski <0...@freebsd.org> changed:

   What|Removed |Added

   Keywords||needs-patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-acpi@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-acpi
To unsubscribe, send any mail to "freebsd-acpi-unsubscr...@freebsd.org"

[Bug 227191] Cannot check battery status after upgrading to 12-CURRENT from r330529 to r331748 (ACPI problems)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227191

--- Comment #7 from Mateusz Piotrowski <0...@freebsd.org> ---
(In reply to Mateusz Piotrowski from comment #1)

Also, I get those ACPI ERROR lines from dmesg mentioned even when the battery
is detected (before r330957) so they are probably not related.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-acpi@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-acpi
To unsubscribe, send any mail to "freebsd-acpi-unsubscr...@freebsd.org"

[Bug 227191] Cannot check battery status after upgrading to 12-CURRENT from r330529 to r331748 (ACPI problems)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227191

--- Comment #6 from Mateusz Piotrowski <0...@freebsd.org> ---
I can confirm that `acpiconf -i 0` works as expected on r330956 while being
broken on r330957.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-acpi@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-acpi
To unsubscribe, send any mail to "freebsd-acpi-unsubscr...@freebsd.org"

[Bug 227191] Cannot check battery status after upgrading to 12-CURRENT from r330529 to r331748 (ACPI problems)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227191

--- Comment #5 from Mateusz Piotrowski <0...@freebsd.org> ---
(In reply to Conrad Meyer from comment #3)

I'm building r330956 at the moment. I'll report back.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-acpi@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-acpi
To unsubscribe, send any mail to "freebsd-acpi-unsubscr...@freebsd.org"

[Bug 227191] Cannot check battery status after upgrading to 12-CURRENT from r330529 to r331748 (ACPI problems)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227191

--- Comment #4 from Conrad Meyer  ---
Your dmesg line seems related (BAT0):
ACPI Error: Method parse/execution failed \134_SB.PCI0.LPCB.EC0.BAT0._STA,
AE_NOT_EXIST

Nothing changed in any of the dmesg-mentioned files (evregion, exfldio,
psparse) in that commit.  Hmm.

However, these changes are suspect:
sys/contrib/dev/acpica/components/namespace/nsxfname.c

- * For Device and Processor objects, run the Device _HID, _UID, _CID, _STA,
+ * For Device and Processor objects, run the Device _HID, _UID, _CID,
...

- * this was the fate of the _SUB method which was found to cause such
- * problems and was removed (11/2015).
+ * Because of this reason support for the following methods has been removed:
+ * 1) _SUB method was removed (11/2015)
+ * 2) _STA method was removed (02/2018)

- *
- * For _STA, if the method does not exist, then (as per the ACPI
- * specification), the returned CurrentStatus flags will indicate
- * that the device is present/functional/enabled. Otherwise, the
- * CurrentStatus flags reflect the value returned from _STA.
  */

-/* Execute the Device._STA method */
-
-Status = AcpiUtExecute_STA (Node, >CurrentStatus);
-if (ACPI_SUCCESS (Status))
-{
-Valid |= ACPI_VALID_STA;
-}


sys/contrib/dev/acpica/changes.txt

+AcpiGetObjectInfo - removed support for the _STA method. This was causing
+problems on some platforms.


And removing it clearly causes problems on others, so...

sys/dev/acpica/acpi.c

 BOOLEAN
 acpi_DeviceIsPresent(device_t dev)
 {
-ACPI_DEVICE_INFO   *devinfo;
-ACPI_HANDLEh;
-BOOLEANpresent;
+   ACPI_HANDLE h;
+   UINT32 s;
+   ACPI_STATUS status;

-if ((h = acpi_get_handle(dev)) == NULL ||
-   ACPI_FAILURE(AcpiGetObjectInfo(h, )))
-   return (FALSE);
+   h = acpi_get_handle(dev);
+   if (h == NULL)
+   return (FALSE);
+   status = acpi_GetInteger(h, "_STA", );

-/* If no _STA method, must be present */
-present = (devinfo->Valid & ACPI_VALID_STA) == 0 ||
-   ACPI_DEVICE_PRESENT(devinfo->CurrentStatus) ? TRUE : FALSE;
+   /* If no _STA method, must be present */
+   if (ACPI_FAILURE(status))
+   return (status == AE_NOT_FOUND ? TRUE : FALSE);
...
+   return (ACPI_DEVICE_PRESENT(s) ? TRUE : FALSE);

Ok, this function should behave more or less the same as before...

A similar change was made to acpi_BatteryIsPresent(), but again I don't see the
problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-acpi@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-acpi
To unsubscribe, send any mail to "freebsd-acpi-unsubscr...@freebsd.org"

[Bug 227191] Cannot check battery status after upgrading to 12-CURRENT from r330529 to r331748 (ACPI problems)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227191

--- Comment #3 from Conrad Meyer  ---
r330957 from that period is the 20180313 ACPICA merge.  Probably suspect.  I
don't see any other ACPI changes in that interval that relate to x86 laptops.

Any chance you can try r330956 and r330957 and report whether that isolates it?
 Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-acpi@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-acpi
To unsubscribe, send any mail to "freebsd-acpi-unsubscr...@freebsd.org"

[Bug 227191] Cannot check battery status after upgrading to 12-CURRENT from r330529 to r331748 (ACPI problems)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227191

--- Comment #2 from Mateusz Piotrowski <0...@freebsd.org> ---
It is not a hardware issue apparently. I've live booted Ubuntu and it detects
my battery just fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-acpi@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-acpi
To unsubscribe, send any mail to "freebsd-acpi-unsubscr...@freebsd.org"

[Bug 227191] Cannot check battery status after upgrading to 12-CURRENT from r330529 to r331748 (ACPI problems)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227191

--- Comment #1 from Mateusz Piotrowski <0...@freebsd.org> ---
I found the following lines in my dmesg:

> ACPI Error: No handler for Region [ERAM] (0xf80003621b80) 
> [EmbeddedControl] (20180313/evregion-288)
> ACPI Error: Region EmbeddedControl (ID=3) has no handler 
> (20180313/exfldio-428)
> ACPI Error: Method parse/execution failed \134_SB.PCI0.LPCB.EC0.BAT0._STA, 
> AE_NOT_EXIST (20180313/psparse-677)

I am not sure if they are new but they mention BAT0.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-acpi@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-acpi
To unsubscribe, send any mail to "freebsd-acpi-unsubscr...@freebsd.org"

[Bug 227191] Cannot check battery status after upgrading to 12-CURRENT from r330529 to r331748 (ACPI problems)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227191

Mark Linimon  changed:

   What|Removed |Added

   Keywords||regression
   Assignee|freebsd-b...@freebsd.org|freebsd-acpi@FreeBSD.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-acpi@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-acpi
To unsubscribe, send any mail to "freebsd-acpi-unsubscr...@freebsd.org"