Re: [PATCH] Abort powerd when no cpufreq(4) support is found
The message is fine, but I think an error code of 0 is wrong. Powerd didn't start, whereas 0 means the daemon launched successfully. On Apr 9, 2012, at 2:11 AM, Robert Millan wrote: Hi, I'd like to check-in this patch so that powerd aborts gracefully when there's no cpufreq(4) support for the CPU in which it is running. Does this look alright? -- Robert Millan no_cpufreq.diff ___ freebsd-acpi@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-acpi To unsubscribe, send any mail to freebsd-acpi-unsubscr...@freebsd.org
Re: [PATCH] Abort powerd when no cpufreq(4) support is found
Hi Nate, El 9 d’abril de 2012 18:06, Nate Lawson n...@root.org ha escrit: The message is fine, but I think an error code of 0 is wrong. Powerd didn't start, whereas 0 means the daemon launched successfully. In that case, may I suggest that we return one of the error codes recommended by sysexists(3)? EX_UNAVAILABLE seems close enough to the reason we're aborting. -- Robert Millan no_cpufreq.diff Description: Binary data ___ freebsd-acpi@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-acpi To unsubscribe, send any mail to freebsd-acpi-unsubscr...@freebsd.org
Re: [PATCH] Abort powerd when no cpufreq(4) support is found
On 04/09/2012 13:59, Robert Millan wrote: El 9 d’abril de 2012 18:53, Nate Lawson n...@root.org ha escrit: Fine by me. The rc framework or user should be the one to interpret the error code and realize that it's ok that it's not running (not supported). Committed then, thanks for reviewing. Have you verified how rc.d handles this new error? If changes are necessary a friendly message to freebsd-rc@ would be in order Doug -- This .signature sanitized for your protection ___ freebsd-acpi@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-acpi To unsubscribe, send any mail to freebsd-acpi-unsubscr...@freebsd.org
