Re: Dell acpi_video patch

2012-10-22 Thread John Baldwin
On Saturday, October 20, 2012 9:37:40 am Alberto Villa wrote: On Sat, Oct 20, 2012 at 2:40 PM, John Baldwin j...@freebsd.org wrote: Oh, no, I hadn't been able to tell from your ASL that bit 16 was set (it's not that easy to guess as it computes the ID's dynamically at runtime. I see. I

Re: Dell acpi_video patch

2012-10-20 Thread John Baldwin
On Friday, October 19, 2012 06:21:00 PM Alberto Villa wrote: On Fri, Oct 19, 2012 at 7:13 PM, John Baldwin j...@freebsd.org wrote: Yes, unless bit 31 is set, we can't know anything about bits 0-15 except that they are unique. Specifically, we can't look at the Display Type bits to

Re: Dell acpi_video patch

2012-10-19 Thread Alberto Villa
On Thu, Oct 18, 2012 at 11:16 PM, John Baldwin j...@freebsd.org wrote: Ok, can you possibly hack acpi_video to output the values returned _DOD (in hex) and the _ADR values (in hex) of your outputs? I've read the ACPI spec and checked my dump, now I see what you mean. Nonetheless, I think you

Re: Dell acpi_video patch

2012-10-19 Thread Alberto Villa
On Fri, Oct 12, 2012 at 4:06 PM, John Baldwin j...@freebsd.org wrote: I think this is correct, but in we need to do more to properly handle that flag (DOD_DEVID_SCHEME_STD). Specifically, we shouldn't trust any bits in the device ID unless that bit is set (except for the special case of

Re: Dell acpi_video patch

2012-10-19 Thread John Baldwin
On Friday, October 19, 2012 10:34:08 am Alberto Villa wrote: On Thu, Oct 18, 2012 at 11:16 PM, John Baldwin j...@freebsd.org wrote: Ok, can you possibly hack acpi_video to output the values returned _DOD (in hex) and the _ADR values (in hex) of your outputs? I've read the ACPI spec and

Re: Dell acpi_video patch

2012-10-19 Thread John Baldwin
On Thursday, October 18, 2012 3:57:23 pm Juergen Lock wrote: On Thu, Oct 18, 2012 at 08:59:14AM -0400, John Baldwin wrote: On Friday, October 12, 2012 12:33:49 pm Juergen Lock wrote: On Fri, Oct 12, 2012 at 10:06:17AM -0400, John Baldwin wrote: On Friday, October 05, 2012 5:53:16 pm

Re: Dell acpi_video patch

2012-10-19 Thread Alberto Villa
On Fri, Oct 19, 2012 at 4:53 PM, John Baldwin j...@freebsd.org wrote: I'm looking at section B.4.2 in the 3.0b spec, it has a sample _DOD of: I've read section B.3.2 of 5.0 spec, which looks the same as 3.0b, but my IDs don't have bit 31 set, they have bit 16 (which is the difference between

Re: Dell acpi_video patch

2012-10-19 Thread John Baldwin
On Friday, October 19, 2012 11:41:56 am Alberto Villa wrote: On Fri, Oct 19, 2012 at 4:53 PM, John Baldwin j...@freebsd.org wrote: I'm looking at section B.4.2 in the 3.0b spec, it has a sample _DOD of: I've read section B.3.2 of 5.0 spec, which looks the same as 3.0b, but my IDs don't have

Re: Dell acpi_video patch

2012-10-19 Thread John Baldwin
On Friday, October 19, 2012 11:23:57 am Alberto Villa wrote: On Fri, Oct 12, 2012 at 4:06 PM, John Baldwin j...@freebsd.org wrote: I think this is correct, but in we need to do more to properly handle that flag (DOD_DEVID_SCHEME_STD). Specifically, we shouldn't trust any bits in the

Re: Dell acpi_video patch

2012-10-19 Thread Juergen Lock
On Fri, Oct 19, 2012 at 11:14:10AM -0400, John Baldwin wrote: On Thursday, October 18, 2012 3:57:23 pm Juergen Lock wrote: On Thu, Oct 18, 2012 at 08:59:14AM -0400, John Baldwin wrote: On Friday, October 12, 2012 12:33:49 pm Juergen Lock wrote: On Fri, Oct 12, 2012 at 10:06:17AM -0400,

Re: Dell acpi_video patch

2012-10-19 Thread Alberto Villa
On Fri, Oct 19, 2012 at 7:34 PM, John Baldwin j...@freebsd.org wrote: I considered that, but 1) it wouldn't help your laptop, and 2) the ACPI 3.0b spec where bit 31 is added specifically states (in the Note 3 I included in my prior e-mail) that 0x110 is the only valid legacy ID. Sure, it

Re: Dell acpi_video patch

2012-10-19 Thread Alberto Villa
On Sat, Oct 20, 2012 at 12:21 AM, Alberto Villa avi...@freebsd.org wrote: I know, I was saying that you probably confused bit 31 with bit 16, so the patch you proposed (about bit 31 being set in _DOD but not in _ADR) was not correct. ;) You assumption, actually. The patch you committed was

Re: Dell acpi_video patch

2012-10-18 Thread John Baldwin
On Wednesday, October 17, 2012 9:08:34 pm Alberto Villa wrote: On Mon, Oct 15, 2012 at 5:12 PM, John Baldwin j...@freebsd.org wrote: Interesting. Can you get an acpidump? Sure: http://people.FreeBSD.org/~avilla/files/avilla.asl.gz I'd be glad to solve my problems with ACPI! Ah, looks

Re: Dell acpi_video patch

2012-10-18 Thread John Baldwin
On Friday, October 12, 2012 12:33:49 pm Juergen Lock wrote: On Fri, Oct 12, 2012 at 10:06:17AM -0400, John Baldwin wrote: On Friday, October 05, 2012 5:53:16 pm Juergen Lock wrote: Hi! I finally took a closer look why acpi_video found nothing on my Dell laptop (Precision M4500),

Re: Dell acpi_video patch

2012-10-18 Thread Juergen Lock
On Thu, Oct 18, 2012 at 08:59:14AM -0400, John Baldwin wrote: On Friday, October 12, 2012 12:33:49 pm Juergen Lock wrote: On Fri, Oct 12, 2012 at 10:06:17AM -0400, John Baldwin wrote: On Friday, October 05, 2012 5:53:16 pm Juergen Lock wrote: Hi! I finally took a closer look

Re: Dell acpi_video patch

2012-10-18 Thread Alberto Villa
On Thu, Oct 18, 2012 at 2:58 PM, John Baldwin j...@freebsd.org wrote: Ah, looks like your BIOS excludes DOD_DEVID_SCHEME_STD from it's _ADR methods (but does included it in on the list of displays returned by _DOD). Please test this updated version: Still the same: hw.acpi.video.out0.active:

Re: Dell acpi_video patch

2012-10-18 Thread John Baldwin
On Thursday, October 18, 2012 4:58:42 pm Alberto Villa wrote: On Thu, Oct 18, 2012 at 2:58 PM, John Baldwin j...@freebsd.org wrote: Ah, looks like your BIOS excludes DOD_DEVID_SCHEME_STD from it's _ADR methods (but does included it in on the list of displays returned by _DOD). Please

Re: Dell acpi_video patch

2012-10-17 Thread Alberto Villa
On Mon, Oct 15, 2012 at 5:12 PM, John Baldwin j...@freebsd.org wrote: Interesting. Can you get an acpidump? Sure: http://people.FreeBSD.org/~avilla/files/avilla.asl.gz I'd be glad to solve my problems with ACPI! -- Alberto Villa, FreeBSD committer avi...@freebsd.org

Re: Dell acpi_video patch

2012-10-15 Thread John Baldwin
On Friday, October 12, 2012 7:57:43 pm Alberto Villa wrote: On Fri, Oct 12, 2012 at 4:06 PM, John Baldwin j...@freebsd.org wrote: I think this is correct, but in we need to do more to properly handle that flag (DOD_DEVID_SCHEME_STD). Specifically, we shouldn't trust any bits in the device

Re: Dell acpi_video patch

2012-10-12 Thread John Baldwin
On Friday, October 05, 2012 5:53:16 pm Juergen Lock wrote: Hi! I finally took a closer look why acpi_video found nothing on my Dell laptop (Precision M4500), and came up with this patch: --- sys/dev/acpica/acpi_video.c.orig +++ sys/dev/acpica/acpi_video.c @@ -906,7 +906,7 @@

Re: Dell acpi_video patch

2012-10-12 Thread Alberto Villa
On Fri, Oct 12, 2012 at 4:06 PM, John Baldwin j...@freebsd.org wrote: I think this is correct, but in we need to do more to properly handle that flag (DOD_DEVID_SCHEME_STD). Specifically, we shouldn't trust any bits in the device ID unless that bit is set (except for the special case of