[Bug 209821] UEFI - installation media hangs when booting on ASUS P6P67 DELUXE

2022-01-08 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=209821

--- Comment #75 from Graham Perrin  ---
*** Bug 255073 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug 209821] UEFI - installation media hangs when booting on ASUS P6P67 DELUXE

2022-01-08 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=209821

Konstantin Belousov  changed:

   What|Removed |Added

 Status|In Progress |Closed
 Resolution|--- |FIXED

--- Comment #74 from Konstantin Belousov  ---
I am closing this because we cannot do more for stable/12.  For HEAD and
stable/13,
the proper fix was implemented some time ago.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug 209821] UEFI - installation media hangs when booting on ASUS P6P67 DELUXE

2022-01-08 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=209821

--- Comment #73 from commit-h...@freebsd.org ---
A commit in branch stable/12 references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=f131d68e21fc360f5c8e63377f25cf60706d9afa

commit f131d68e21fc360f5c8e63377f25cf60706d9afa
Author: David Sebek 
AuthorDate: 2022-01-07 20:18:49 +
Commit: Konstantin Belousov 
CommitDate: 2022-01-09 01:28:01 +

efi: loader: Inline copy_finish function in amd64 trampoline

Instead of calling the efi_copy_finish function from amd64_tramp,
include the copy instructions in the trampoline code itself.
This avoids boot hangs and restarts in the cases when
the efi_copy_finish code happens to be located at a memory
location that is overwritten during the copy process.

This is a direct commit to stable/12 since no-copy loader mode requires
the kernel update not suitable for the branch.

PR: 209821

 stand/efi/loader/arch/amd64/amd64_tramp.S   | 59 +++--
 stand/efi/loader/arch/amd64/elf64_freebsd.c | 18 +
 stand/efi/loader/copy.c |  8 
 stand/efi/loader/loader_efi.h   |  1 +
 4 files changed, 60 insertions(+), 26 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug 209821] UEFI - installation media hangs when booting on ASUS P6P67 DELUXE

2022-01-08 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=209821

--- Comment #72 from David Sebek  ---
Created attachment 230823
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=230823=edit
Updated edited version of the David's patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug 209821] UEFI - installation media hangs when booting on ASUS P6P67 DELUXE

2022-01-08 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=209821

--- Comment #71 from David Sebek  ---
(In reply to Konstantin Belousov from comment #69)

I tested the updated patch on my system, and it works. I made some minor
modifications to the patch:
- Corrected the copyright year
- Fixed one comment
- Fixed indentation of one comment

I think the efi_copy_finish function is also no longer needed besides the fact
that I referenced it in a comment in the trampoline code.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug 209821] UEFI - installation media hangs when booting on ASUS P6P67 DELUXE

2022-01-08 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=209821

Konstantin Belousov  changed:

   What|Removed |Added

 Attachment #225480|0   |1
is obsolete||
 Attachment #230798|0   |1
is obsolete||

--- Comment #70 from Konstantin Belousov  ---
Created attachment 230812
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=230812=edit
Edited version of the David' patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug 209821] UEFI - installation media hangs when booting on ASUS P6P67 DELUXE

2022-01-08 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=209821

--- Comment #69 from Konstantin Belousov  ---
(In reply to David Sebek from comment #68)
It looks fine to me.  I did some minimal editings, mostly:
- added your (David) copyright to the file
- removed old trampoline code, I do not see why it is needed
- reorganized registers usage mostly to avoid confusing arg renames
- minimal style update for comments

Can anybody test this and confirm that everything works fine?

-- 
You are receiving this mail because:
You are on the CC list for the bug.