[Bug 207940] [patch] sys/boot/efi/boot1 select boot partition
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207940 Tomoaki AOKI changed: What|Removed |Added Attachment #194818|0 |1 is obsolete|| --- Comment #29 from Tomoaki AOKI --- Created attachment 201260 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=201260=edit boot1.c patch rev4 for stable/11 after MFC of r332751 Updated patch for stable/11 after MFC of r332751. There were some not-MFC'ed changes on head, so different patch was needed. Not tested after stable/12 branch as I've moved to stable/12 ATM. If it does not apply, try patch for stable/12 and head. -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-amd64@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-amd64 To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"
[Bug 207940] [patch] sys/boot/efi/boot1 select boot partition
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207940 --- Comment #28 from Tomoaki AOKI --- Created attachment 201259 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=201259=edit boot1.c patch rev4 for stable/12 and head after r332751 Patch for head r332751 and later (before stable/12 branch). Forgot to upload for a long time. Applicable to both stable/12 and head, but would not to stable/11. (Not tested with stable/11.) -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-amd64@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-amd64 To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"
[Bug 207940] [patch] sys/boot/efi/boot1 select boot partition
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207940 Kyle Evans changed: What|Removed |Added CC||kev...@freebsd.org --- Comment #27 from Kyle Evans --- (In reply to nicolas from comment #26) Hi, cd /usr/src/stand && make -j4 all in stable/11, after 11.1 but before 11.2. It still recompiles libsa and other bits, but the stand/ build is completely self-contained nowadays (assuming you have the proper toolchain to build for the target platform, of course. =)) -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-amd64@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-amd64 To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"
[Bug 207940] [patch] sys/boot/efi/boot1 select boot partition
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207940 --- Comment #26 from nico...@deffayet.com --- Many thanks for the updated patch. It apply without any issue on FreeBSD 11.2-RELEASE. On FreeBSD 11.1, it was easy to recompile only boot1 with the following commands: # cd /usr/src/sys/boot/efi/boot1 # make It compile fine and generate both boot1.efi & boot1.efifat binary. But on FreeBSD 11.2: # cd /usr/src/stand/efi/boot1 # make Killed. pid 1026 (make), uid 0, was killed: out of swap space The machine have 6 Gb of free memory before running make. Running make eat all available memory. How can I fix that ? What the best method to recompile only boot1.efi & boot1.efifat in a standalone way without recompile a full world ? Many thanks -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-amd64@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-amd64 To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"
[Bug 207940] [patch] sys/boot/efi/boot1 select boot partition
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207940 --- Comment #25 from Tomoaki AOKI --- Created attachment 194818 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=194818=edit boot1.c patch rev4 for stable/11 r330813 and later Quick and ugly hack by mainly reviving deleted-but-needed-for-patch codes. Should be applicable to 11.2, as releng/11.2 branched after r330813 (at r334459). I had not enough time to dig into code changes to be tracked. :-( -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-amd64@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-amd64 To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"
[Bug 207940] [patch] sys/boot/efi/boot1 select boot partition
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207940 --- Comment #24 from nico...@deffayet.com --- See https://svnweb.freebsd.org/changeset/base/329114 for big changes done between 11.1-RELEASE and 11.2-RELEASE. -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-amd64@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-amd64 To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"
[Bug 207940] [patch] sys/boot/efi/boot1 select boot partition
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207940 nico...@deffayet.com changed: What|Removed |Added CC||nico...@deffayet.com --- Comment #23 from nico...@deffayet.com --- The patch can be applied on FreeBSD 11.1-RELEASE but not anymore on FreeBSD 11.2-RELEASE due to big change in boot1.c. For exemple, hd->PartitionNumber didn't exist anymore in boot1.c of FreeBSD 11.2-RELEASE. Anyone can make this patch working on 11.2-RELEASE ? Many thanks -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-amd64@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-amd64 To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"
[Bug 207940] [patch] sys/boot/efi/boot1 select boot partition
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207940 --- Comment #22 from Masachika ISHIZUKA--- (In reply to Naomichi Nonaka from comment #21) Thank you for ver4 patch. It works fine. -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-amd64@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-amd64 To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"
[Bug 207940] [patch] sys/boot/efi/boot1 select boot partition
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207940 Naomichi Nonakachanged: What|Removed |Added Attachment #170131|0 |1 is obsolete|| --- Comment #21 from Naomichi Nonaka --- Created attachment 170241 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=170241=edit boot1.c patch rev4 Bug fix. Thanks to Mr.ISHIZUKA. Naomichi Nonaka -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-amd64@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-amd64 To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"
[Bug 207940] [patch] sys/boot/efi/boot1 select boot partition
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207940 Masachika ISHIZUKAchanged: What|Removed |Added Attachment #169420|0 |1 is obsolete|| -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-amd64@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-amd64 To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"
[Bug 207940] [patch] sys/boot/efi/boot1 select boot partition
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207940 --- Comment #20 from Masachika ISHIZUKA--- (In reply to Naomichi Nonaka from comment #19) Thank you for ver3 patch. Although this is almost good for me, I have some minor comments. > * enter key means selecting autoboot (key 0) line number 521 should be "if (c == '\r') {". And line number 550 should be "move_to_tol();" to prevent from "Select from 0 to b. Timeout in 10 seconds, [Space] to pause : Select from 0 to b. Timeout in 10 seconds, [Space] to pause : " when I pressed 'z'. -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-amd64@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-amd64 To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"
[Bug 207940] [patch] sys/boot/efi/boot1 select boot partition
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207940 --- Comment #19 from Naomichi Nonaka--- (In reply to Masachika ISHIZUKA from comment #17) I just posted patch rev3. which * merged Mr.ISHIZUKA's changes * improve event handling. now no key input delay. * changed UI so that * space key stops timeout * enter key means selecting autoboot (key 0) I hope you try this. thanks. -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-amd64@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-amd64 To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"
[Bug 207940] [patch] sys/boot/efi/boot1 select boot partition
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207940 Naomichi Nonakachanged: What|Removed |Added Attachment #168291|0 |1 is obsolete|| --- Comment #18 from Naomichi Nonaka --- Created attachment 170131 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=170131=edit boot1.c patch rev3 -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-amd64@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-amd64 To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"
[Bug 207940] [patch] sys/boot/efi/boot1 select boot partition
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207940 --- Comment #17 from Masachika ISHIZUKA--- Created attachment 169420 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=169420=edit small change I changed the following to ver2 patch. (1) when push any key other than partition select number or retry of boot failure, timeout count is stopped. (2) partition number is decimal with p, ie hd(a)-> hd(p10). (3) partition size is shown, ie hd(p10) (100G). (4) maximum partition number(NUM_DEV_LIST) for selection is 35. (5) number on select menu is shown in both the left and right. Actually it labels also wanted to display, but I have to give up because it is a little difficult going. -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-amd64@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-amd64 To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"
[Bug 207940] [patch] sys/boot/efi/boot1 select boot partition
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207940 --- Comment #15 from Naomichi Nonaka--- OK, I found my mistake. I had written "set boot_disk_unit=0" in /boot/loader.conf. after removing that line. rev2 boot1 can boot to external drive. # I wrote that line in very early stage of my testing and forgot that. for boot drive choise, I found 10.2R boot1.efi boot to external drive. So I assume Mr. ISIZUKA had installed 10.2R to internal drive, and when upgraded to 10.3R, boot1.efi had not upgraded to 10.3R. You can check size of boot1.efi. 10.2R is about 33K, 10.3R is about 74K, and rev2 is about 82K. Summary: when both internal drive and external drive have bootable partition. *10.2R boot1.efi -> autoboot to external drive *10.3R boot1.efi -> autoboot to internal drive *rev2 boot1.efi -> show partition list. can boot to either internal or external by keyin timeout boot to internal -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-amd64@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-amd64 To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"
[Bug 207940] [patch] sys/boot/efi/boot1 select boot partition
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207940 --- Comment #16 from Masachika ISHIZUKA--- (In reply to Naomichi Nonaka from comment #15) Thank you for your report details. % ls -l /mnt2/EFI/freebsd/boot1.efi -rwxr-xr-x 1 ishizuka j5p 33262 Sep 19 2014 /mnt2/EFI/freebsd/boot1.efi My boot1.efi is very older than 10.3R. By the way, ver2 boot1 it did not work cause was found in my PC. Again my PC of UEFI of the bug was due. Input waiting loop for 10 seconds is done at the moment, and keyboard input is not recognized. Then, timer and keyboard input is restored to within to change several times a UEFI option on my PC, now works properly. I'm sorry to you fuss. The external UBS disk and internal disk is selectable by ver2 boot1 loader on internal disk. -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-amd64@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-amd64 To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"
[Bug 207940] [patch] sys/boot/efi/boot1 select boot partition
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207940 --- Comment #14 from Naomichi Nonaka--- Thank you for quick reply. > select menu was not displayed. It means boot1 found only 1 bootable partition. I might think boot1 could not recognize external drive is "varid" because of lack of EFI partiotion. Sorry, it may take some time to prepare test environment. > I can remove win8.1pro and if I can select boot partitions for FreeBSD > without setting bootme, I will install 11.0-current to internal drive. I assume rev2 boot1 can do that. It's (almost) same configuration as my test PC. I'm very happy if you try. But, unfortunately, there are too many variant and bugs in UEFI firm, I can't tell if it really work or not. sigh. -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-amd64@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-amd64 To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"
[Bug 207940] [patch] sys/boot/efi/boot1 select boot partition
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207940 --- Comment #12 from Naomichi Nonaka--- (In reply to Masachika ISHIZUKA from comment #11) Mr. ISHIZAKI, Thanks for testing. I tried, but in my PC, both 10.3-boot1.efi and my rev2 boot1.efi in internal drive can boot to internal drive only. If you want to boot from external drive, you can choose external drive in "UEFI boot drive selection" menu. It is helpful for me if you could show details such as 1. your external drive is MBR partition or GPT partition. 2. what partitions are shown in rev2 patched boot1.efi. 2a you can't see external drive in boot1.efi's partition list. or 2b you see external drive in list, select it, but booted from internal 3 your external drive is connected via USB or eSATA. Regards, Naomichi Nonaka -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-amd64@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-amd64 To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"
[Bug 207940] [patch] sys/boot/efi/boot1 select boot partition
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207940 Masachika ISHIZUKAchanged: What|Removed |Added CC||i...@amail.plala.or.jp --- Comment #11 from Masachika ISHIZUKA --- I tested on 10.3-RELEASE. The patch can be applied without errors. Original version of boot1.efi on an internal drive can boot from an external drive, if I connected an external drive. The rev2 patched version of boot1.efi on an internal drive can boot only from the same internal drive. I want to be able to boot from other drives. -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-amd64@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-amd64 To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"
[Bug 207940] [patch] sys/boot/efi/boot1 select boot partition
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207940 Tomoaki AOKIchanged: What|Removed |Added CC||junch...@dec.sakura.ne.jp --- Comment #7 from Tomoaki AOKI --- (In reply to Steven Hartland from comment #1) Comparing with MBR ones, current in-tree version (you fixed recently) corresponds to boot0 (512 bytes version), while Naomichi's first version corresponds to boot0ext (1024 bytes version). And Naomichi's second version is the combined one. If someone using boot0ext wants to move to UEFI(GPT) environment, Naomichi's one would help. -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-amd64@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-amd64 To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"
[Bug 207940] [patch] sys/boot/efi/boot1 select boot partition
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207940 --- Comment #9 from Steven Hartland--- (In reply to Tomoaki AOKI from comment #8) That would work without this change. -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-amd64@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-amd64 To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"
[Bug 207940] [patch] sys/boot/efi/boot1 select boot partition
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207940 --- Comment #10 from Tomoaki AOKI--- (In reply to Steven Hartland from comment #9) I know. :-) I mean that rev.1 of Nomichi's patch always required manual-select of partition, without default and timeout, but in rev.2, default selection (compatible with already MFC'ed version) is added as #0 with timeout support. -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-amd64@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-amd64 To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"
[Bug 207940] [patch] sys/boot/efi/boot1 select boot partition
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207940 --- Comment #6 from Naomichi Nonaka--- I created patch rev2 which has input timeout functionality. So, now it works as original if there are no key in. I'm not English native tonge. It's helpful if someone check this patch's displaying messages. -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-amd64@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-amd64 To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"
[Bug 207940] [patch] sys/boot/efi/boot1 select boot partition
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207940 --- Comment #8 from Tomoaki AOKI--- (In reply to Naomichi Nonaka from comment #6) Tried, and working as expected for me. ThinkPad T420 with 2 drives (second one is in UltraBay adapter), each drive have one UFS partition and one ZFS pool. The default matches current in-tree boot1.efi, either booted from internal first drive or second drive in UltraBay. *Means that if I select first drive with UEFI firmware, ZFS pool in first drive is auto-selected, and that if I select second drive, ZFS pool in second drive is auto-selected. -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-amd64@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-amd64 To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"
[Bug 207940] [patch] sys/boot/efi/boot1 select boot partition
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207940 Naomichi Nonakachanged: What|Removed |Added Attachment #168291|add input timeout |boot1 patch rev2 description|| - add ||input timeout -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-amd64@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-amd64 To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"
[Bug 207940] [patch] sys/boot/efi/boot1 select boot partition
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207940 o...@hardenedbsd.org changed: What|Removed |Added Flags||mfc-stable10? --- Comment #4 from o...@hardenedbsd.org --- Add this PR as dependency to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203349 ? -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-amd64@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-amd64 To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"
[Bug 207940] [patch] sys/boot/efi/boot1 select boot partition
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207940 --- Comment #2 from Naomichi Nonaka--- (In reply to Steven Hartland from comment #1) Sorry for inadequate format. It's my first PR and I couldn't find these rules in Web page. I'll do in next time. I wrote this patch to select booting 10.3 or 11 which are installed on different partitions in one HD. It's useful for me. -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-amd64@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-amd64 To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"
[Bug 207940] [patch] sys/boot/efi/boot1 select boot partition
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207940 Steven Hartlandchanged: What|Removed |Added CC||s...@freebsd.org --- Comment #1 from Steven Hartland --- Out of interest why would this be needed? Also as rule upload the patch without compression it and flag it as a patch as that makes it easer to quickly review. -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-amd64@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-amd64 To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"
[Bug 207940] [patch] sys/boot/efi/boot1 select boot partition
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207940 Bug ID: 207940 Summary: [patch] sys/boot/efi/boot1 select boot partition Product: Base System Version: 11.0-CURRENT Hardware: amd64 OS: Any Status: New Keywords: patch Severity: Affects Many People Priority: --- Component: kern Assignee: freebsd-b...@freebsd.org Reporter: n...@enuenu.org CC: freebsd-amd64@FreeBSD.org Keywords: patch CC: freebsd-amd64@FreeBSD.org Created attachment 168070 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=168070=edit patch for efi boot1 partition selection Current efi boo1 allows boot from auto-selected (first match) partition only. I write patch to allow boot-time partiton selection for boot1.efi. -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-amd64@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-amd64 To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"